phy: qcom-qmp: misc cleanups
Subsystems (2)
PATCH 2/3 phy: qcom-qmp-usb: drop redundant clock allocation
In reply to Johan HovoldSince the QMP driver split, there is no reason to allocate the fixed-rate pipe clock structure separately from the driver data.
--- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp-usb.c +3 -5
@@ -1485,6 +1485,8 @@ struct qmp_usb {enum phy_mode mode;struct phy *phy; + +struct clk_fixed_rate pipe_clk_fixed; };static inline void qphy_setbits (void __iomem *base,u32 offset,u32 val)
@@ -2357,7 +2359,7 @@ static void phy_clk_release_provider(void *res)*/ static int phy_pipe_clk_register (struct qmp_usb *qmp,struct device_node *np) { -struct clk_fixed_rate *fixed; +struct clk_fixed_rate *fixed = &qmp->pipe_clk_fixed;struct clk_init_data init = { };int ret;
@@ -2367,10 +2369,6 @@ static int phy_pipe_clk_register(struct qmp_usb *qmp, struct device_node *np)return ret; } - fixed =devm_kzalloc (qmp->dev,sizeof (*fixed),GFP_KERNEL ); -if (!fixed) -return -ENOMEM ; - init.ops = &clk_fixed_rate_ops;/* controllers using QMP phys use 125MHz pipe clock interface */
Signature · 1 line
2.37.4
PATCH 3/3 phy: qcom-qmp-pcie: drop redundant clock allocation
In reply to Johan HovoldSince the QMP driver split, there is no reason to allocate the fixed-rate pipe clock structure separately from the driver data.
--- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +3 -5
@@ -1546,6 +1546,8 @@ struct qmp_pcie {struct phy *phy;int mode; + +struct clk_fixed_rate pipe_clk_fixed; };static inline void qphy_setbits (void __iomem *base,u32 offset,u32 val)
@@ -2410,7 +2412,7 @@ static void phy_clk_release_provider(void *res)*/ static int phy_pipe_clk_register (struct qmp_pcie *qmp,struct device_node *np) { -struct clk_fixed_rate *fixed; +struct clk_fixed_rate *fixed = &qmp->pipe_clk_fixed;struct clk_init_data init = { };int ret;
@@ -2420,10 +2422,6 @@ static int phy_pipe_clk_register(struct qmp_pcie *qmp, struct device_node *np)return ret; } - fixed =devm_kzalloc (qmp->dev,sizeof (*fixed),GFP_KERNEL ); -if (!fixed) -return -ENOMEM ; - init.ops = &clk_fixed_rate_ops;/*
Signature · 1 line
2.37.4
PATCH 1/3 phy: qcom-qmp: drop unused type header
In reply to Johan HovoldThe PHY type defines are no longer used in the PCIe, UFS and USB QMP drivers so drop the corresponding include.
--- drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2 -- 4 files changed, 8 deletions(-)
drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c +0 -2
@@ -20,8 +20,6 @@#include <linux/reset.h> #include <linux/slab.h> -#include <dt-bindings/phy/phy.h> -#include "phy-qcom-qmp.h" /* QPHY_SW_RESET bit */
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +0 -2
@@ -23,8 +23,6 @@#include <linux/reset.h> #include <linux/slab.h> -#include <dt-bindings/phy/phy.h> -#include "phy-qcom-qmp.h" /* QPHY_SW_RESET bit */
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c +0 -2
@@ -20,8 +20,6 @@#include <linux/reset.h> #include <linux/slab.h> -#include <dt-bindings/phy/phy.h> -#include "phy-qcom-qmp.h" /* QPHY_SW_RESET bit */
drivers/phy/qualcomm/phy-qcom-qmp-usb.c +0 -2
@@ -20,8 +20,6 @@#include <linux/reset.h> #include <linux/slab.h> -#include <dt-bindings/phy/phy.h> -#include "phy-qcom-qmp.h" /* QPHY_SW_RESET bit */
Signature · 1 line
2.37.4
cover phy: qcom-qmp: misc cleanups
Here are three cleanups to the non-combo QMP drivers for smaller issues found while reworking the combo driver.
Johan
Johan Hovold (3):
phy: qcom-qmp: drop unused type header
phy: qcom-qmp-usb: drop redundant clock allocation
phy: qcom-qmp-pcie: drop redundant clock allocation
drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 10 +++------- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 10 +++------- 4 files changed, 6 insertions(+), 18 deletions(-)
Signature · 1 line
2.37.4
Re: [PATCH 1/3] phy: qcom-qmp: drop unused type header
In reply to Johan HovoldQuoted 10 lines · Johan Hovold
The PHY type defines are no longer used in the PCIe, UFS and USB QMP drivers so drop the corresponding include.
Signed-off-by Johan Hovold <[email protected]>--- drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 2 -- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2 -- 4 files changed, 8 deletions(-)
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH 2/3] phy: qcom-qmp-usb: drop redundant clock allocation
In reply to Johan HovoldQuoted 7 lines · Johan Hovold
Since the QMP driver split, there is no reason to allocate the fixed-rate pipe clock structure separately from the driver data.
Signed-off-by Johan Hovold <[email protected]>--- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
Signature · 8 lines
With best wishes Dmitry -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH 3/3] phy: qcom-qmp-pcie: drop redundant clock allocation
In reply to Johan HovoldQuoted 7 lines · Johan Hovold
Since the QMP driver split, there is no reason to allocate the fixed-rate pipe clock structure separately from the driver data.
Signed-off-by Johan Hovold <[email protected]>--- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
Signature · 8 lines
With best wishes Dmitry -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy