Skip to contentSkip to conversation

: FreeBSD DCO supports AES-192-GCM

PATCH In review Kristof Provost 3 participants 6 messages Nov 11, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : FreeBSD DCO supports AES-192-GCM

Minor update, but FreeBSD's if_ovpn now also supports AES-192-GCM. We may as well announce this support.

Best regards,
Kristof

#1 lore raw

PATCH 1/1 FreeBSD DCO: support AES-192-GCM

From: Kristof Provost <[email protected]...>

As of 2c58d0cb3bb3e3a5b714ffac940500efbe5303ca FreeBSD also allows AES-192-GCM in DCO. Announce this support.

---
 src/openvpn/dco_freebsd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/dco_freebsd.c +1 -1
index c8361028..8e5ee436 100644
@@ -667,7 +667,7 @@ dco_event_set(dco_context_t *dco, struct event_set *es, void *arg)
 const char *
 dco_get_supported_ciphers()
 {
-    return "none:AES-256-GCM:AES-128-GCM:CHACHA20-POLY1305";
+    return "none:AES-256-GCM:AES-192-GCM:AES-128-GCM:CHACHA20-POLY1305";
 }
 
 #endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
Signature · 1 line
2.38.1
#4 lore raw
In reply to Kristof Provost

Am 11.11.2022 um 11:20 schrieb Kristof Provost via Openvpn-devel:

Quoted 3 lines

Minor update, but FreeBSD's if_ovpn now also supports AES-192-GCM. We may as well announce this support.

This seems to be missing the patch.

Arne

#5 lore raw
Quoted 6 lines · Arne Schwabe

Am 11.11.2022 um 11:20 schrieb Kristof Provost via Openvpn-devel:

Quoted 3 lines

Minor update, but FreeBSD's if_ovpn now also supports AES-192-GCM. We may as well announce this support.

This seems to be missing the patch.

Git’s send-email sent it as a separate mail, which has turned up with a bit of a delay for me. I’m hoping it’ll actually turn up for you too, but in the mean time:

	From: Kristof Provost <[email protected]...>

	As of 2c58d0cb3bb3e3a5b714ffac940500efbe5303ca FreeBSD also allows
	AES-192-GCM in DCO. Announce this support.

	Signed-off-by: Kristof Provost <[email protected]...>
	---
	 src/openvpn/dco_freebsd.c | 2 +-
	 1 file changed, 1 insertion(+), 1 deletion(-)

	diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c
	index c8361028..8e5ee436 100644
	--- a/src/openvpn/dco_freebsd.c
	+++ b/src/openvpn/dco_freebsd.c
	@@ -667,7 +667,7 @@ dco_event_set(dco_context_t *dco, struct event_set 

*es, void *arg)
const char *
dco_get_supported_ciphers()
{
- return "none:AES-256-GCM:AES-128-GCM:CHACHA20-POLY1305";
+ return

"none:AES-256-GCM:AES-192-GCM:AES-128-GCM:CHACHA20-POLY1305";
	 }
	
	 #endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
	--
	2.38.1

Best regards,
Kristof

Acked-by on v1 1/1
#2 lore raw

Re: [Openvpn-devel] [PATCH] FreeBSD DCO: support AES-192-GCM

In reply to Kristof Provost

Am 11.11.22 um 11:20 schrieb Kristof Provost via Openvpn-devel:

Quoted 15 lines

From: Kristof Provost <[email protected]...>

As of 2c58d0cb3bb3e3a5b714ffac940500efbe5303ca FreeBSD also allows AES-192-GCM in DCO. Announce this support.

---
  src/openvpn/dco_freebsd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/dco_freebsd.c +0 -0
index c8361028..8e5ee436 100644

src/openvpn/dco_freebsd.c dco_event_set(dco_context_t *dco, struct event_set *es, void *arg) · line 673

Quoted 8 lines
src/openvpn/dco_freebsd.c +1 -1
@@ -667,7 +667,7 @@ dco_event_set(dco_context_t *dco, struct event_set *es, void *arg)
  const char *
  dco_get_supported_ciphers()
  {
-    return "none:AES-256-GCM:AES-128-GCM:CHACHA20-POLY1305";
+    return "none:AES-256-GCM:AES-192-GCM:AES-128-GCM:CHACHA20-POLY1305";
  }
 
  #endif /* defined(ENABLE_DCO) && defined(TARGET_FREEBSD) */
#3 lore raw

[Openvpn-devel] [PATCH applied] Re: FreeBSD DCO: support AES-192-GCM

In reply to Kristof Provost

I have not actually tested this - but if you say it works kernel-side, the patch in itself is trivial enough :-)

Your patch has been applied to the master branch.

commit 115559aa34c0ae20ba5628e8becf09af990fc97f

Author: Kristof Provost
Date:   Fri Nov 11 11:20:31 2022 +0100
     FreeBSD DCO: support AES-192-GCM

     Signed-off-by: Kristof Provost <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg25506.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering