Skip to contentSkip to conversation

spi: cadence-qspi: use STIG mode for small reads

PATCH In review Dhruva Gole 1 participant 2 messages Nov 11, 2022 – Nov 15, 2022 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: cadence-qspi: use STIG mode for small reads

Fix the issue where some flash chips like cypress S25HS256T for example return the value of the same register once a SPI transaction starts. So for example if read reg of 0x2 is requested and we start reading registers in DAC mode we start reading 4 byte aligned ie. 0x0, 0x1, 0x2 and then 0x3. In such a case the flash chip keeps returning the value of 0x0 even though we actually want the value of 0x2.
STIG mode solves the above issue by not issuing a read continuosly for 4 byte aligned data.

---

Tested using a TI AM 625 SK-EVM with a QSPI Flash on board. sf read, upate and also booted up using xSPI mode till uboot prompt.

 drivers/spi/cadence_qspi.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
drivers/spi/cadence_qspi.c +16 -1
index ab0a681c8376..6f2924fe4515 100644
@@ -307,7 +307,22 @@ static int cadence_spi_mem_exec_op(struct spi_slave *spi,
 				    priv->is_decoded_cs);
 
 	if (op->data.dir == SPI_MEM_DATA_IN && op->data.buf.in) {
-		if (!op->addr.nbytes)
+	/*
+	 * In some cases there is a layer of digital logic in front of the QSPI
+	 * /OSPI Driver when used in DAC mode. This digital logic layer ensures
+	 * that even if we are trying to read 1 or 2 bytes of data, it will
+	 * always align it to 4 bytes from a 4byte aligned address. In some
+	 * flash chips like cypress for example, if we try to read some regs
+	 * in DAC mode then it keeps sending the value of the first register
+	 * who was requested and inorder to read the next register we have to
+	 * stop and re-initiate a new transaction.
+	 * This causes wrong registers values to be read than what is desired
+	 * when registers are read in DAC mode. Hence if the data.nbytes
+	 * is very less then do not use DAC mode. Registers are generally only
+	 * 1-2 bytes and thus switching to STIG mode will be a work around.
+	 */
+		if (!op->addr.nbytes ||
+		    op->data.nbytes < CQSPI_STIG_DATA_LEN_MAX)
 			mode = CQSPI_STIG_READ;
 		else
 			mode = CQSPI_READ;
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 9 lines · Dhruva Gole

Fix the issue where some flash chips like cypress S25HS256T for example return the value of the same register once a SPI transaction starts. So for example if read reg of 0x2 is requested and we start reading registers in DAC mode we start reading 4 byte aligned ie. 0x0, 0x1, 0x2 and then 0x3. In such a case the flash chip keeps returning the value of 0x0 even though we actually want the value of 0x2.
STIG mode solves the above issue by not issuing a read continuosly for 4 byte aligned data.

Quoted 3 lines

---

[...]

Kindly disregard this, and rather look at the v2 patch series I have posted:
https://lore.kernel.org/u-boot/[email protected]/

The patch DEPENDs on the new patch I have sent in the v2.

Signature · 2 lines
Thanks and Regards,
Dhruva Gole