fpga-manager: use devm_platform_get_and_ioremap_resource()
PATCH 1/1 fpga-manager: use devm_platform_get_and_ioremap_resource()
From: Minghao Chi <[email protected]>
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.
--- drivers/fpga/socfpga-a10.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/fpga/socfpga-a10.c +1 -2
@@ -479,8 +479,7 @@ static int socfpga_a10_fpga_probe(struct platform_device *pdev)return -ENOMEM ;/* First mmio base is for register access */ - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - reg_base =devm_ioremap_resource (dev, res); + reg_base =devm_platform_get_and_ioremap_resource (pdev,0 , &res);if (IS_ERR (reg_base))return PTR_ERR (reg_base);
Signature · 1 line
2.25.1
Xu Yilun
maintainerQuoted 8 lines · On 2022-11-11 at 14:41:16 +0800, [email protected] wrote:
From: Minghao Chi <[email protected]>
Convert
platform_get_resource(),devm_ioremap_resource()to a single call todevm_platform_get_and_ioremap_resource(), as this is exactly what this function does.Reported-by Zeal Robot <[email protected]>Signed-off-by Minghao Chi <[email protected]>
Please add your own SoB.
Quoted 9 lines
--- drivers/fpga/socfpga-a10.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/fpga/socfpga-a10.c +0
-0
drivers/fpga/socfpga-a10.c static int socfpga_a10_fpga_probe(struct platform_device *pdev) · line 482
Quoted 6 lines
drivers/fpga/socfpga-a10.c +1
-2@@ -479,8 +479,7 @@ static int socfpga_a10_fpga_probe(struct platform_device *pdev)return -ENOMEM ;/* First mmio base is for register access */ - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - reg_base =devm_ioremap_resource (dev, res); + reg_base =devm_platform_get_and_ioremap_resource (pdev,0 , &res);
Why keep the variable res?
drivers/fpga/socfpga-a10.c static int socfpga_a10_fpga_probe(struct platform_device *pdev) · line 484
Quoted 2 lines
drivers/fpga/socfpga-a10.c +0
-0if (IS_ERR (reg_base))return PTR_ERR (reg_base);
And please make all related changes, at least in driver/fpga.
Thanks,
Yilun
Quoted 3 lines
Signature · 2 lines
-- 2.25.1