Files in include/trace/events
Subsystems (3)
Hi Chuck,
I was just looking over some files in include/trace/events/ and noticed that there's sunrpc_base.h, fs.h and nfs.h that are not event files.
The include/trace/events/ directory should only hold files that are to create events, not headers that hold helper functions.
Can you please move them out of include/trace/events/ as that directory is "special" in the creation of events.
Perhaps we could create a new directory include/linux/trace/ or include/trace/linux/ specific for these types of files?
Thanks!
-- Steve
Quoted 5 lines · On Sat, 12 Nov 2022 07:27:42 -0500 Steven Rostedt <[email protected]> wrote:
Hi Chuck,
I was just looking over some files in
include/trace/events/and noticed that there'ssunrpc_base.h,fs.handnfs.hthat are not event files.
Quoted 9 lines
The
include/trace/events/directory should only hold files that are to create events, not headers that hold helper functions.Can you please move them out of
include/trace/events/as that directory is "special" in the creation of events.Perhaps we could create a new directory
include/linux/trace/orinclude/trace/linux/specific for these types of files?
Hi Vlastimil,
I also noticed that mmflags.h is in that directory too.
I'd like to keep only headers defining TRACE_EVENT() in that directory, as files there have special meaning.
Thanks,
-- Steve
Quoted 18 lines · Steven Rostedt
Quoted 5 lines · On Sat, 12 Nov 2022 07:27:42 -0500 Steven Rostedt <[email protected]> wrote:
Hi Chuck,
I was just looking over some files in
include/trace/events/and noticed that there'ssunrpc_base.h,fs.handnfs.hthat are not event files.Quoted 9 lines
The
include/trace/events/directory should only hold files that are to create events, not headers that hold helper functions.Can you please move them out of
include/trace/events/as that directory is "special" in the creation of events.Perhaps we could create a new directory
include/linux/trace/orinclude/trace/linux/specific for these types of files?
Quoted 6 lines
Hi Vlastimil,
I also noticed that
mmflags.his in that directory too.I'd like to keep only headers defining
TRACE_EVENT()in that directory, as files there have special meaning.
I guess we could move that one to e.g. mm/mmflags.h as it's used also outside of trace events anyway (mm/debug.c), but it's not something to expose to general use in include/ But most includes are from proper include/trace/events/*.h headers so dunno, maybe include/trace/<something>/mmflags.h would be more appropriate.
Quoted 3 lines
Thanks,
-- Steve
Quoted 9 lines · Steven Rostedt
Hi Chuck,
I was just looking over some files in
include/trace/events/and noticed that there'ssunrpc_base.h,fs.handnfs.hthat are not event files.
Quoted 8 lines
The
include/trace/events/directory should only hold files that are to create events, not headers that hold helper functions.Can you please move them out of
include/trace/events/as that directory is "special" in the creation of events.Perhaps we could create a new directory
include/linux/trace/orinclude/trace/linux/specific for these types of files?
I can take responsibility for moving the helper files I created. IIRC there are a few from the RDMA core subsystem as well.
But let's first decide on a proper destination for such files. A sister directory to include/trace/events, like
include/trace/ < something >
makes sense to me.
--
Chuck Lever