Skip to contentSkip to conversation

net/mlx5: fix wrong error log in async flow destruction

PATCH In review Michael Baum 2 participants 2 messages Nov 13, 2022 – Nov 16, 2022 Network drivers

lore
Share & tools
lore

Michael Baum

author
#0 lore raw

PATCH 1/1 net/mlx5: fix wrong error log in async flow destruction

The flow_hw_async_flow_destroy() function fills the error structure in case of failure.

The error log reported by function is "fail to create rte flow" while the correct failure is in destruction.

This patch changes the error log to report "fail to destroy rte flow".

Fixes c40c061a022e ("net/mlx5: add basic flow queue operation")
Cc [email protected]
Cc [email protected]
Signed-off-by Michael Baum <[email protected]>
Acked-by Matan Azrad <[email protected]>
---
 drivers/net/mlx5/mlx5_flow_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5_flow_hw.c +1 -1
index 537bcf141d..979eec8dc4 100644
@@ -2623,7 +2623,7 @@ flow_hw_async_flow_destroy(struct rte_eth_dev *dev,
 error:
 	return rte_flow_error_set(error, rte_errno,
 			RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
-			"fail to create rte flow");
+			"fail to destroy rte flow");
 }
 
 /**
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 15 lines

-----Original Message-----
From: Michael Baum <[email protected]>
Sent: Sunday, November 13, 2022 1:07 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Suanming Mou <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: fix wrong error log in async flow destruction

The flow_hw_async_flow_destroy() function fills the error structure in case of failure.

The error log reported by function is "fail to create rte flow" while the correct failure is in destruction.

Quoted 8 lines

This patch changes the error log to report "fail to destroy rte flow".

Fixes c40c061a022e ("net/mlx5: add basic flow queue operation")
Cc [email protected]
Cc [email protected]
Signed-off-by Michael Baum <[email protected]>
Acked-by Matan Azrad <[email protected]>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh