PCI: vmd: Clean up some inconsistent indenting
Subsystems (3)
PATCH 1/1 PCI: vmd: Clean up some inconsistent indenting
No functional modification involved.
drivers/pci/controller/vmd.c:983 vmd_resume() warn: inconsistent indenting.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Chong <[email protected]>
--- drivers/pci/controller/vmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pci/controller/vmd.c +4 -4
@@ -980,10 +980,10 @@ static int vmd_resume(struct device *dev)struct vmd_dev *vmd =pci_get_drvdata (pdev);int err, i; -if (vmd->irq_domain) -vmd_set_msi_remapping (vmd, true); -else -vmd_set_msi_remapping (vmd, false); +if (vmd->irq_domain) +vmd_set_msi_remapping (vmd, true); +else +vmd_set_msi_remapping (vmd, false);for (i =0 ; i < vmd->msix_count; i++) { err = devm_request_irq(dev, vmd->irqs[i].virq,
Signature · 1 line
2.20.1.7.g153144c
drivers/pci/controller/vmd.c static int vmd_resume(struct device *dev) · line 986
Quoted 4 lines · Jiapeng Chong
drivers/pci/controller/vmd.c +4
-0+if (vmd->irq_domain) +vmd_set_msi_remapping (vmd, true); +else +vmd_set_msi_remapping (vmd, false);
Why not go one step further:
vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
?
Hello,
Quoted 8 lines
drivers/pci/controller/vmd.c static int vmd_resume(struct device *dev) · line 986
Quoted 4 lines
drivers/pci/controller/vmd.c +4
-0+if (vmd->irq_domain) +vmd_set_msi_remapping (vmd, true); +else +vmd_set_msi_remapping (vmd, false);Why not go one step further:
vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
Jiapeng, if you want to get this patch merged, and it's a nice clean-up, then apply suggestion from Christoph and send a v2, if possible.
Krzysztof
Quoted 20 lines · Jiapeng Chong
No functional modification involved.
drivers/pci/controller/vmd.c:983vmd_resume()warn: inconsistent indenting.Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Chong <[email protected]>--- drivers/pci/controller/vmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/pci/controller/vmd.c +0
-1@@ -980,10 +980,10 @@ static int vmd_resume(struct device *dev)struct vmd_dev *vmd =pci_get_drvdata (pdev);int err, i; -if (vmd->irq_domain)
drivers/pci/controller/vmd.c static int vmd_resume(struct device *dev) · line 989
Quoted 10 lines
drivers/pci/controller/vmd.c +4
-3-vmd_set_msi_remapping (vmd, true); - else -vmd_set_msi_remapping (vmd ,false ); +if (vmd->irq_domain) +vmd_set_msi_remapping (vmd, true); +else +vmd_set_msi_remapping (vmd, false);for (i =0 ; i < vmd->msix_count; i++) { err = devm_request_irq(dev, vmd->irqs[i].virq,
Reviewed-by Nirmal Patel <[email protected]>
Thanks