KVM: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
PATCH 1/1 KVM: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
From: guo ziliang <[email protected]>
Fix the following coccicheck warning:
/virt/kvm/kvm_main.c: 3849: 0-23: WARNING: vcpu_get_pid_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
---virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/kvm_main.c +0 -0
@@ -3846,7 +3846,7 @@ static int vcpu_get_pid(void *data, u64 *val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n"); ++DEFINE_DEBUGFS_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");
static void kvm_create_vcpu_debugfs(struct kvm_vcpu *vcpu) {
--
1.8.3.1
Quoted 15 lines · On Tue, Nov 15, 2022, [email protected] wrote:
From: guo ziliang <[email protected]>
Fix the following coccicheck warning:
/virt/kvm/kvm_main.c: 3849: 0-23: WARNING:vcpu_get_pid_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTESigned-off-by guo ziliang <[email protected]>---
virt/kvm/kvm_main.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)virt/kvm/kvm_main.c +0
-0
virt/kvm/kvm_main.c static int vcpu_get_pid(void *data, u64 *val) · line 3849
Quoted 5 lines
virt/kvm/kvm_main.c +1
-1@@ -3846,7 +3846,7 @@ static int vcpu_get_pid(void *data, u64 *val)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (vcpu_get_pid_fops, vcpu_get_pid,NULL ,"%llu\n" ); ++DEFINE_DEBUGFS_ATTRIBUTE (vcpu_get_pid_fops, vcpu_get_pid,NULL ,"%llu\n" );
NAK, third time is not a charm.
https://lore.kernel.org/all/[email protected]
https://lore.kernel.org/all/[email protected]
Paolo Bonzini
maintainerQuoted 19 lines · Sean Christopherson
Quoted 18 lines · On Tue, Nov 15, 2022, [email protected] wrote:
From: guo ziliang <[email protected]>
Fix the following coccicheck warning:
/virt/kvm/kvm_main.c: 3849: 0-23: WARNING:vcpu_get_pid_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTESigned-off-by guo ziliang <[email protected]>---
virt/kvm/kvm_main.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)virt/kvm/kvm_main.c +0
-0@@ -3846,7 +3846,7 @@ static int vcpu_get_pid(void *data, u64 *val)return 0 ; }
Quoted 7 lines
virt/kvm/kvm_main.c static int vcpu_get_pid(void *data, u64 *val) · line 3849
Quoted 2 lines
virt/kvm/kvm_main.c +1
-1-DEFINE_SIMPLE_ATTRIBUTE (vcpu_get_pid_fops, vcpu_get_pid,NULL ,"%llu\n" ); ++DEFINE_DEBUGFS_ATTRIBUTE (vcpu_get_pid_fops, vcpu_get_pid,NULL ,"%llu\n" );NAK, third time is not a charm.
https://lore.kernel.org/all/[email protected]
https://lore.kernel.org/all/[email protected]
Screw it, I'm going to send a pull request just to delete that file.
Paolo
Sean Christopherson
reviewerQuoted 25 lines · Paolo Bonzini
Quoted 24 lines · Sean Christopherson
Quoted 15 lines · On Tue, Nov 15, 2022, [email protected] wrote:
From: guo ziliang <[email protected]>
Fix the following coccicheck warning:
/virt/kvm/kvm_main.c: 3849: 0-23: WARNING:vcpu_get_pid_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTESigned-off-by guo ziliang <[email protected]>---
virt/kvm/kvm_main.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)virt/kvm/kvm_main.c +0
-0virt/kvm/kvm_main.c static int vcpu_get_pid(void *data, u64 *val) · line 3849
Quoted 5 lines
virt/kvm/kvm_main.c +1
-1@@ -3846,7 +3846,7 @@ static int vcpu_get_pid(void *data, u64 *val)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (vcpu_get_pid_fops, vcpu_get_pid,NULL ,"%llu\n" ); ++DEFINE_DEBUGFS_ATTRIBUTE (vcpu_get_pid_fops, vcpu_get_pid,NULL ,"%llu\n" );NAK, third time is not a charm.
Quoted 4 lines
Quoted 2 lines
https://lore.kernel.org/all/[email protected]
https://lore.kernel.org/all/[email protected]Screw it, I'm going to send a pull request just to delete that file.
Heh, I was seriously considering sending a patch to do that too.