Skip to contentSkip to conversation

add hotplug depedency info

PATCH Superseded Albert Zhou 2 participants 4 messages Nov 15, 2022 PCI

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover add hotplug depedency info

v2->v3: Dependency comment made more precise and technical, as suggested by Mika Westerberg.

v1->v2: I added comments that PCIe cards with USB4 or Thunderbolt also require the hotplug feature. I also added the "default y if USB4" line to the relevant config options, as suggested by Lukas Wunner.

Albert Zhou (2):
pci: hotplug: add dependency info to Kconfig
pci: pcie: add dependency info to Kconfig

 drivers/pci/hotplug/Kconfig | 4 +++-
 drivers/pci/pcie/Kconfig    | 5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

base-commit: fef7fd48922d11b22620e19f9c9101647bfe943d

Signature · 1 line
2.34.1
#1 lore raw

PATCH v3 1/2 pci: hotplug: add dependency info to Kconfig

Thunderbolt/USB4 PCIe tunneling require the Hotplug feature. This is now recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is defaulted to Y if USB4 is selected.

---
 drivers/pci/hotplug/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/hotplug/Kconfig +3 -1
index 840a84bb5ee2..0b396a09ae15 100644
@@ -6,10 +6,12 @@
 menuconfig HOTPLUG_PCI
 	bool "Support for PCI Hotplug"
 	depends on PCI && SYSFS
+	default y if USB4
 	help
 	  Say Y here if you have a motherboard with a PCI Hotplug controller.
 	  This allows you to add and remove PCI cards while the machine is
-	  powered up and running.
+	  powered up and running. Thunderbolt/USB4 PCIe tunneling needs Native
+	  PCIe Hotplug to be enabled. PCIe Hotplug depends on PCI Hotplug.
 
 	  When in doubt, say N.
 

base-commit: e01d50cbd6eece456843717a566a34e8b926cf0c

Signature · 1 line
2.34.1
#2 lore raw

PATCH v3 2/2 pci: pcie: add dependency info to Kconfig

In reply to Albert Zhou

Thunderbolt/USB4 PCIe tunneling require the Hotplug feature. This is now recorded in the help message for HOTPLUG_PCI_PCIE. Further, PCIEPORTBUS and HOTPLUG_PCI_PCIE are defaulted to Y if USB4 is selected.

---
 drivers/pci/pcie/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/pci/pcie/Kconfig +4 -2
index 788ac8df3f9d..32cc9a31e228 100644
@@ -4,20 +4,22 @@
 #
 config PCIEPORTBUS
 	bool "PCI Express Port Bus support"
+	default y if USB4
 	help
 	  This enables PCI Express Port Bus support. Users can then enable
 	  support for Native Hot-Plug, Advanced Error Reporting, Power
 	  Management Events, and Downstream Port Containment.
-
 #
 # Include service Kconfig here
 #
 config HOTPLUG_PCI_PCIE
 	bool "PCI Express Hotplug driver"
 	depends on HOTPLUG_PCI && PCIEPORTBUS
+	default y if USB4
 	help
 	  Say Y here if you have a motherboard that supports PCI Express Native
-	  Hotplug
+	  Hotplug. Thunderbolt/USB4 PCIe tunneling needs Native PCIe Hotplug to
+	  be enabled
 
 	  When in doubt, say N.
 
Signature · 1 line
2.34.1
Reviewed-by on the v3 series
#3 lore raw
In reply to Albert Zhou
Quoted 10 lines · Albert Zhou

v2->v3: Dependency comment made more precise and technical, as suggested by Mika Westerberg.

v1->v2: I added comments that PCIe cards with USB4 or Thunderbolt also require the hotplug feature. I also added the "default y if USB4" line to the relevant config options, as suggested by Lukas Wunner.

Albert Zhou (2):
pci: hotplug: add dependency info to Kconfig
pci: pcie: add dependency info to Kconfig

For both,