platform: andes/ae350: Avoid repeated inclusion of header files
PATCH 1/1 platform: andes/ae350: Avoid repeated inclusion of header files
From: zhangleizheng <[email protected]>
Avoid cache.h reuse when compiling.
--- platform/andes/ae350/cache.h | 5 +++++ 1 file changed, 5 insertions(+)
platform/andes/ae350/cache.h +5 -0
@@ -7,6 +7,9 @@* Nylon Chen <[email protected]> */ +#ifndef _AE350_CACHE_H_ +#define _AE350_CACHE_H_ +uintptr_t mcall_set_mcache_ctl (unsigned long input);uintptr_t mcall_set_mmisc_ctl (unsigned long input);uintptr_t mcall_icache_op (unsigned int enable);
@@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);uintptr_t mcall_l1_cache_d_prefetch_op (unsigned long enable);uintptr_t mcall_non_blocking_load_store (unsigned long enable);uintptr_t mcall_write_around (unsigned long enable); + +#endif /* _AE350_CACHE_H_ */
Signature · 1 line
2.17.1
PATCH 1/1 platform: andes/ae350: Avoid repeated inclusion of header files
Quoted 6 lines · On Wed, Nov 16, 2022 at 3:29 PM <[email protected]> wrote:
From: zhangleizheng <[email protected]>
Avoid
cache.hreuse when compiling.Signed-off-by zhangleizheng <[email protected]>
nits: use "First Name" "Last Name" as the git.user.name
Quoted 19 lines
--- platform/andes/ae350/cache.h | 5 +++++ 1 file changed, 5 insertions(+)platform/andes/ae350/cache.h +3
-0@@ -7,6 +7,9 @@* Nylon Chen <[email protected]> */ +#ifndef _AE350_CACHE_H_ +#define _AE350_CACHE_H_ +uintptr_t mcall_set_mcache_ctl (unsigned long input);uintptr_t mcall_set_mmisc_ctl (unsigned long input);uintptr_t mcall_icache_op (unsigned int enable);
platform/andes/ae350/cache.h uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
Quoted 6 lines
platform/andes/ae350/cache.h +2
-1@@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);uintptr_t mcall_l1_cache_d_prefetch_op (unsigned long enable);uintptr_t mcall_non_blocking_load_store (unsigned long enable);uintptr_t mcall_write_around (unsigned long enable); + +#endif /* _AE350_CACHE_H_ */ --
Otherwise,
PATCH 1/1 platform: andes/ae350: Avoid repeated inclusion of header files
In reply to [email protected]Quoted 5 lines · zhangleizheng at eswincomputing.com
From: zhangleizheng <[email protected]>
Avoid
cache.hreuse when compiling.Signed-off-by zhangleizheng <[email protected]>
Looks good to me,
Thanks.
Quoted 27 lines
--- platform/andes/ae350/cache.h | 5 +++++ 1 file changed, 5 insertions(+)platform/andes/ae350/cache.h +5
-0@@ -7,6 +7,9 @@* Nylon Chen <[email protected]> */ +#ifndef _AE350_CACHE_H_ +#define _AE350_CACHE_H_ +uintptr_t mcall_set_mcache_ctl (unsigned long input);uintptr_t mcall_set_mmisc_ctl (unsigned long input);uintptr_t mcall_icache_op (unsigned int enable);@@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);uintptr_t mcall_l1_cache_d_prefetch_op (unsigned long enable);uintptr_t mcall_non_blocking_load_store (unsigned long enable);uintptr_t mcall_write_around (unsigned long enable); + +#endif /* _AE350_CACHE_H_ */ Signature · 1 line
2.17.1
PATCH 1/1 platform: andes/ae350: Avoid repeated inclusion of header files
Quoted 11 lines · Yu-Chien Peter Lin
Quoted 5 lines · zhangleizheng at eswincomputing.com
From: zhangleizheng <[email protected]>
Avoid
cache.hreuse when compiling.Signed-off-by zhangleizheng <[email protected]>Looks good to me,
Thanks.Reviewed-by Yu Chien Peter Lin <[email protected]>
Hi all,
I just removed andes/ae350 folder so let's skip this patch. Thanks for your fix.
Best regards,
Peter Lin
Quoted 28 lines
Quoted 28 lines
--- platform/andes/ae350/cache.h | 5 +++++ 1 file changed, 5 insertions(+)platform/andes/ae350/cache.h +5
-0@@ -7,6 +7,9 @@* Nylon Chen <[email protected]> */ +#ifndef _AE350_CACHE_H_ +#define _AE350_CACHE_H_ +uintptr_t mcall_set_mcache_ctl (unsigned long input);uintptr_t mcall_set_mmisc_ctl (unsigned long input);uintptr_t mcall_icache_op (unsigned int enable);@@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);uintptr_t mcall_l1_cache_d_prefetch_op (unsigned long enable);uintptr_t mcall_non_blocking_load_store (unsigned long enable);uintptr_t mcall_write_around (unsigned long enable); + +#endif /* _AE350_CACHE_H_ */ Signature · 1 line
2.17.1