Skip to contentSkip to conversation

nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G

PATCH In review August Wikerfors 4 participants 9 messages Nov 16, 2022 – Dec 21, 2022 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

nvme nvme0: identifiers changed for nsid 1

To fix this, add a quirk to ignore namespace identifiers for this device.

---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/nvme/host/pci.c +2 -1
index f4335519399d..0af51b85c323 100644
@@ -3500,7 +3500,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x1d97, 0x2263),   /* SPCC */
 		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
 	{ PCI_DEVICE(0x144d, 0xa80b),   /* Samsung PM9B1 256G and 512G */
-		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES |
+				NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x144d, 0xa809),   /* Samsung MZALQ256HBJD 256G */
 		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
 	{ PCI_DEVICE(0x1cc4, 0x6303),   /* UMIS RPJTJ512MGE1QDY 512G */
Signature · 1 line
2.38.1
#1 lore raw
Quoted 5 lines · August Wikerfors

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

nvme nvme0: identifiers changed for nsid 1

What EUI did it report before? Is the identifier stable after multiple resume cycles?

Can some of the Samsung folks here reach out to the relevant firmware team to see if they have any clues?

#2 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 5 lines · August Wikerfors

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

nvme nvme0: identifiers changed for nsid 1

What EUI did it report before? Is the identifier stable after multiple resume cycles?

The original EUI is "002538e621b440e5". Using the patches from [1] and [2] for debugging I consistently get this output on every resume:

Quoted 1 line

eui changed from 002538e621b440e5 to 0001000200030004

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/

#3 lore raw
Quoted 6 lines · August Wikerfors
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · August Wikerfors

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

nvme nvme0: identifiers changed for nsid 1

What EUI did it report before? Is the identifier stable after multiple resume cycles?

The original EUI is "002538e621b440e5". Using the patches from [1] and [2] for debugging I consistently get this output on every resume:

Quoted 1 line

eui changed from 002538e621b440e5 to 0001000200030004

Can you please share the firmware version of this SSD?

#4 lore raw
Quoted 7 lines · Kanchan Joshi
Quoted 6 lines · August Wikerfors
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · August Wikerfors

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

nvme nvme0: identifiers changed for nsid 1

What EUI did it report before? Is the identifier stable after multiple resume cycles?

The original EUI is "002538e621b440e5". Using the patches from [1] and [2] for debugging I consistently get this output on every resume:

Quoted 1 line

eui changed from 002538e621b440e5 to 0001000200030004

Can you please share the firmware version of this SSD?

The firmware version is 7L1QHXC7.

#5 lore raw
In reply to Christoph Hellwig
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · August Wikerfors

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

Quoted 7 lines
Quoted 1 line

nvme nvme0: identifiers changed for nsid 1

What EUI did it report before? Is the identifier stable after multiple resume cycles?

Can some of the Samsung folks here reach out to the relevant firmware team to see if they have any clues?

I will check.

#6 lore raw
Quoted 8 lines · Kanchan Joshi
Quoted 7 lines · Christoph Hellwig
Quoted 5 lines · August Wikerfors

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

nvme nvme0: identifiers changed for nsid 1

Quoted 7 lines
Quoted 5 lines

What EUI did it report before? Is the identifier stable after multiple resume cycles?

Can some of the Samsung folks here reach out to the relevant firmware team to see if they have any clues?

I will check.

Took more time than I wanted. Firmware team mentioned that issue existed in this firmware. This is fixed in new firmware, but bit of travel time is involved when official release from OEM (Lenovo) comes out.

Hope the information is sufficient, and quirk can go in.

If required, Acked-by: Kanchan Joshi <[email protected]>

#7 lore raw
Quoted 17 lines · Kanchan Joshi
Quoted 8 lines · Kanchan Joshi
Quoted 7 lines · Christoph Hellwig
Quoted 5 lines · August Wikerfors

The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg:

nvme nvme0: identifiers changed for nsid 1

Quoted 7 lines
Quoted 5 lines

What EUI did it report before? Is the identifier stable after multiple resume cycles?

Can some of the Samsung folks here reach out to the relevant firmware team to see if they have any clues?

I will check.

Quoted 7 lines

Took more time than I wanted. Firmware team mentioned that issue existed in this firmware. This is fixed in new firmware, but bit of travel time is involved when official release from OEM (Lenovo) comes out.

Hope the information is sufficient, and quirk can go in.

If required, Acked-by: Kanchan Joshi <[email protected]>

Ping, anything left for me to do before this can be merged?

Regards,
August Wikerfors

#8 lore raw
Quoted 9 lines · August Wikerfors
Quoted 7 lines

Took more time than I wanted. Firmware team mentioned that issue existed in this firmware. This is fixed in new firmware, but bit of travel time is involved when official release from OEM (Lenovo) comes out.

Hope the information is sufficient, and quirk can go in.

If required, Acked-by: Kanchan Joshi <[email protected]>

Ping, anything left for me to do before this can be merged?

We don't want to add quirks for things fixed by firmware updates, see the recently posted features and quirks policy.