Skip to contentSkip to conversation

platform: generic/allwinner: Optimize header file location

PATCH New [email protected] 3 participants 3 messages Nov 17, 2022 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform: generic/allwinner: Optimize header file location

From: Leizheng Zhang <[email protected]>

Optimize sbi/sbi_console.h file location

---
 platform/generic/allwinner/sun20i-d1.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
platform/generic/allwinner/sun20i-d1.c +1 -2
index 6a502e5..d2a0f53 100644
@@ -7,6 +7,7 @@
 #include <platform_override.h>
 #include <thead_c9xx.h>
 #include <sbi/riscv_io.h>
+#include <sbi/sbi_console.h>
 #include <sbi/sbi_bitops.h>
 #include <sbi/sbi_ecall_interface.h>
 #include <sbi/sbi_error.h>
@@ -201,8 +202,6 @@ static int sun20i_d1_final_init(bool cold_boot, const struct fdt_match *match)
 	return 0;
 }
 
-#include <sbi/sbi_console.h>
-
 static void thead_c9xx_pmu_ctr_enable_irq(uint32_t ctr_idx)
 {
 	unsigned long mip_val;
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 platform: generic/allwinner: Optimize header file location

Quoted 15 lines · On Thu, Nov 17, 2022 at 3:18 PM <[email protected]> wrote:

From: Leizheng Zhang <[email protected]>

Optimize sbi/sbi_console.h file location

---
 platform/generic/allwinner/sun20i-d1.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
platform/generic/allwinner/sun20i-d1.c +0 -0
index 6a502e5..d2a0f53 100644

platform/generic/allwinner/sun20i-d1.c line 10

Quoted 4 lines
platform/generic/allwinner/sun20i-d1.c +1 -0
@@ -7,6 +7,7 @@
 #include <platform_override.h>
 #include <thead_c9xx.h>
 #include <sbi/riscv_io.h>
+#include <sbi/sbi_console.h>

nits: alphabetically this should be inserted after sbi_bitops.h

platform/generic/allwinner/sun20i-d1.c static int sun20i_d1_final_init(bool cold_boot, const struct fdt_match *match)

Quoted 13 lines
platform/generic/allwinner/sun20i-d1.c +0 -3
 #include <sbi/sbi_bitops.h>
 #include <sbi/sbi_ecall_interface.h>
 #include <sbi/sbi_error.h>
@@ -201,8 +202,6 @@ static int sun20i_d1_final_init(bool cold_boot, const struct fdt_match *match)
        return 0;
 }
 
-#include <sbi/sbi_console.h>
-
 static void thead_c9xx_pmu_ctr_enable_irq(uint32_t ctr_idx)
 {
        unsigned long mip_val;
--

Otherwise,

maintainer
#2 lore raw

PATCH 1/1 platform: generic/allwinner: Optimize header file location

In reply to [email protected]
Quoted 14 lines · zhangleizheng at eswincomputing.com

From: Leizheng Zhang <[email protected]>

Optimize sbi/sbi_console.h file location

---
 platform/generic/allwinner/sun20i-d1.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
platform/generic/allwinner/sun20i-d1.c +0 -0
index 6a502e5..d2a0f53 100644

platform/generic/allwinner/sun20i-d1.c line 10

Quoted 4 lines
platform/generic/allwinner/sun20i-d1.c +1 -0
@@ -7,6 +7,7 @@
 #include <platform_override.h>
 #include <thead_c9xx.h>
 #include <sbi/riscv_io.h>
+#include <sbi/sbi_console.h>

This header is not actually used anywhere in the file, so you can just remove it.

Regards,
Samuel

Quoted 12 lines
platform/generic/allwinner/sun20i-d1.c +0 -2
 #include <sbi/sbi_bitops.h>
 #include <sbi/sbi_ecall_interface.h>
 #include <sbi/sbi_error.h>
@@ -201,8 +202,6 @@ static int sun20i_d1_final_init(bool cold_boot, const struct fdt_match *match)
 	return 0;
 }
 
-#include <sbi/sbi_console.h>
-
 static void thead_c9xx_pmu_ctr_enable_irq(uint32_t ctr_idx)
 {
 	unsigned long mip_val;