Skip to contentSkip to conversation

HID: hid-elan: use default remove for hid device

PATCH RESEND Applied Marcus Folkesson 2 participants 2 messages Nov 17, 2022 – Nov 21, 2022 HID

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 HID: hid-elan: use default remove for hid device

hid_device_remove() will call hid_hw_stop() as default .remove function if no function is specified.

---
 drivers/hid/hid-elan.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/hid/hid-elan.c +0 -6
index 8e4a5528e25d..76d93fc48f6a 100644
@@ -507,11 +507,6 @@ static int elan_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	return ret;
 }
 
-static void elan_remove(struct hid_device *hdev)
-{
-	hid_hw_stop(hdev);
-}
-
 static const struct hid_device_id elan_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_HP_X2),
 	  .driver_data = ELAN_HAS_LED },
@@ -529,7 +524,6 @@ static struct hid_driver elan_driver = {
 	.input_configured = elan_input_configured,
 	.raw_event = elan_raw_event,
 	.probe = elan_probe,
-	.remove = elan_remove,
 };
 
 module_hid_driver(elan_driver);
Signature · 1 line
2.38.1
maintainer Applied
#1 lore raw
Quoted 4 lines · Marcus Folkesson

hid_device_remove() will call hid_hw_stop() as default .remove function if no function is specified.

Applied.

Signature · 2 lines
Jiri Kosina
SUSE Labs