Skip to contentSkip to conversation

HID: hid-alps: use default remove for hid device

PATCH RESEND Applied Marcus Folkesson 2 participants 2 messages Nov 17, 2022 – Nov 21, 2022 HID

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 HID: hid-alps: use default remove for hid device

hid_device_remove() will call hid_hw_stop() as default .remove function if no function is specified.

---
 drivers/hid/hid-alps.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/hid/hid-alps.c +0 -6
index 2b986d0dbde4..9abaff6f3afb 100644
@@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	return 0;
 }
 
-static void alps_remove(struct hid_device *hdev)
-{
-	hid_hw_stop(hdev);
-}
-
 static const struct hid_device_id alps_id[] = {
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
@@ -840,7 +835,6 @@ static struct hid_driver alps_driver = {
 	.name = "hid-alps",
 	.id_table		= alps_id,
 	.probe			= alps_probe,
-	.remove			= alps_remove,
 	.raw_event		= alps_raw_event,
 	.input_mapping		= alps_input_mapping,
 	.input_configured	= alps_input_configured,
Signature · 1 line
2.38.1
maintainer Applied
#1 lore raw
Quoted 25 lines · Marcus Folkesson

hid_device_remove() will call hid_hw_stop() as default .remove function if no function is specified.

---
 drivers/hid/hid-alps.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/hid/hid-alps.c +0 -5
index 2b986d0dbde4..9abaff6f3afb 100644
@@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	return 0;
 }
 
-static void alps_remove(struct hid_device *hdev)
-{
-	hid_hw_stop(hdev);
-}
-
 static const struct hid_device_id alps_id[] = {
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
 		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },

drivers/hid/hid-alps.c static struct hid_driver alps_driver = { · line 840

Quoted 7 lines
drivers/hid/hid-alps.c +0 -1
@@ -840,7 +835,6 @@ static struct hid_driver alps_driver = {
 	.name = "hid-alps",
 	.id_table		= alps_id,
 	.probe			= alps_probe,
-	.remove			= alps_remove,
 	.raw_event		= alps_raw_event,
 	.input_mapping		= alps_input_mapping,
 	.input_configured	= alps_input_configured,

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs