hynitron_cstxxx: Initialize tmp to 0 to fix uninitialized variable issue
Subsystems (2)
PATCH 1/1 hynitron_cstxxx: Initialize tmp to 0 to fix uninitialized variable issue
From: Chris Morgan <[email protected]>
In the very unlikely event the cst3xx_i2c_write() fails inside of the cst3xx_bootloader_enter() function 5 times in a row, the uninitalized value of tmp will get compared to CST3XX_BOOTLDR_CHK_VAL. Initialize the value of tmp to 0 so that in this unlikely event we are comparing 0 instead of an uninitalized variable.
--- drivers/input/touchscreen/hynitron_cstxxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/hynitron_cstxxx.c +1 -1
@@ -208,7 +208,7 @@ static int cst3xx_bootloader_enter(struct i2c_client *client) {int ret;u8 retry; -u32 tmp; +u32 tmp =0 ;unsigned char buf[3 ];for (retry =0 ; retry <5 ; retry++) {
Signature · 1 line
2.25.1
Quoted 8 lines · Chris Morgan
From: Chris Morgan <[email protected]>
In the very unlikely event the
cst3xx_i2c_write()fails inside of thecst3xx_bootloader_enter()function 5 times in a row, the uninitalized value of tmp will get compared toCST3XX_BOOTLDR_CHK_VAL. Initialize the value of tmp to 0 so that in this unlikely event we are comparing 0 instead of an uninitalized variable.
Quoted 4 lines
Fixes 66603243f528 ("Input: add driver for Hynitron cstxxx touchscreens")Signed-off-by Chris Morgan <[email protected]>Reported-by Dan Carpenter <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry