ipv4/fib: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Subsystems (3)
PATCH 1/1 ipv4/fib: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Zero-length arrays are deprecated[1] and are being replaced with flexible array members in support of the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy(), correctly instrument array indexing with UBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3.
Replace zero-length array with flexible-array member in struct key_vector.
This results in no differences in binary output.
[1] https://github.com/KSPP/linux/issues/78
--- net/ipv4/fib_trie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/fib_trie.c +1 -1
@@ -126,7 +126,7 @@ struct key_vector {/* This list pointer if valid if (pos | bits) == 0 (LEAF) */ struct hlist_head leaf;/* This array is valid if (pos | bits) > 0 (TNODE) */ -struct key_vector __rcu *tnode[0 ]; + DECLARE_FLEX_ARRAY(struct key_vector __rcu *, tnode); }; };
Signature · 1 line
2.34.1
Quoted 11 lines · Kees Cook
Zero-length arrays are deprecated[1] and are being replaced with flexible array members in support of the ongoing efforts to tighten the
FORTIFY_SOURCEroutines onmemcpy(), correctly instrument array indexing withUBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3.Replace zero-length array with flexible-array member in struct
key_vector.This results in no differences in binary output.
Quoted 9 lines
Cc Jakub Kicinski <[email protected]>Cc "David S. Miller" <[email protected]>Cc Hideaki YOSHIFUJI <[email protected]>Cc David Ahern <[email protected]>Cc Eric Dumazet <[email protected]>Cc Paolo Abeni <[email protected]>Cc "Gustavo A. R. Silva" <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks!
--
Gustavo
Quoted 20 lines
--- net/ipv4/fib_trie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/ipv4/fib_trie.c +1
-1@@ -126,7 +126,7 @@ struct key_vector {/* This list pointer if valid if (pos | bits) == 0 (LEAF) */ struct hlist_head leaf;/* This array is valid if (pos | bits) > 0 (TNODE) */ -struct key_vector __rcu *tnode[0 ]; + DECLARE_FLEX_ARRAY(struct key_vector __rcu *, tnode); }; };Signature · 1 line
2.34.1
Quoted 20 lines · Kees Cook
Zero-length arrays are deprecated[1] and are being replaced with flexible array members in support of the ongoing efforts to tighten the
FORTIFY_SOURCEroutines onmemcpy(), correctly instrument array indexing withUBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3.Replace zero-length array with flexible-array member in struct
key_vector.This results in no differences in binary output.
[1] https://github.com/KSPP/linux/issues/78
Cc Jakub Kicinski <[email protected]>Cc "David S. Miller" <[email protected]>Cc Hideaki YOSHIFUJI <[email protected]>Cc David Ahern <[email protected]>Cc Eric Dumazet <[email protected]>Cc Paolo Abeni <[email protected]>Cc "Gustavo A. R. Silva" <[email protected]>Signed-off-by Kees Cook <[email protected]>
Quoted 4 lines
--- net/ipv4/fib_trie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Thu, 17 Nov 2022 20:21:52 -0800 you wrote:
Zero-length arrays are deprecated[1] and are being replaced with flexible array members in support of the ongoing efforts to tighten the
FORTIFY_SOURCEroutines onmemcpy(), correctly instrument array indexing withUBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3.Replace zero-length array with flexible-array member in struct
key_vector.[...]
Here is the summary with links:
- ipv4/fib: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
https://git.kernel.org/netdev/net/c/764f8485890d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html