Skip to contentSkip to conversation

scripts/kallsyms.c Make the comment up-to-date with current implementation

PATCH In review Yuma Ueda 2 participants 2 messages Nov 18, 2022 – Nov 20, 2022

lore
Share & tools
lore

Yuma Ueda

author
#0 lore raw

PATCH v3 1/1 scripts/kallsyms.c Make the comment up-to-date with current implementation

The comment in scripts/kallsyms.c describing the usage of scripts/kallsyms does not reflect the latest implementation. Fix the comment to be equivalent to what the usage() function prints.

---
Changes from V2:
- tabs in the comment into spaces
- scripts/kallsyms in the comment into kallsyms

Changes from V1:
- Fix typo

 scripts/kallsyms.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kallsyms.c +2 -1
index 03fa07ad45d9..46d1afaaf4cd 100644
@@ -5,7 +5,8 @@
  * This software may be used and distributed according to the terms
  * of the GNU General Public License, incorporated herein by reference.
  *
- * Usage: nm -n vmlinux | scripts/kallsyms [--all-symbols] > symbols.S
+ * Usage: kallsyms [--all-symbols] [--absolute-percpu]
+ *                         [--base-relative] in.map > out.S
  *
  *      Table compression uses all the unused char codes on the symbols and
  *  maps these to the most used substrings (tokens). For instance, it might
Signature · 1 line
2.17.1
Reviewed-by on v3 1/1
#1 lore raw
Quoted 4 lines · Yuma Ueda

The comment in scripts/kallsyms.c describing the usage of scripts/kallsyms does not reflect the latest implementation. Fix the comment to be equivalent to what the usage() function prints.

Not sure why you used that many leading spaces, but the content looks fine to me!

Cheers,
Miguel