Skip to contentSkip to conversation

KVM: s390: remove unused gisa_clear_ipm_gisc() function

PATCH In review Heiko Carstens 3 participants 3 messages Nov 18, 2022 – Nov 21, 2022

Subsystems (3)
lore
Share & tools
lore

Heiko Carstens

author maintainer
#0 lore raw

PATCH 1/1 KVM: s390: remove unused gisa_clear_ipm_gisc() function

clang warns about an unused function:
arch/s390/kvm/interrupt.c:317:20:
error: unused function 'gisa_clear_ipm_gisc' [-Werror,-Wunused-function]
static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)

Remove gisa_clear_ipm_gisc(), since it is unused and get rid of this warning.

---
 arch/s390/kvm/interrupt.c | 5 -----
 1 file changed, 5 deletions(-)
arch/s390/kvm/interrupt.c +0 -5
index ab569faf0df2..1dae78deddf2 100644
@@ -314,11 +314,6 @@ static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa)
 	return READ_ONCE(gisa->ipm);
 }
 
-static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
-{
-	clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
-}
-
 static inline int gisa_tac_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
 {
 	return test_and_clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Heiko Carstens

clang warns about an unused function:
arch/s390/kvm/interrupt.c:317:20:
error: unused function 'gisa_clear_ipm_gisc' [-Werror,-Wunused-function]
static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)

Remove gisa_clear_ipm_gisc(), since it is unused and get rid of this warning.

---
  arch/s390/kvm/interrupt.c | 5 -----
  1 file changed, 5 deletions(-)
arch/s390/kvm/interrupt.c +0 -0
index ab569faf0df2..1dae78deddf2 100644

arch/s390/kvm/interrupt.c static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa) · line 320

Quoted 7 lines
arch/s390/kvm/interrupt.c +0 -4
@@ -314,11 +314,6 @@ static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa)
  	return READ_ONCE(gisa->ipm);
  }
 
-static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
-{
-	clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
-}

Unused since its introduction in commit d77e64141e322.

#2 lore raw
In reply to Heiko Carstens

Am 18.11.22 um 16:11 schrieb Heiko Carstens:

Quoted 9 lines

clang warns about an unused function:
arch/s390/kvm/interrupt.c:317:20:
error: unused function 'gisa_clear_ipm_gisc' [-Werror,-Wunused-function]
static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)

Remove gisa_clear_ipm_gisc(), since it is unused and get rid of this warning.

Thanks, queued.

Quoted 20 lines
---
  arch/s390/kvm/interrupt.c | 5 -----
  1 file changed, 5 deletions(-)
arch/s390/kvm/interrupt.c +0 -5
index ab569faf0df2..1dae78deddf2 100644
@@ -314,11 +314,6 @@ static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa)
  	return READ_ONCE(gisa->ipm);
  }
 
-static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
-{
-	clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
-}
-
  static inline int gisa_tac_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
  {
  	return test_and_clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);