Skip to contentSkip to conversation

ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

RFC In review Fabio Estevam 3 participants 4 messages Nov 19, 2022 – Jan 3, 2023

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

RFC 1/1 ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

From: Fabio Estevam <[email protected]>

The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.

Fix the problem by removing the 'uart-has-rtscts' property.

Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")

---
Hi,

My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.

If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.

 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0 -1
index 4bc4371e6bae..4b81a975c979 100644
@@ -632,7 +632,6 @@ &ssi1 {
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
-	uart-has-rtscts;
 	rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
 	status = "okay";
 };
Signature · 1 line
2.25.1
author reviewer
#1 lore raw
Quoted 19 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.

Fix the problem by removing the 'uart-has-rtscts' property.

Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")

---
Hi,

Quoted 6 lines

My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.

If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.

Looking at serial.yaml:

if:
required:
- uart-has-rtscts
then:
properties:
cts-gpios: false
rts-gpios: false

So I think my proposed change is correct.

#2 lore raw
In reply to Fabio Estevam
Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.

Fix the problem by removing the 'uart-has-rtscts' property.

Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")

---
Hi,

Quoted 6 lines

My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.

If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.

Tim,

Any comments?

Shawn

Quoted 19 lines
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0 -1
index 4bc4371e6bae..4b81a975c979 100644
@@ -632,7 +632,6 @@ &ssi1 {
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
-	uart-has-rtscts;
 	rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
 	status = "okay";
 };
Signature · 1 line
2.25.1
#3 lore raw
Quoted 24 lines · Shawn Guo
Quoted 22 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.

Fix the problem by removing the 'uart-has-rtscts' property.

Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")

---
Hi,

My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.

Quoted 8 lines
Quoted 2 lines

If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.

Tim,

Any comments?

Shawn

Shawn and Fabio,

Yes Fabio's change makes sense. Sorry, I missed this as I wasn't on the 'to' list.

Fabio has sent a patch so I'll ack it there.

Best Regards,

Tim