ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
Subsystems (2)
Fabio Estevam
reviewerRFC 1/1 ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
From: Fabio Estevam <[email protected]>
The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
The imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.
Fix the problem by removing the 'uart-has-rtscts' property.
---
Hi,
My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.
If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.
arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0 -1
@@ -632,7 +632,6 @@ &ssi1 { &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>; - uart-has-rtscts; rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; status = "okay"; };
Signature · 1 line
2.25.1
Fabio Estevam
reviewerQuoted 19 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The following build warning is seen when running:
makedtbs_checkDT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema:Documentation/devicetree/bindings/serial/fsl-imx-uart.yamlThe imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.
Fix the problem by removing the 'uart-has-rtscts' property.
Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")Signed-off-by Fabio Estevam <[email protected]>---
Hi,
Quoted 6 lines
My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.
If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.
Looking at serial.yaml:
if:
required:
- uart-has-rtscts
then:
properties:
cts-gpios: false
rts-gpios: false
So I think my proposed change is correct.
Quoted 18 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The following build warning is seen when running:
makedtbs_checkDT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema:Documentation/devicetree/bindings/serial/fsl-imx-uart.yamlThe imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.
Fix the problem by removing the 'uart-has-rtscts' property.
Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")Signed-off-by Fabio Estevam <[email protected]>---
Hi,
Quoted 6 lines
My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.
If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.
Tim,
Any comments?
Shawn
Quoted 19 lines
arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 - 1 file changed, 1 deletion(-)arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0
-1@@ -632,7 +632,6 @@ &ssi1 { &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>; - uart-has-rtscts; rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; status = "okay"; };Signature · 1 line
2.25.1
Quoted 24 lines · Shawn Guo
Quoted 22 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The following build warning is seen when running:
makedtbs_checkDT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema:Documentation/devicetree/bindings/serial/fsl-imx-uart.yamlThe imx6qdl-gw560x board does not expose the UART RTS and CTS as native pins, so 'uart-has-rtscts' should not be used.
Fix the problem by removing the 'uart-has-rtscts' property.
Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")Signed-off-by Fabio Estevam <[email protected]>---
Hi,My understanding is that uart-has-rtscts indicates that the UART RTS and CTS pins are used natively and we cannot use uart-has-rtscts with rts-gpios.
Quoted 8 lines
Quoted 2 lines
If this is correct, then I can also submit a patch fixing the arm64 Gateworks boards too.
Tim,
Any comments?
Shawn
Shawn and Fabio,
Yes Fabio's change makes sense. Sorry, I missed this as I wasn't on the 'to' list.
Fabio has sent a patch so I'll ack it there.
Best Regards,
Tim