ALSA: usb-audio: fix urb timeout with URB_ISO_ASAP flag
PATCH 1/1 ALSA: usb-audio: fix urb timeout with URB_ISO_ASAP flag
When the loglevel is greater than 4, with a long messages printed on the console while playing or recording audios, the usb controller may become abnormal.usb 1-2: timeout: still 1 active urbs on EP #1
Fix it by configuring the transfer_flags URB_ISO_ASAP flag.
--- sound/usb/endpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/usb/endpoint.c +2 -2
@@ -1245,7 +1245,7 @@ static int data_ep_set_params(struct snd_usb_endpoint *ep)if (!u->urb->transfer_buffer) goto out_of_memory; u->urb->pipe = ep->pipe; - u->urb->transfer_flags =URB_NO_TRANSFER_DMA_MAP ; + u->urb->transfer_flags =URB_ISO_ASAP |URB_NO_TRANSFER_DMA_MAP ; u->urb->interval =1 << ep->datainterval; u->urb->context = u; u->urb->complete = snd_complete_urb;
@@ -1288,7 +1288,7 @@ static int sync_ep_set_params(struct snd_usb_endpoint *ep) u->urb->transfer_dma = ep->sync_dma + i *4 ; u->urb->transfer_buffer_length =4 ; u->urb->pipe = ep->pipe; - u->urb->transfer_flags =URB_NO_TRANSFER_DMA_MAP ; + u->urb->transfer_flags =URB_ISO_ASAP |URB_NO_TRANSFER_DMA_MAP ; u->urb->number_of_packets =1 ; u->urb->interval =1 << ep->syncinterval; u->urb->context = u;
Signature · 1 line
2.29.0
Quoted 9 lines · Michael Wu
When the loglevel is greater than 4, with a long messages printed on the console while playing or recording audios, the usb controller may become abnormal.
usb 1-2: timeout: still 1 active urbs on EP #1Fix it by configuring the
transfer_flagsURB_ISO_ASAPflag.Signed-off-by Michael Wu <[email protected]>
Hrm, that's somewhat backward action to the change we've done years ago, commit c75c5ab575af7db707689cdbb5a5c458e9a034bb:
ALSA: USB: adjust for changed 3.8 USB API
The recent changes in the USB API ("implement new semantics for URB_ISO_ASAP") made the former meaning of the URB_ISO_ASAP flag the default, and changed this flag to mean that URBs can be delayed. This is not the behaviour wanted by any of the audio drivers because it leads to discontinuous playback with very small period sizes. Therefore, our URBs need to be submitted without this flag.
I rather suspect that your problem is in the USB controller side.
thanks,
Takashi
Quoted 29 lines
--- sound/usb/endpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)sound/usb/endpoint.c +2
-2@@ -1245,7 +1245,7 @@ static int data_ep_set_params(struct snd_usb_endpoint *ep)if (!u->urb->transfer_buffer) goto out_of_memory; u->urb->pipe = ep->pipe; - u->urb->transfer_flags =URB_NO_TRANSFER_DMA_MAP ; + u->urb->transfer_flags =URB_ISO_ASAP |URB_NO_TRANSFER_DMA_MAP ; u->urb->interval =1 << ep->datainterval; u->urb->context = u; u->urb->complete = snd_complete_urb;@@ -1288,7 +1288,7 @@ static int sync_ep_set_params(struct snd_usb_endpoint *ep) u->urb->transfer_dma = ep->sync_dma + i *4 ; u->urb->transfer_buffer_length =4 ; u->urb->pipe = ep->pipe; - u->urb->transfer_flags =URB_NO_TRANSFER_DMA_MAP ; + u->urb->transfer_flags =URB_ISO_ASAP |URB_NO_TRANSFER_DMA_MAP ; u->urb->number_of_packets =1 ; u->urb->interval =1 << ep->syncinterval; u->urb->context = u;Signature · 1 line
2.29.0
Quoted 24 lines · Takashi Iwai
Quoted 9 lines · Michael Wu
When the loglevel is greater than 4, with a long messages printed on the console while playing or recording audios, the usb controller may become abnormal.
usb 1-2: timeout: still 1 active urbs on EP #1Fix it by configuring the
transfer_flagsURB_ISO_ASAPflag.Signed-off-by Michael Wu <[email protected]>Hrm, that's somewhat backward action to the change we've done years ago, commit
c75c5ab575af7db707689cdbb5a5c458e9a034bb:ALSA: USB: adjust for changed 3.8 USB API
The recent changes in the USB API ("implement new semantics for
URB_ISO_ASAP") made the former meaning of theURB_ISO_ASAPflag the default, and changed this flag to mean that URBs can be delayed. This is not the behaviour wanted by any of the audio drivers because it leads to discontinuous playback with very small period sizes. Therefore, our URBs need to be submitted without this flag.
Quoted 7 lines
I rather suspect that your problem is in the USB controller side.
thanks,
Takashi
Dear Takashi, thanks for the reminding. Let me check...
Signature · 2 lines
Regards, Michael Wu