Skip to contentSkip to conversation

Nokia RX-51: Use ENTRY/ENDPROC for save_boot_params

PATCH In review Pali Rohár 2 participants 2 messages Nov 23, 2022 – Dec 9, 2022 Arm/actions semi architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Nokia RX-51: Use ENTRY/ENDPROC for save_boot_params

ENTRY/ENDPROC macros from linux/linkage.h will make code more readable and also will properly mark assembly symbol in ELF binary as function symbol.

---
 board/nokia/rx51/lowlevel_init.S | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
board/nokia/rx51/lowlevel_init.S +4 -2
index 930052ea60f2..44f32f114e75 100644
@@ -5,6 +5,7 @@
  */
 
 #include <config.h>
+#include <linux/linkage.h>
 
 kernoffs:		/* offset of kernel image from this address */
 	.word . - CONFIG_TEXT_BASE - KERNEL_OFFSET
@@ -29,8 +30,7 @@ z_magic:		/* LINUX_ARM_ZIMAGE_MAGIC */
  * Description: Copy attached kernel to address KERNEL_ADDRESS
  */
 
-.global save_boot_params
-save_boot_params:
+ENTRY(save_boot_params)
 
 /*
  * Copy valid attached kernel to absolute address KERNEL_ADDRESS
@@ -93,3 +93,5 @@ skip_copy:
 
 	/* Returns */
 	b	save_boot_params_ret
+
+ENDPROC(save_boot_params)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Pali Rohár

ENTRY/ENDPROC macros from linux/linkage.h will make code more readable and also will properly mark assembly symbol in ELF binary as function symbol.

Applied to u-boot/next, thanks!

Signature · 1 line
Tom