Skip to contentSkip to conversation

PCI: xilinx: Drop obsolete dependency on COMPILE_TEST

PATCH Superseded Jean Delvare 1 participant 1 message Nov 24, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: xilinx: Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.

Cc Lorenzo Pieralisi <[email protected]>
Cc Rob Herring <[email protected]>
Cc "Krzysztof Wilczyński" <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc Michal Simek <[email protected]>
Cc Bharat Kumar Gogada <[email protected]>
---
 drivers/pci/controller/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/Kconfig +1 -1
@@ -98,7 +98,7 @@ config PCI_HOST_GENERIC
 
 config PCIE_XILINX
 	bool "Xilinx AXI PCIe host bridge support"
-	depends on OF || COMPILE_TEST
+	depends on OF
 	depends on PCI_MSI_IRQ_DOMAIN
 	help
 	  Say 'Y' here if you want kernel to support the Xilinx AXI PCIe
Signature · 2 lines
Jean Delvare
SUSE L3 Support