Skip to contentSkip to conversation

fscrypt: add comment for fscrypt_valid_enc_modes_v1()

PATCH New Eric Biggers 1 participant 1 message Nov 25, 2022 fscrypt: file system level encryption support

lore
Share & tools
lore

Eric Biggers

author maintainer
#0 lore raw

PATCH 1/1 fscrypt: add comment for fscrypt_valid_enc_modes_v1()

From: Eric Biggers <[email protected]>

Make it clear that nothing new should be added to this function.

---
 fs/crypto/policy.c | 7 +++++++
 1 file changed, 7 insertions(+)
fs/crypto/policy.c +7 -0
index 46757c3052ef9..84fa51604b151 100644
@@ -61,6 +61,13 @@ fscrypt_get_dummy_policy(struct super_block *sb)
 	return sb->s_cop->get_dummy_policy(sb);
 }
 
+/*
+ * Return %true if the given combination of encryption modes is supported for v1
+ * (and later) encryption policies.
+ *
+ * Do *not* add anything new here, since v1 encryption policies are deprecated.
+ * New combinations of modes should go in fscrypt_valid_enc_modes_v2() only.
+ */
 static bool fscrypt_valid_enc_modes_v1(u32 contents_mode, u32 filenames_mode)
 {
 	if (contents_mode == FSCRYPT_MODE_AES_256_XTS &&

base-commit: 02aef4225258fa6d022ce9040716aeecc3afc521

Signature · 1 line
2.38.1