Skip to contentSkip to conversation

hwmon: (pmbus/core): Update regulator flag map

PATCH In review Naresh Solanki 2 participants 11 messages Nov 28, 2022 – Nov 30, 2022 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 hwmon: (pmbus/core): Update regulator flag map

Add regulator flag map for PMBUS status byte & status input.

---
 drivers/hwmon/pmbus/pmbus_core.c | 30 ++++++++++++++++++++++--------
 1 file changed, 22 insertions(+), 8 deletions(-)
drivers/hwmon/pmbus/pmbus_core.c +22 -8
index 95e95783972a..f5caceaaef2a 100644
@@ -2752,6 +2752,15 @@ struct pmbus_regulator_status_category {
 
 static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = {
 	{
+		.func = -1,
+		.reg = PMBUS_STATUS_BYTE,
+		.bits = (const struct pmbus_regulator_status_assoc[]) {
+			{ PB_STATUS_IOUT_OC,   REGULATOR_ERROR_OVER_CURRENT },
+			{ PB_STATUS_VOUT_OV,   REGULATOR_ERROR_REGULATION_OUT },
+			{ PB_STATUS_VIN_UV,    REGULATOR_ERROR_UNDER_VOLTAGE },
+			{ },
+		},
+	}, {
 		.func = PMBUS_HAVE_STATUS_VOUT,
 		.reg = PMBUS_STATUS_VOUT,
 		.bits = (const struct pmbus_regulator_status_assoc[]) {
@@ -2768,6 +2777,7 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] =
 			{ PB_IOUT_OC_WARNING,    REGULATOR_ERROR_OVER_CURRENT_WARN },
 			{ PB_IOUT_OC_FAULT,      REGULATOR_ERROR_OVER_CURRENT },
 			{ PB_IOUT_OC_LV_FAULT,   REGULATOR_ERROR_OVER_CURRENT },
+			{ PB_POUT_OP_FAULT,      REGULATOR_ERROR_OVER_CURRENT },
 			{ },
 		},
 	}, {
@@ -2778,6 +2788,18 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] =
 			{ PB_TEMP_OT_FAULT,      REGULATOR_ERROR_OVER_TEMP },
 			{ },
 		},
+	}, {
+		.func = PMBUS_HAVE_STATUS_INPUT,
+		.reg = PMBUS_STATUS_INPUT,
+		.bits = (const struct pmbus_regulator_status_assoc[]) {
+			{ PB_IIN_OC_FAULT,       REGULATOR_ERROR_OVER_CURRENT },
+			{ PB_IIN_OC_WARNING,     REGULATOR_ERROR_OVER_CURRENT_WARN },
+			{ PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE },
+			{ PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_OV_FAULT,   REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+			{ },
+		},
 	},
 };
 
@@ -2834,14 +2856,6 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned
 		if (status & PB_STATUS_POWER_GOOD_N)
 			*flags |= REGULATOR_ERROR_REGULATION_OUT;
 	}
-	/*
-	 * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are
-	 * defined strictly as fault indicators (not warnings).
-	 */
-	if (status & PB_STATUS_IOUT_OC)
-		*flags |= REGULATOR_ERROR_OVER_CURRENT;
-	if (status & PB_STATUS_VOUT_OV)
-		*flags |= REGULATOR_ERROR_REGULATION_OUT;
 
 	/*
 	 * If we haven't discovered any thermal faults or warnings via

base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c

Signature · 1 line
2.37.3
#1 lore raw

PATCH v2 2/3 hwmon: (pmbus/core): Add events to regulator flag map

From: Patrick Rudolph <[email protected]>

Add regulator events corresponding to regulator error in regulator flag map.

---
 drivers/hwmon/pmbus/pmbus_core.c | 62 +++++++++++++++++++++-----------
 1 file changed, 41 insertions(+), 21 deletions(-)
drivers/hwmon/pmbus/pmbus_core.c +41 -21
index f5caceaaef2a..060e9d0a55bd 100644
@@ -2738,9 +2738,9 @@ static int pmbus_regulator_disable(struct regulator_dev *rdev)
 	return _pmbus_regulator_on_off(rdev, 0);
 }
 
-/* A PMBus status flag and the corresponding REGULATOR_ERROR_* flag */
+/* A PMBus status flag and the corresponding REGULATOR_ERROR_* and REGULATOR_EVENTS_* flag */
 struct pmbus_regulator_status_assoc {
-	int pflag, rflag;
+	int pflag, rflag, eflag;
 };
 
 /* PMBus->regulator bit mappings for a PMBus status register */
@@ -2755,51 +2755,71 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] =
 		.func = -1,
 		.reg = PMBUS_STATUS_BYTE,
 		.bits = (const struct pmbus_regulator_status_assoc[]) {
-			{ PB_STATUS_IOUT_OC,   REGULATOR_ERROR_OVER_CURRENT },
-			{ PB_STATUS_VOUT_OV,   REGULATOR_ERROR_REGULATION_OUT },
-			{ PB_STATUS_VIN_UV,    REGULATOR_ERROR_UNDER_VOLTAGE },
+			{ PB_STATUS_IOUT_OC,   REGULATOR_ERROR_OVER_CURRENT,
+			REGULATOR_EVENT_OVER_CURRENT },
+			{ PB_STATUS_VOUT_OV,   REGULATOR_ERROR_REGULATION_OUT,
+			REGULATOR_EVENT_OVER_VOLTAGE_WARN },
+			{ PB_STATUS_VIN_UV,    REGULATOR_ERROR_UNDER_VOLTAGE,
+			REGULATOR_EVENT_UNDER_VOLTAGE },
 			{ },
 		},
 	}, {
 		.func = PMBUS_HAVE_STATUS_VOUT,
 		.reg = PMBUS_STATUS_VOUT,
 		.bits = (const struct pmbus_regulator_status_assoc[]) {
-			{ PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN },
-			{ PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE },
-			{ PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN },
-			{ PB_VOLTAGE_OV_FAULT,   REGULATOR_ERROR_REGULATION_OUT },
+			{ PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN,
+			REGULATOR_EVENT_UNDER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE,
+			REGULATOR_EVENT_UNDER_VOLTAGE },
+			{ PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN,
+			REGULATOR_EVENT_OVER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_OV_FAULT,   REGULATOR_ERROR_REGULATION_OUT,
+			REGULATOR_EVENT_OVER_VOLTAGE_WARN },
 			{ },
 		},
 	}, {
 		.func = PMBUS_HAVE_STATUS_IOUT,
 		.reg = PMBUS_STATUS_IOUT,
 		.bits = (const struct pmbus_regulator_status_assoc[]) {
-			{ PB_IOUT_OC_WARNING,    REGULATOR_ERROR_OVER_CURRENT_WARN },
-			{ PB_IOUT_OC_FAULT,      REGULATOR_ERROR_OVER_CURRENT },
-			{ PB_IOUT_OC_LV_FAULT,   REGULATOR_ERROR_OVER_CURRENT },
-			{ PB_POUT_OP_FAULT,      REGULATOR_ERROR_OVER_CURRENT },
+			{ PB_IOUT_OC_WARNING,   REGULATOR_ERROR_OVER_CURRENT_WARN,
+			REGULATOR_EVENT_OVER_CURRENT_WARN },
+			{ PB_IOUT_OC_FAULT,     REGULATOR_ERROR_OVER_CURRENT,
+			REGULATOR_EVENT_OVER_CURRENT },
+			{ PB_IOUT_OC_LV_FAULT,  REGULATOR_ERROR_OVER_CURRENT,
+			REGULATOR_EVENT_OVER_CURRENT },
+			{ PB_POUT_OP_FAULT,     REGULATOR_ERROR_OVER_CURRENT,
+			REGULATOR_EVENT_OVER_CURRENT },
 			{ },
 		},
 	}, {
 		.func = PMBUS_HAVE_STATUS_TEMP,
 		.reg = PMBUS_STATUS_TEMPERATURE,
 		.bits = (const struct pmbus_regulator_status_assoc[]) {
-			{ PB_TEMP_OT_WARNING,    REGULATOR_ERROR_OVER_TEMP_WARN },
-			{ PB_TEMP_OT_FAULT,      REGULATOR_ERROR_OVER_TEMP },
+			{ PB_TEMP_OT_WARNING,    REGULATOR_ERROR_OVER_TEMP_WARN,
+			REGULATOR_EVENT_OVER_TEMP_WARN },
+			{ PB_TEMP_OT_FAULT,      REGULATOR_ERROR_OVER_TEMP,
+			REGULATOR_EVENT_OVER_TEMP },
 			{ },
 		},
 	}, {
 		.func = PMBUS_HAVE_STATUS_INPUT,
 		.reg = PMBUS_STATUS_INPUT,
 		.bits = (const struct pmbus_regulator_status_assoc[]) {
-			{ PB_IIN_OC_FAULT,       REGULATOR_ERROR_OVER_CURRENT },
-			{ PB_IIN_OC_WARNING,     REGULATOR_ERROR_OVER_CURRENT_WARN },
-			{ PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE },
-			{ PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN },
-			{ PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN },
-			{ PB_VOLTAGE_OV_FAULT,   REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+			{ PB_IIN_OC_FAULT,       REGULATOR_ERROR_OVER_CURRENT,
+			REGULATOR_EVENT_OVER_CURRENT },
+			{ PB_IIN_OC_WARNING,     REGULATOR_ERROR_OVER_CURRENT_WARN,
+			REGULATOR_EVENT_OVER_CURRENT_WARN },
+			{ PB_VOLTAGE_UV_FAULT,       REGULATOR_ERROR_UNDER_VOLTAGE,
+			REGULATOR_EVENT_UNDER_VOLTAGE },
+			{ PB_VOLTAGE_UV_WARNING,     REGULATOR_ERROR_UNDER_VOLTAGE_WARN,
+			REGULATOR_EVENT_UNDER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_OV_WARNING,     REGULATOR_ERROR_OVER_VOLTAGE_WARN,
+			REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_OV_FAULT,       REGULATOR_ERROR_OVER_VOLTAGE_WARN,
+			REGULATOR_ERROR_OVER_VOLTAGE_WARN },
 			{ },
 		},
+
 	},
 };
 
Signature · 1 line
2.37.3
#2 lore raw

PATCH v2 3/3 hwmon: (pmbus/core): Implement irq support

In reply to Naresh Solanki

From: Patrick Rudolph <[email protected]>

Implement PMBUS irq handler to notify regulator events.

---
 drivers/hwmon/pmbus/pmbus.h      |   2 +-
 drivers/hwmon/pmbus/pmbus_core.c | 151 ++++++++++++++++++++++++++++---
 2 files changed, 137 insertions(+), 16 deletions(-)
drivers/hwmon/pmbus/pmbus.h +1 -1
index 10fb17879f8e..6b2e6cf93b19 100644
@@ -26,7 +26,7 @@ enum pmbus_regs {
 
 	PMBUS_CAPABILITY		= 0x19,
 	PMBUS_QUERY			= 0x1A,
-
+	PMBUS_SMBALERT_MASK		= 0x1B,
 	PMBUS_VOUT_MODE			= 0x20,
 	PMBUS_VOUT_COMMAND		= 0x21,
 	PMBUS_VOUT_TRIM			= 0x22,
drivers/hwmon/pmbus/pmbus_core.c +136 -15

229 lines not on this page · raw message

Signature · 1 line
2.37.3
maintainer
#3 lore raw

Re: [PATCH v2 3/3] hwmon: (pmbus/core): Implement irq support

Quoted 6 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Implement PMBUS irq handler to notify regulator events.

As I am sure I have mentioned before, this needs to primarily handle sysfs notifications to hwmon status attributes and to generate kobject events. Regulator events are secondary / optional.

Thanks,
Guenter

#4 lore raw

Re: [PATCH v2 3/3] hwmon: (pmbus/core): Implement irq support

Hi Guenter,

Quoted 11 lines · Guenter Roeck
Quoted 6 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Implement PMBUS irq handler to notify regulator events.

As I am sure I have mentioned before, this needs to primarily handle sysfs notifications to hwmon status attributes and to generate kobject events. Regulator events are secondary / optional.

Based on previous feedback, PMBus interrupt handler is made generic
Based on the use case I have in my machine, my application need to monitor regulator event as soon as they occur and hence the patch.

Quoted 4 lines

Thanks,
Guenter

Regards,
Naresh

maintainer
#5 lore raw

Re: [PATCH v2 3/3] hwmon: (pmbus/core): Implement irq support

Quoted 11 lines · Naresh Solanki

Hi Guenter,

Quoted 8 lines · Guenter Roeck
Quoted 6 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Implement PMBUS irq handler to notify regulator events.

Quoted 7 lines
Quoted 3 lines

As I am sure I have mentioned before, this needs to primarily handle sysfs notifications to hwmon status attributes and to generate kobject events. Regulator events are secondary / optional.

Based on previous feedback, PMBus interrupt handler is made generic
Based on the use case I have in my machine, my application need to monitor regulator event as soon as they occur and hence the patch.

I understand, but this isn't just about your specific use case. Your use case is what triggers the change, and ensures that the code change is tested, but the impact by far reaches beyond your specific use case and needs to address other (much more common) use cases as well. Interrupt support is needed in the pmbus code, but it needs to address the common use case first, and that is reporting the status via sysfs notifications and kobject events.

Thanks,
Guenter

#6 lore raw

Re: [PATCH v2 3/3] hwmon: (pmbus/core): Implement irq support

Hi Guenter,

Quoted 20 lines · Guenter Roeck
Quoted 11 lines · Naresh Solanki

Hi Guenter,

Quoted 8 lines · Guenter Roeck
Quoted 6 lines · Naresh Solanki

From: Patrick Rudolph <[email protected]>

Implement PMBUS irq handler to notify regulator events.

Quoted 7 lines
Quoted 3 lines

As I am sure I have mentioned before, this needs to primarily handle sysfs notifications to hwmon status attributes and to generate kobject events. Regulator events are secondary / optional.

Based on previous feedback, PMBus interrupt handler is made generic
Based on the use case I have in my machine, my application need to monitor regulator event as soon as they occur and hence the patch.

Quoted 6 lines

I understand, but this isn't just about your specific use case. Your use case is what triggers the change, and ensures that the code change is tested, but the impact by far reaches beyond your specific use case and needs to address other (much more common) use cases as well. Interrupt support is needed in the pmbus code, but it needs to address the common use case first, and that is reporting the status via sysfs notifications and kobject events.

Agree. I've done the implementation. Will submit the change as separate patch along with the series.

Quoted 4 lines

Thanks,
Guenter

Regards,
Naresh

maintainer
#7 lore raw
In reply to Naresh Solanki
Quoted 3 lines · Naresh Solanki

Add regulator flag map for PMBUS status byte & status input.

You are adding a lot of input errors here. The regulator documentation only covers output errors. I am not sure if this set of changes is really appropriate. You'll have to make a much better case for those changes; from what I can see they are all controversial and were originally left out on purpose.

drivers/hwmon/pmbus/pmbus_core.c struct pmbus_regulator_status_category { · line 2755

Quoted 13 lines
---
  drivers/hwmon/pmbus/pmbus_core.c | 30 ++++++++++++++++++++++--------
  1 file changed, 22 insertions(+), 8 deletions(-)
drivers/hwmon/pmbus/pmbus_core.c +1 -0
index 95e95783972a..f5caceaaef2a 100644
@@ -2752,6 +2752,15 @@ struct pmbus_regulator_status_category {
 
  static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = {
  	{
+		.func = -1,

This would need a comment. I don't really see the benefit over the original code.

Quoted 12 lines
drivers/hwmon/pmbus/pmbus_core.c +8 -0
+		.reg = PMBUS_STATUS_BYTE,
+		.bits = (const struct pmbus_regulator_status_assoc[]) {
+			{ PB_STATUS_IOUT_OC,   REGULATOR_ERROR_OVER_CURRENT },
+			{ PB_STATUS_VOUT_OV,   REGULATOR_ERROR_REGULATION_OUT },
+			{ PB_STATUS_VIN_UV,    REGULATOR_ERROR_UNDER_VOLTAGE },
+			{ },
+		},
+	}, {
  		.func = PMBUS_HAVE_STATUS_VOUT,
  		.reg = PMBUS_STATUS_VOUT,
  		.bits = (const struct pmbus_regulator_status_assoc[]) {

drivers/hwmon/pmbus/pmbus_core.c static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = · line 2780

Quoted 4 lines
drivers/hwmon/pmbus/pmbus_core.c +1 -0
@@ -2768,6 +2777,7 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] =
  			{ PB_IOUT_OC_WARNING,    REGULATOR_ERROR_OVER_CURRENT_WARN },
  			{ PB_IOUT_OC_FAULT,      REGULATOR_ERROR_OVER_CURRENT },
  			{ PB_IOUT_OC_LV_FAULT,   REGULATOR_ERROR_OVER_CURRENT },
+			{ PB_POUT_OP_FAULT,      REGULATOR_ERROR_OVER_CURRENT },

OP_FAULT (power fault) and over current are really not the same thing.

Quoted 7 lines
drivers/hwmon/pmbus/pmbus_core.c +0 -0
  			{ },
  		},
  	}, {
@@ -2778,6 +2788,18 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] =
  			{ PB_TEMP_OT_FAULT,      REGULATOR_ERROR_OVER_TEMP },
  			{ },
  		},

drivers/hwmon/pmbus/pmbus_core.c static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = · line 2800

Quoted 10 lines
drivers/hwmon/pmbus/pmbus_core.c +10 -0
+	}, {
+		.func = PMBUS_HAVE_STATUS_INPUT,
+		.reg = PMBUS_STATUS_INPUT,
+		.bits = (const struct pmbus_regulator_status_assoc[]) {
+			{ PB_IIN_OC_FAULT,       REGULATOR_ERROR_OVER_CURRENT },
+			{ PB_IIN_OC_WARNING,     REGULATOR_ERROR_OVER_CURRENT_WARN },
+			{ PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE },
+			{ PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+			{ PB_VOLTAGE_OV_FAULT,   REGULATOR_ERROR_OVER_VOLTAGE_WARN },

fault -> warning ? Shouldn't this be REGULATOR_ERROR_FAIL (Regulator output has failed) ?

Quoted 22 lines
drivers/hwmon/pmbus/pmbus_core.c +2 -8
+			{ },
+		},
  	},
  };
 
@@ -2834,14 +2856,6 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned
  		if (status & PB_STATUS_POWER_GOOD_N)
  			*flags |= REGULATOR_ERROR_REGULATION_OUT;
  	}
-	/*
-	 * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are
-	 * defined strictly as fault indicators (not warnings).
-	 */
-	if (status & PB_STATUS_IOUT_OC)
-		*flags |= REGULATOR_ERROR_OVER_CURRENT;
-	if (status & PB_STATUS_VOUT_OV)
-		*flags |= REGULATOR_ERROR_REGULATION_OUT;
 
  	/*
  	 * If we haven't discovered any thermal faults or warnings via

base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c

#8 lore raw

Hi Guenter,

Quoted 10 lines · Guenter Roeck
Quoted 3 lines · Naresh Solanki

Add regulator flag map for PMBUS status byte & status input.

You are adding a lot of input errors here. The regulator documentation only covers output errors. I am not sure if this set of changes is really appropriate. You'll have to make a much better case for those changes; from what I can see they are all controversial and were originally left out on purpose.

I felt it may be worth to monitor status input, but you feel otherwise then shall I remove this in next revision ?

Quoted 5 lines
Quoted 5 lines

---
  drivers/hwmon/pmbus/pmbus_core.c | 30 ++++++++++++++++++++++--------

  1 file changed, 22 insertions(+), 8 deletions(-)
Quoted 11 lines

drivers/hwmon/pmbus/pmbus_core.c struct pmbus_regulator_status_category { · line 2754

Quoted 8 lines
drivers/hwmon/pmbus/pmbus_core.c +1 -0
index 95e95783972a..f5caceaaef2a 100644
@@ -2752,6 +2752,15 @@ struct pmbus_regulator_status_category {
   static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = {
       {
+        .func = -1,

This would need a comment. I don't really see the benefit over the original code.

I pulled that in so as to handle it in same way as other status register.

Quoted 12 lines
Quoted 12 lines
drivers/hwmon/pmbus/pmbus_core.c +8 -0
+        .reg = PMBUS_STATUS_BYTE,
+        .bits = (const struct pmbus_regulator_status_assoc[]) {
+            { PB_STATUS_IOUT_OC,   REGULATOR_ERROR_OVER_CURRENT },
+            { PB_STATUS_VOUT_OV,   REGULATOR_ERROR_REGULATION_OUT },
+            { PB_STATUS_VIN_UV,    REGULATOR_ERROR_UNDER_VOLTAGE },
+            { },
+        },
+    }, {
           .func = PMBUS_HAVE_STATUS_VOUT,
           .reg = PMBUS_STATUS_VOUT,
           .bits = (const struct pmbus_regulator_status_assoc[]) {
Quoted 9 lines
Quoted 6 lines
drivers/hwmon/pmbus/pmbus_core.c +0 -0
@@ -2768,6 +2777,7 @@ static const struct 

pmbus_regulator_status_category pmbus_regulator_flag_map[] =
              { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN },
              { PB_IOUT_OC_FAULT,      REGULATOR_ERROR_OVER_CURRENT }, { PB_IOUT_OC_LV_FAULT,   REGULATOR_ERROR_OVER_CURRENT }, +            { PB_POUT_OP_FAULT,      REGULATOR_ERROR_OVER_CURRENT },

OP_FAULT (power fault) and over current are really not the same thing.

I agree. But thats best I could think of. Not sure if there is better REGULATOR_ERROR_* code for this scenario. Suggestions?

Quoted 17 lines
Quoted 17 lines

              { },
          },
      }, {

drivers/hwmon/pmbus/pmbus_core.c +0 -0
@@ -2778,6 +2788,18 @@ static const struct 

pmbus_regulator_status_category pmbus_regulator_flag_map[] = { PB_TEMP_OT_FAULT,      REGULATOR_ERROR_OVER_TEMP }, { },
          },
+    }, {
+        .func = PMBUS_HAVE_STATUS_INPUT,
+        .reg = PMBUS_STATUS_INPUT,
+        .bits = (const struct pmbus_regulator_status_assoc[]) { +            { PB_IIN_OC_FAULT,       REGULATOR_ERROR_OVER_CURRENT }, +            { PB_IIN_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN },
+            { PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE }, +            { PB_VOLTAGE_UV_WARNING,

Quoted 9 lines
Quoted 5 lines

REGULATOR_ERROR_UNDER_VOLTAGE_WARN },
+            { PB_VOLTAGE_OV_WARNING,
REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+            { PB_VOLTAGE_OV_FAULT,
REGULATOR_ERROR_OVER_VOLTAGE_WARN },

fault -> warning ? Shouldn't this be REGULATOR_ERROR_FAIL (Regulator output has failed) ?

Yes. REGULATOR_ERROR_FAIL is best fit here. Will update in next revision.

Quoted 22 lines
Quoted 21 lines

+            { },
+        },
      },
  };

drivers/hwmon/pmbus/pmbus_core.c +0 -0
@@ -2834,14 +2856,6 @@ static int 

pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned if (status & PB_STATUS_POWER_GOOD_N)
              *flags |= REGULATOR_ERROR_REGULATION_OUT;
      }
-    /*
-     * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are -     * defined strictly as fault indicators (not warnings). -     */
-    if (status & PB_STATUS_IOUT_OC)
-        *flags |= REGULATOR_ERROR_OVER_CURRENT;
-    if (status & PB_STATUS_VOUT_OV)
-        *flags |= REGULATOR_ERROR_REGULATION_OUT;
      /*
       * If we haven't discovered any thermal faults or warnings via

base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c

maintainer
#9 lore raw
Quoted 6 lines · Naresh Solanki

Hi Guenter,

Quoted 3 lines · Guenter Roeck
Quoted 2 lines · Naresh Solanki

Add regulator flag map for PMBUS status byte & status input.

Quoted 8 lines
Quoted 7 lines
Quoted 1 line

You are adding a lot of input errors here. The regulator documentation only covers output errors. I am not sure if this set of changes is really appropriate. You'll have to make a much better case for those changes; from what I can see they are all controversial and were originally left out on purpose.

I felt it may be worth to monitor status input, but you feel otherwise then shall I remove this in next revision ?

It is a set of changes which needs input from regulator subsystem maintainers. Maybe it even needs changes on the regulator side, for example to report input and/or power failures properly.

It isn't something I would have expected as part of a patch or patch series series which is supposed to add interrupt support to pmbus drivers. Since it is the first patch in your series, in may hold up the series for some period of time until the questions around it are resolved. Your call, really, how to handle it. Just don't be surprised if it takes a while to resolve the issues.

Quoted 16 lines
Quoted 5 lines
Quoted 5 lines

---
  drivers/hwmon/pmbus/pmbus_core.c | 30 ++++++++++++++++++++++--------

  1 file changed, 22 insertions(+), 8 deletions(-)
Quoted 11 lines

drivers/hwmon/pmbus/pmbus_core.c struct pmbus_regulator_status_category { · line 2754

Quoted 8 lines
drivers/hwmon/pmbus/pmbus_core.c +1 -0
index 95e95783972a..f5caceaaef2a 100644
@@ -2752,6 +2752,15 @@ struct pmbus_regulator_status_category {
   static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = {
       {
+        .func = -1,

This would need a comment. I don't really see the benefit over the original code.

Quoted 1 line

I pulled that in so as to handle it in same way as other status register.

That would have to be a separate patch. It took me a while to understand how .func = -1 is handled, so without comment it just adds confusion.

Quoted 20 lines
Quoted 11 lines
Quoted 11 lines
drivers/hwmon/pmbus/pmbus_core.c +8 -0
+        .reg = PMBUS_STATUS_BYTE,
+        .bits = (const struct pmbus_regulator_status_assoc[]) {
+            { PB_STATUS_IOUT_OC,   REGULATOR_ERROR_OVER_CURRENT },
+            { PB_STATUS_VOUT_OV,   REGULATOR_ERROR_REGULATION_OUT },
+            { PB_STATUS_VIN_UV,    REGULATOR_ERROR_UNDER_VOLTAGE },
+            { },
+        },
+    }, {
           .func = PMBUS_HAVE_STATUS_VOUT,
           .reg = PMBUS_STATUS_VOUT,
Quoted 9 lines

drivers/hwmon/pmbus/pmbus_core.c static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = · line 2780

Quoted 6 lines
drivers/hwmon/pmbus/pmbus_core.c +1 -0
           .bits = (const struct pmbus_regulator_status_assoc[]) {
@@ -2768,6 +2777,7 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] =
               { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN },
               { PB_IOUT_OC_FAULT,      REGULATOR_ERROR_OVER_CURRENT },
               { PB_IOUT_OC_LV_FAULT,   REGULATOR_ERROR_OVER_CURRENT },
+            { PB_POUT_OP_FAULT,      REGULATOR_ERROR_OVER_CURRENT },

OP_FAULT (power fault) and over current are really not the same thing.

Quoted 1 line

I agree. But thats best I could think of. Not sure if there is better REGULATOR_ERROR_* code for this scenario. Suggestions?

Options are REGULATOR_ERROR_OVER_CURRENT or REGULATOR_ERROR_FAIL or a new failure code or doing nothing. Personally I think REGULATOR_ERROR_FAIL would be better if adding a new failure code is not an option.

Anyway, clarify on the regulator subsystem mailing list how to handle input errors, and how to handle power failures. If they say it is acceptable to report input errors as output errors, and to report power failures as current failures, resubmit. Say in comments that this is what you are doing, and in the commit description that this is how input errors and power failures are handled in the regulator subsystem. Copy regulator subsystem maintainers on your patch.

Thanks,
Guenter

Quoted 43 lines
Quoted 12 lines
Quoted 12 lines
drivers/hwmon/pmbus/pmbus_core.c +5 -0
               { },
           },
       }, {
@@ -2778,6 +2788,18 @@ static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] =
               { PB_TEMP_OT_FAULT,      REGULATOR_ERROR_OVER_TEMP },
               { },
           },
+    }, {
+        .func = PMBUS_HAVE_STATUS_INPUT,
+        .reg = PMBUS_STATUS_INPUT,
+        .bits = (const struct pmbus_regulator_status_assoc[]) {
+            { PB_IIN_OC_FAULT,       REGULATOR_ERROR_OVER_CURRENT },
Quoted 9 lines

drivers/hwmon/pmbus/pmbus_core.c static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = · line 2800

Quoted 5 lines
drivers/hwmon/pmbus/pmbus_core.c +5 -0
+            { PB_IIN_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN },
+            { PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE },
+            { PB_VOLTAGE_UV_WARNING, REGULATOR_ERROR_UNDER_VOLTAGE_WARN },
+            { PB_VOLTAGE_OV_WARNING, REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+            { PB_VOLTAGE_OV_FAULT, REGULATOR_ERROR_OVER_VOLTAGE_WARN },

fault -> warning ? Shouldn't this be REGULATOR_ERROR_FAIL (Regulator output has failed) ?

Yes. REGULATOR_ERROR_FAIL is best fit here. Will update in next revision.

Quoted 21 lines
Quoted 20 lines
drivers/hwmon/pmbus/pmbus_core.c +2 -8
+            { },
+        },
       },
   };
@@ -2834,14 +2856,6 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned
           if (status & PB_STATUS_POWER_GOOD_N)
               *flags |= REGULATOR_ERROR_REGULATION_OUT;
       }
-    /*
-     * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are
-     * defined strictly as fault indicators (not warnings).
-     */
-    if (status & PB_STATUS_IOUT_OC)
-        *flags |= REGULATOR_ERROR_OVER_CURRENT;
-    if (status & PB_STATUS_VOUT_OV)
-        *flags |= REGULATOR_ERROR_REGULATION_OUT;
       /*
        * If we haven't discovered any thermal faults or warnings via
 

base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c

#10 lore raw

Hi Guenter,

Quoted 20 lines · Guenter Roeck
Quoted 6 lines · Naresh Solanki

Hi Guenter,

Quoted 3 lines · Guenter Roeck
Quoted 2 lines · Naresh Solanki

Add regulator flag map for PMBUS status byte & status input.

Quoted 8 lines
Quoted 7 lines
Quoted 1 line

You are adding a lot of input errors here. The regulator documentation only covers output errors. I am not sure if this set of changes is really appropriate. You'll have to make a much better case for those changes; from what I can see they are all controversial and were originally left out on purpose.

I felt it may be worth to monitor status input, but you feel otherwise then shall I remove this in next revision ?

It is a set of changes which needs input from regulator subsystem maintainers. Maybe it even needs changes on the regulator side, for example to report input and/or power failures properly.

Quoted 6 lines

It isn't something I would have expected as part of a patch or patch series series which is supposed to add interrupt support to pmbus drivers. Since it is the first patch in your series, in may hold up the series for some period of time until the questions around it are resolved. Your call, really, how to handle it. Just don't be surprised if it takes a while to resolve the issues.

I'll check with regulator subsystem maintainer on input error & based on feedback will post separate patch.

Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 11 lines

---
  drivers/hwmon/pmbus/pmbus_core.c | 30 ++++++++++++++++++++++--------

  1 file changed, 22 insertions(+), 8 deletions(-)
drivers/hwmon/pmbus/pmbus_core.c +0 -0
index 95e95783972a..f5caceaaef2a 100644

drivers/hwmon/pmbus/pmbus_core.c struct pmbus_regulator_status_category { · line 2754

Quoted 3 lines
drivers/hwmon/pmbus/pmbus_core.c +1 -0
@@ -2752,6 +2752,15 @@ struct pmbus_regulator_status_category {
   static const struct pmbus_regulator_status_category pmbus_regulator_flag_map[] = {
       {
+        .func = -1,

This would need a comment. I don't really see the benefit over the original code.

Quoted 4 lines
Quoted 1 line

I pulled that in so as to handle it in same way as other status register.

That would have to be a separate patch. It took me a while to understand how .func = -1 is handled, so without comment it just adds confusion.

Yes. Will make separate patch & add comment here.

Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 14 lines
drivers/hwmon/pmbus/pmbus_core.c +8 -0
+        .reg = PMBUS_STATUS_BYTE,
+        .bits = (const struct pmbus_regulator_status_assoc[]) {
+            { PB_STATUS_IOUT_OC,   REGULATOR_ERROR_OVER_CURRENT },
+            { PB_STATUS_VOUT_OV,   REGULATOR_ERROR_REGULATION_OUT },
+            { PB_STATUS_VIN_UV,    REGULATOR_ERROR_UNDER_VOLTAGE },
+            { },
+        },
+    }, {
           .func = PMBUS_HAVE_STATUS_VOUT,
           .reg = PMBUS_STATUS_VOUT,
           .bits = (const struct pmbus_regulator_status_assoc[]) {
@@ -2768,6 +2777,7 @@ static const struct 
Quoted 5 lines

pmbus_regulator_status_category pmbus_regulator_flag_map[] = { PB_IOUT_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN }, { PB_IOUT_OC_FAULT,      REGULATOR_ERROR_OVER_CURRENT }, { PB_IOUT_OC_LV_FAULT,   REGULATOR_ERROR_OVER_CURRENT }, +            { PB_POUT_OP_FAULT,      REGULATOR_ERROR_OVER_CURRENT },

OP_FAULT (power fault) and over current are really not the same thing.

Quoted 5 lines
Quoted 1 line

I agree. But thats best I could think of. Not sure if there is better REGULATOR_ERROR_* code for this scenario. Suggestions?

Options are REGULATOR_ERROR_OVER_CURRENT or REGULATOR_ERROR_FAIL or a new failure code or doing nothing. Personally I think REGULATOR_ERROR_FAIL would be better if adding a new failure code is not an option.

Will update to REGULATOR_ERROR_FAIL.

Quoted 8 lines

Anyway, clarify on the regulator subsystem mailing list how to handle input errors, and how to handle power failures. If they say it is acceptable to report input errors as output errors, and to report power failures as current failures, resubmit. Say in comments that this is what you are doing, and in the commit description that this is how input errors and power failures are handled in the regulator subsystem. Copy regulator subsystem maintainers on your patch.

Sure. Will hold back input errors for now & after checking with regulator maintainer, will make separate patch accordingly.

Quoted 53 lines

Thanks,
Guenter

Quoted 48 lines
Quoted 16 lines
Quoted 16 lines

              { },
          },
      }, {

drivers/hwmon/pmbus/pmbus_core.c +0 -0
@@ -2778,6 +2788,18 @@ static const struct 

pmbus_regulator_status_category pmbus_regulator_flag_map[] = { PB_TEMP_OT_FAULT,      REGULATOR_ERROR_OVER_TEMP }, { },
          },
+    }, {
+        .func = PMBUS_HAVE_STATUS_INPUT,
+        .reg = PMBUS_STATUS_INPUT,
+        .bits = (const struct pmbus_regulator_status_assoc[]) { +            { PB_IIN_OC_FAULT,       REGULATOR_ERROR_OVER_CURRENT }, +            { PB_IIN_OC_WARNING, REGULATOR_ERROR_OVER_CURRENT_WARN }, +            { PB_VOLTAGE_UV_FAULT,   REGULATOR_ERROR_UNDER_VOLTAGE }, +            { PB_VOLTAGE_UV_WARNING,

Quoted 9 lines
Quoted 5 lines

REGULATOR_ERROR_UNDER_VOLTAGE_WARN },
+            { PB_VOLTAGE_OV_WARNING,
REGULATOR_ERROR_OVER_VOLTAGE_WARN },
+            { PB_VOLTAGE_OV_FAULT,
REGULATOR_ERROR_OVER_VOLTAGE_WARN },

fault -> warning ? Shouldn't this be REGULATOR_ERROR_FAIL (Regulator output has failed) ?

Yes. REGULATOR_ERROR_FAIL is best fit here. Will update in next revision.

Quoted 22 lines
Quoted 21 lines

+            { },
+        },
      },
  };

drivers/hwmon/pmbus/pmbus_core.c +0 -0
@@ -2834,14 +2856,6 @@ static int 

pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned if (status & PB_STATUS_POWER_GOOD_N)
              *flags |= REGULATOR_ERROR_REGULATION_OUT;
      }
-    /*
-     * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are -     * defined strictly as fault indicators (not warnings). -     */
-    if (status & PB_STATUS_IOUT_OC)
-        *flags |= REGULATOR_ERROR_OVER_CURRENT;
-    if (status & PB_STATUS_VOUT_OV)
-        *flags |= REGULATOR_ERROR_REGULATION_OUT;
      /*
       * If we haven't discovered any thermal faults or warnings via

base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c

Regards,
Naresh