coredump: fix compile warning when ELF_CORE=n while COREDUMP=y
PATCH v2 1/1 coredump: fix compile warning when ELF_CORE=n while COREDUMP=y
fix below build warning when ELF_CORE=n while COREDUMP=y:
fs/coredump.c:834:12: warning: ‘dump_emit_page’ defined but not used [-Wunused-function]
834 | static int dump_emit_page(struct coredump_params *cprm, struct
page *page)
| ^~~~~~~~~~~~~~Fixes the warning by moving the definition of dump_emit_page() in the same #ifdef as of dump_user_range(), since dump_user_range() is the only caller of dump_emit_page().
Fixes 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
Signed-off-by Jisheng Zhang <[email protected]>
Reviewed-by Ritesh Harjani (IBM) <[email protected]>
--- fs/coredump.c | 48 ++++++++++++++++++++++++------------------------ 1 file changed, 24 insertions(+), 24 deletions(-)
Since v1:
- add Fixes tag
- collect Reviewed-by
- fix the warning by moving the definition of dump_emit_page() in the same #ifdef as of dump_user_range().
fs/coredump.c +24 -24
@@ -831,6 +831,30 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr) } } +int dump_emit (struct coredump_params *cprm,const void *addr,int nr) +{ +if (cprm->to_skip) { +if (!__dump_skip (cprm, cprm->to_skip)) +return 0 ; + cprm->to_skip =0 ; + } +return __dump_emit (cprm, addr, nr); +} +EXPORT_SYMBOL (dump_emit); + +void dump_skip_to (struct coredump_params *cprm,unsigned long pos) +{ + cprm->to_skip = pos - cprm->pos; +} +EXPORT_SYMBOL (dump_skip_to); + +void dump_skip (struct coredump_params *cprm,size_t nr) +{ + cprm->to_skip += nr; +} +EXPORT_SYMBOL (dump_skip); + +#ifdef CONFIG_ELF_CORE static int dump_emit_page(struct coredump_params *cprm, struct page *page) { struct bio_vec bvec = {
@@ -864,30 +888,6 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)return 1 ; } -int dump_emit (struct coredump_params *cprm,const void *addr,int nr) -{ -if (cprm->to_skip) { -if (!__dump_skip (cprm, cprm->to_skip)) -return 0 ; - cprm->to_skip =0 ; - } -return __dump_emit (cprm, addr, nr); -} -EXPORT_SYMBOL (dump_emit); - -void dump_skip_to (struct coredump_params *cprm,unsigned long pos) -{ - cprm->to_skip = pos - cprm->pos; -} -EXPORT_SYMBOL (dump_skip_to); - -void dump_skip (struct coredump_params *cprm,size_t nr) -{ - cprm->to_skip += nr; -} -EXPORT_SYMBOL (dump_skip); - -#ifdef CONFIG_ELF_CORE int dump_user_range (struct coredump_params *cprm,unsigned long start,unsigned long len) {
Signature · 1 line
2.37.2