riscv: alternative-macros.h cleanups
PATCH v2 1/4 riscv: Don't duplicate __ALTERNATIVE_CFG in __ALTERNATIVE_CFG_2
In reply to Andrew JonesBuild __ALTERNATIVE_CFG_2 by adding on to __ALTERNATIVE_CFG rather than duplicating it.
--- arch/riscv/include/asm/alternative-macros.h | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-)
arch/riscv/include/asm/alternative-macros.h +2 -16
@@ -49,14 +49,7 @@ .macro __ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ new_c_2, vendor_id_2, errata_id_2, enable_2 -886 : - .option push - .option norvc - .option norelax - \old_c - .option pop -887 : - ALT_NEW_CONTENT \vendor_id_1, \errata_id_1, \enable_1, \new_c_1 + __ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm
@@ -116,14 +109,7 @@ enable_1, \ new_c_2, vendor_id_2, errata_id_2, \ enable_2) \ - "886 :\n" \ - ".option push\n" \ - ".option norvc\n" \ - ".option norelax\n" \ - old_c "\n" \ - ".option pop\n" \ - "887 :\n" \ - ALT_NEW_CONTENT(vendor_id_1, errata_id_1, enable_1, new_c_1) \ + __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ ALT_NEW_CONTENT(vendor_id_2, errata_id_2, enable_2, new_c_2) #define _ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, \
Signature · 7 lines
2.38.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
v2 cover riscv: alternative-macros.h cleanups
This series is a collection of cleanups for alternative-macros.h with the main motivation being that adding new ALTERNATIVE_3, ALTERNATIVE_4, ... will be possible without lots of bloat. For example, adding ALTERNATIVE_3 should look something like the diff below and ALTERNATIVE_4 the same. This has really only been compile tested, as not all alternatives are used when quickly booting over QEMU, which I also did.
Thanks,
drew
arch/riscv/include/asm/alternative-macros.h +36 -0
@@ -50,8 +50,17 @@ ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm +.macro ALTERNATIVE_CFG_3 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2, \ + new_c_3, vendor_id_3, errata_id_3, enable_3 + ALTERNATIVE_CFG_2 \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1, \ + \new_c_2, \vendor_id_2, \errata_id_2, \enable_2 + ALT_NEW_CONTENT \vendor_id_3, \errata_id_3, \enable_3, \new_c_3 +.endm + #define __ALTERNATIVE_CFG(...) ALTERNATIVE_CFG __VA_ARGS__ #define __ALTERNATIVE_CFG_2(...) ALTERNATIVE_CFG_2 __VA_ARGS__ +#define __ALTERNATIVE_CFG_3(...) ALTERNATIVE_CFG_3 __VA_ARGS__#else /* !__ASSEMBLY__ */
@@ -98,6 +107,13 @@ __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ ALT_NEW_CONTENT(vendor_id_2, errata_id_2, enable_2, new_c_2) +#define __ALTERNATIVE_CFG_3 (old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2, \ + new_c_3, vendor_id_3, errata_id_3, enable_3) \ + __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2) \ + ALT_NEW_CONTENT(vendor_id_3, errata_id_3, enable_3, new_c_3) +#endif /* __ASSEMBLY__ */ #define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \
@@ -108,6 +124,13 @@__ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1,IS_ENABLED (CONFIG_k_1), \ new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2)) +#define _ALTERNATIVE_CFG_3 (old_c, new_c_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_c_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_c_3, vendor_id_3, errata_id_3, CONFIG_k_3) \ + __ALTERNATIVE_CFG_3(old_c, new_c_1, vendor_id_1, errata_id_1, IS_ENABLED(CONFIG_k_1), \ + new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2), \ + new_c_3, vendor_id_3, errata_id_3, IS_ENABLED(CONFIG_k_3)) +#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__
@@ -121,6 +144,9 @@#define _ALTERNATIVE_CFG_2 (old_c, ...) \ ALTERNATIVE_CFG old_c +#define _ALTERNATIVE_CFG_3 (old_c, ...) \ + ALTERNATIVE_CFG old_c +#else /* !__ASSEMBLY__ */ #define __ALTERNATIVE_CFG (old_c) \
@@ -132,6 +158,9 @@#define _ALTERNATIVE_CFG_2 (old_c, ...) \ __ALTERNATIVE_CFG(old_c) +#define _ALTERNATIVE_CFG_3 (old_c, ...) \ + __ALTERNATIVE_CFG(old_c) +#endif /* __ASSEMBLY__ */ #endif /* CONFIG_RISCV_ALTERNATIVE */
@@ -163,4 +192,11 @@_ALTERNATIVE_CFG_2 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2) +#define ALTERNATIVE_3 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_content_3, vendor_id_3, errata_id_3, CONFIG_k_3) \ + _ALTERNATIVE_CFG_3(old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_content_3, vendor_id_3, errata_id_3, CONFIG_k_3) +#endif
Andrew Jones (4):
riscv: Don't duplicate __ALTERNATIVE_CFG in __ALTERNATIVE_CFG_2
riscv: alternatives: Don't name unused macro parameters
riscv: alternatives: Drop the underscores from the assembly macro
names
riscv: Don't duplicate _ALTERNATIVE_CFG* macros
arch/riscv/include/asm/alternative-macros.h | 99 +++++++-------------- 1 file changed, 30 insertions(+), 69 deletions(-)
Signature · 7 lines
2.38.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH v2 2/4 riscv: alternatives: Don't name unused macro parameters
Without CONFIG_RISCV_ALTERNATIVE only the first parameter of the ALTERNATIVE macros is needed. Use ... for the rest to cut down on clutter. While there, fix a couple space vs. tab issues.
--- arch/riscv/include/asm/alternative-macros.h | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-)
arch/riscv/include/asm/alternative-macros.h +7 -13
@@ -130,28 +130,22 @@ \old_c .endm -#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ +#define _ALTERNATIVE_CFG (old_c, ...) \ __ALTERNATIVE_CFG old_c -#define _ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, \ - CONFIG_k_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - CONFIG_k_2) \ - __ALTERNATIVE_CFG old_c +#define _ALTERNATIVE_CFG_2 (old_c, ...) \ + __ALTERNATIVE_CFG old_c#else /* !__ASSEMBLY__ */ -#define __ALTERNATIVE_CFG (old_c) \ +#define __ALTERNATIVE_CFG (old_c) \ old_c "\n" -#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ +#define _ALTERNATIVE_CFG (old_c, ...) \ __ALTERNATIVE_CFG(old_c) -#define _ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, \ - CONFIG_k_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - CONFIG_k_2) \ - __ALTERNATIVE_CFG(old_c) +#define _ALTERNATIVE_CFG_2 (old_c, ...) \ + __ALTERNATIVE_CFG(old_c)#endif /* __ASSEMBLY__ */ #endif /* CONFIG_RISCV_ALTERNATIVE */
Signature · 7 lines
2.38.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH v2 3/4 riscv: alternatives: Drop the underscores from the assembly macro names
In reply to Andrew JonesThe underscores aren't needed because there isn't anything already named without them and the _CFG extension. This is a bit of a cleanup by itself, but the real motivation is for a coming patch which would otherwise need to add two more underscores to these macro names, i.e. ____ALTERNATIVE_CFG, and that'd be gross.
--- arch/riscv/include/asm/alternative-macros.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
arch/riscv/include/asm/alternative-macros.h +10 -10
@@ -33,7 +33,7 @@ .endif .endm -.macro __ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, enable +.macro ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, enable 886 : .option push .option norvc
@@ -45,11 +45,11 @@ .endm#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ - __ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) + ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) -.macro __ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ - new_c_2, vendor_id_2, errata_id_2, enable_2 - __ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 +.macro ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2 + ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm
@@ -57,9 +57,9 @@ CONFIG_k_1, \ new_c_2, vendor_id_2, errata_id_2, \ CONFIG_k_2) \ -__ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \ +ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \IS_ENABLED (CONFIG_k_1 ), \ - new_c_2, vendor_id_2, errata_id_2, \ + new_c_2, vendor_id_2, errata_id_2, \IS_ENABLED (CONFIG_k_2 ) #else /* !__ASSEMBLY__ */
@@ -126,15 +126,15 @@#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__ -.macro __ALTERNATIVE_CFG old_c +.macro ALTERNATIVE_CFG old_c \old_c .endm#define _ALTERNATIVE_CFG (old_c, ...) \ - __ALTERNATIVE_CFG old_c + ALTERNATIVE_CFG old_c#define _ALTERNATIVE_CFG_2 (old_c, ...) \ - __ALTERNATIVE_CFG old_c + ALTERNATIVE_CFG old_c#else /* !__ASSEMBLY__ */
Signature · 7 lines
2.38.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH v2 4/4 riscv: Don't duplicate _ALTERNATIVE_CFG* macros
In reply to Andrew JonesReduce clutter by only defining the _ALTERNATIVE_CFG* macros once, rather than once for assembly and once for C. To do that, we need to add __ALTERNATIVE_CFG* macros to the assembly side, but those are one-liners. Also take the opportunity to do a bit of reformatting, taking full advantage of the fact checkpatch gives us 100 char lines.
--- arch/riscv/include/asm/alternative-macros.h | 53 +++++++-------------- 1 file changed, 17 insertions(+), 36 deletions(-)
arch/riscv/include/asm/alternative-macros.h +17 -36
@@ -44,23 +44,14 @@ ALT_NEW_CONTENT \vendor_id, \errata_id, \enable, \new_c .endm -#define _ALTERNATIVE_CFG(old_c, new_c, vendor_id, errata_id, CONFIG_k) \ - ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) - .macro ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ new_c_2, vendor_id_2, errata_id_2, enable_2 ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm -#define _ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, \ - CONFIG_k_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - CONFIG_k_2) \ - ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \ -IS_ENABLED (CONFIG_k_1 ), \ - new_c_2, vendor_id_2, errata_id_2, \ -IS_ENABLED (CONFIG_k_2 ) +#define __ALTERNATIVE_CFG(...) ALTERNATIVE_CFG __VA_ARGS__ +#define __ALTERNATIVE_CFG_2(...) ALTERNATIVE_CFG_2 __VA_ARGS__#else /* !__ASSEMBLY__ */
@@ -102,27 +93,21 @@"887 :\n" \ ALT_NEW_CONTENT(vendor_id, errata_id, enable, new_c) -#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ - __ALTERNATIVE_CFG(old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k)) - -#define __ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, \ - enable_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - enable_2) \ - __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ +#define __ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2) \ + __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ ALT_NEW_CONTENT(vendor_id_2, errata_id_2, enable_2, new_c_2) -#define _ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, \ - CONFIG_k_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - CONFIG_k_2) \ - __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, \ - IS_ENABLED(CONFIG_k_1), \ - new_c_2, vendor_id_2, errata_id_2, \ - IS_ENABLED(CONFIG_k_2)) -#endif /* __ASSEMBLY__ */ +#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ + __ALTERNATIVE_CFG(old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k)) + +#define _ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_c_2, vendor_id_2, errata_id_2, CONFIG_k_2) \ + __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, IS_ENABLED(CONFIG_k_1), \ + new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2)) +#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__
@@ -173,13 +158,9 @@* on the following sample code and then replace ALTERNATIVE() with * ALTERNATIVE_2() to append its customized content. */ -#define ALTERNATIVE_2 (old_content, new_content_1, vendor_id_1, \ - errata_id_1, CONFIG_k_1, \ - new_content_2, vendor_id_2, \ - errata_id_2, CONFIG_k_2) \ - _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, \ - errata_id_1, CONFIG_k_1, \ - new_content_2, vendor_id_2, \ - errata_id_2, CONFIG_k_2) +#define ALTERNATIVE_2 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2) \ + _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2)#endif
Signature · 7 lines
2.38.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v2 1/4] riscv: Don't duplicate __ALTERNATIVE_CFG in __ALTERNATIVE_CFG_2
In reply to Andrew JonesAm Dienstag, 29. November 2022, 16:00:50 CET schrieb Andrew Jones:
Quoted 4 lines
Build
__ALTERNATIVE_CFG_2by adding on to__ALTERNATIVE_CFGrather than duplicating it.Signed-off-by Andrew Jones <[email protected]>
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v2 2/4] riscv: alternatives: Don't name unused macro parameters
In reply to Andrew JonesAm Dienstag, 29. November 2022, 16:00:51 CET schrieb Andrew Jones:
Quoted 5 lines
Without
CONFIG_RISCV_ALTERNATIVEonly the first parameter of the ALTERNATIVE macros is needed. Use ... for the rest to cut down on clutter. While there, fix a couple space vs. tab issues.Signed-off-by Andrew Jones <[email protected]>
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v2 3/4] riscv: alternatives: Drop the underscores from the assembly macro names
In reply to Andrew JonesAm Dienstag, 29. November 2022, 16:00:52 CET schrieb Andrew Jones:
Quoted 7 lines
The underscores aren't needed because there isn't anything already named without them and the
_CFGextension. This is a bit of a cleanup by itself, but the real motivation is for a coming patch which would otherwise need to add two more underscores to these macro names, i.e.____ALTERNATIVE_CFG, and that'd be gross.Signed-off-by Andrew Jones <[email protected]>
Hmm, I would assume the "_" are there to mark those as "internal / don't use". So with removing the underscores you loose that marking.
It works though, so
But I'll leave the judgement on its viability to others.
Heiko
Quoted 55 lines
--- arch/riscv/include/asm/alternative-macros.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)arch/riscv/include/asm/alternative-macros.h +8
-8@@ -33,7 +33,7 @@ .endif .endm -.macro __ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, enable +.macro ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, enable 886 : .option push .option norvc@@ -45,11 +45,11 @@ .endm#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ - __ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) + ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) -.macro __ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ - new_c_2, vendor_id_2, errata_id_2, enable_2 - __ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 +.macro ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2 + ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm@@ -57,9 +57,9 @@ CONFIG_k_1, \ new_c_2, vendor_id_2, errata_id_2, \ CONFIG_k_2) \ -__ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \ +ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \IS_ENABLED (CONFIG_k_1 ), \ - new_c_2, vendor_id_2, errata_id_2, \ + new_c_2, vendor_id_2, errata_id_2, \IS_ENABLED (CONFIG_k_2 ) #else /* !__ASSEMBLY__ */@@ -126,15 +126,15 @@#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__ -.macro __ALTERNATIVE_CFG old_c +.macro ALTERNATIVE_CFG old_c \old_c .endm
arch/riscv/include/asm/alternative-macros.h line 140
Quoted 10 lines
arch/riscv/include/asm/alternative-macros.h +2
-2#define _ALTERNATIVE_CFG (old_c, ...) \ - __ALTERNATIVE_CFG old_c + ALTERNATIVE_CFG old_c#define _ALTERNATIVE_CFG_2 (old_c, ...) \ - __ALTERNATIVE_CFG old_c + ALTERNATIVE_CFG old_c#else /* !__ASSEMBLY__ */
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v2 4/4] riscv: Don't duplicate _ALTERNATIVE_CFG* macros
In reply to Andrew JonesAm Dienstag, 29. November 2022, 16:00:53 CET schrieb Andrew Jones:
Quoted 7 lines
Reduce clutter by only defining the _ALTERNATIVE_CFG* macros once, rather than once for assembly and once for C. To do that, we need to add __ALTERNATIVE_CFG* macros to the assembly side, but those are one-liners. Also take the opportunity to do a bit of reformatting, taking full advantage of the fact checkpatch gives us 100 char lines.
Signed-off-by Andrew Jones <[email protected]>
As this depends on patch3,
But I'll leave the judgement on its viability to others.
Heiko
Quoted 82 lines
--- arch/riscv/include/asm/alternative-macros.h | 53 +++++++-------------- 1 file changed, 17 insertions(+), 36 deletions(-)arch/riscv/include/asm/alternative-macros.h +13
-32@@ -44,23 +44,14 @@ ALT_NEW_CONTENT \vendor_id, \errata_id, \enable, \new_c .endm -#define _ALTERNATIVE_CFG(old_c, new_c, vendor_id, errata_id, CONFIG_k) \ - ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) - .macro ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ new_c_2, vendor_id_2, errata_id_2, enable_2 ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm -#define _ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, \ - CONFIG_k_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - CONFIG_k_2) \ - ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \ -IS_ENABLED (CONFIG_k_1 ), \ - new_c_2, vendor_id_2, errata_id_2, \ -IS_ENABLED (CONFIG_k_2 ) +#define __ALTERNATIVE_CFG(...) ALTERNATIVE_CFG __VA_ARGS__ +#define __ALTERNATIVE_CFG_2(...) ALTERNATIVE_CFG_2 __VA_ARGS__#else /* !__ASSEMBLY__ */ @@ -102,27 +93,21 @@"887 :\n" \ ALT_NEW_CONTENT(vendor_id, errata_id, enable, new_c) -#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ - __ALTERNATIVE_CFG(old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k)) - -#define __ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, \ - enable_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - enable_2) \ - __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ +#define __ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2) \ + __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ ALT_NEW_CONTENT(vendor_id_2, errata_id_2, enable_2, new_c_2) -#define _ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, \ - CONFIG_k_1, \ - new_c_2, vendor_id_2, errata_id_2, \ - CONFIG_k_2) \ - __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, \ - IS_ENABLED(CONFIG_k_1), \ - new_c_2, vendor_id_2, errata_id_2, \ - IS_ENABLED(CONFIG_k_2)) -#endif /* __ASSEMBLY__ */ +#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ + __ALTERNATIVE_CFG(old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k)) + +#define _ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_c_2, vendor_id_2, errata_id_2, CONFIG_k_2) \ + __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, IS_ENABLED(CONFIG_k_1), \ + new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2)) +#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__@@ -173,13 +158,9 @@* on the following sample code and then replace ALTERNATIVE() with * ALTERNATIVE_2() to append its customized content. */ -#define ALTERNATIVE_2 (old_content, new_content_1, vendor_id_1, \ - errata_id_1, CONFIG_k_1, \ - new_content_2, vendor_id_2, \ - errata_id_2, CONFIG_k_2) \
arch/riscv/include/asm/alternative-macros.h line 166
Quoted 10 lines
arch/riscv/include/asm/alternative-macros.h +4
-4-_ALTERNATIVE_CFG_2 (old_content, new_content_1, vendor_id_1, \ - errata_id_1, CONFIG_k_1, \ - new_content_2, vendor_id_2, \ - errata_id_2, CONFIG_k_2) +#define ALTERNATIVE_2 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2) \ + _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2)#endif
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v2 3/4] riscv: alternatives: Drop the underscores from the assembly macro names
In reply to Heiko StübnerQuoted 7 lines · Heiko Stübner
Am Dienstag, 29. November 2022, 16:00:52 CET schrieb Andrew Jones:
Quoted 6 lines
The underscores aren't needed because there isn't anything already named without them and the
_CFGextension. This is a bit of a cleanup by itself, but the real motivation is for a coming patch which would otherwise need to add two more underscores to these macro names, i.e.____ALTERNATIVE_CFG, and that'd be gross.
Quoted 5 lines
Quoted 1 line
Signed-off-by Andrew Jones <[email protected]>Hmm, I would assume the "_" are there to mark those as "internal / don't use". So with removing the underscores you loose that marking.
Yeah, that's usually the case, but here we also have ALT_ENTRY and ALT_NEW_CONTENT macros which are also internal, but don't have leading-underscore names.
Quoted 3 lines
It works though, so
Tested-by Heiko Stuebner <[email protected]>
Thanks,
drew
Quoted 63 lines
But I'll leave the judgement on its viability to others.
Heiko
Quoted 58 lines
--- arch/riscv/include/asm/alternative-macros.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)arch/riscv/include/asm/alternative-macros.h +9
-9@@ -33,7 +33,7 @@ .endif .endm -.macro __ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, enable +.macro ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, enable 886 : .option push .option norvc@@ -45,11 +45,11 @@ .endm#define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \ - __ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) + ALTERNATIVE_CFG old_c, new_c, vendor_id, errata_id, IS_ENABLED(CONFIG_k) -.macro __ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ - new_c_2, vendor_id_2, errata_id_2, enable_2 - __ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 +.macro ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2 + ALTERNATIVE_CFG \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1 ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm@@ -57,9 +57,9 @@ CONFIG_k_1, \ new_c_2, vendor_id_2, errata_id_2, \ CONFIG_k_2) \ -__ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \ +ALTERNATIVE_CFG_2 old_c, new_c_1, vendor_id_1, errata_id_1, \IS_ENABLED (CONFIG_k_1 ), \ - new_c_2, vendor_id_2, errata_id_2, \ + new_c_2, vendor_id_2, errata_id_2, \IS_ENABLED (CONFIG_k_2 ) #else /* !__ASSEMBLY__ */@@ -126,15 +126,15 @@#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__ -.macro __ALTERNATIVE_CFG old_c +.macro ALTERNATIVE_CFG old_c \old_c .endm#define _ALTERNATIVE_CFG (old_c, ...) \ - __ALTERNATIVE_CFG old_c + ALTERNATIVE_CFG old_c
Quoted 11 lines
arch/riscv/include/asm/alternative-macros.h line 140
Quoted 7 lines
arch/riscv/include/asm/alternative-macros.h +1
-1#define _ALTERNATIVE_CFG_2 (old_c, ...) \ - __ALTERNATIVE_CFG old_c + ALTERNATIVE_CFG old_c#else /* !__ASSEMBLY__ */
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Hi Andrew,
Quoted 95 lines · Andrew Jones
This series is a collection of cleanups for
alternative-macros.hwith the main motivation being that adding newALTERNATIVE_3,ALTERNATIVE_4, ... will be possible without lots of bloat. For example, addingALTERNATIVE_3should look something like the diff below andALTERNATIVE_4the same. This has really only been compile tested, as not all alternatives are used when quickly booting over QEMU, which I also did.Thanks,
drewarch/riscv/include/asm/alternative-macros.h +36
-0@@ -50,8 +50,17 @@ ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm +.macro ALTERNATIVE_CFG_3 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2, \ + new_c_3, vendor_id_3, errata_id_3, enable_3 + ALTERNATIVE_CFG_2 \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1, \ + \new_c_2, \vendor_id_2, \errata_id_2, \enable_2 + ALT_NEW_CONTENT \vendor_id_3, \errata_id_3, \enable_3, \new_c_3 +.endm + #define __ALTERNATIVE_CFG(...) ALTERNATIVE_CFG __VA_ARGS__ #define __ALTERNATIVE_CFG_2(...) ALTERNATIVE_CFG_2 __VA_ARGS__ +#define __ALTERNATIVE_CFG_3(...) ALTERNATIVE_CFG_3 __VA_ARGS__#else /* !__ASSEMBLY__ */ @@ -98,6 +107,13 @@ __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ ALT_NEW_CONTENT(vendor_id_2, errata_id_2, enable_2, new_c_2) +#define __ALTERNATIVE_CFG_3 (old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2, \ + new_c_3, vendor_id_3, errata_id_3, enable_3) \ + __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2) \ + ALT_NEW_CONTENT(vendor_id_3, errata_id_3, enable_3, new_c_3) +#endif /* __ASSEMBLY__ */ #define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \@@ -108,6 +124,13 @@__ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1,IS_ENABLED (CONFIG_k_1), \ new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2)) +#define _ALTERNATIVE_CFG_3 (old_c, new_c_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_c_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_c_3, vendor_id_3, errata_id_3, CONFIG_k_3) \ + __ALTERNATIVE_CFG_3(old_c, new_c_1, vendor_id_1, errata_id_1, IS_ENABLED(CONFIG_k_1), \ + new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2), \ + new_c_3, vendor_id_3, errata_id_3, IS_ENABLED(CONFIG_k_3)) +#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__@@ -121,6 +144,9 @@#define _ALTERNATIVE_CFG_2 (old_c, ...) \ ALTERNATIVE_CFG old_c +#define _ALTERNATIVE_CFG_3 (old_c, ...) \ + ALTERNATIVE_CFG old_c +#else /* !__ASSEMBLY__ */ #define __ALTERNATIVE_CFG (old_c) \@@ -132,6 +158,9 @@#define _ALTERNATIVE_CFG_2 (old_c, ...) \ __ALTERNATIVE_CFG(old_c) +#define _ALTERNATIVE_CFG_3 (old_c, ...) \ + __ALTERNATIVE_CFG(old_c) +#endif /* __ASSEMBLY__ */ #endif /* CONFIG_RISCV_ALTERNATIVE */ @@ -163,4 +192,11 @@_ALTERNATIVE_CFG_2 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2) +#define ALTERNATIVE_3 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_content_3, vendor_id_3, errata_id_3, CONFIG_k_3) \ + _ALTERNATIVE_CFG_3(old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_content_3, vendor_id_3, errata_id_3, CONFIG_k_3) +#endif
Quoted 7 lines
Andrew Jones (4):
riscv: Don't duplicate__ALTERNATIVE_CFGin__ALTERNATIVE_CFG_2
riscv: alternatives: Don't name unused macro parameters
riscv: alternatives: Drop the underscores from the assembly macro
names
riscv: Don't duplicate _ALTERNATIVE_CFG* macros
For the whole series:
Cheers,
Prabhakar
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 10 lines · Andrew Jones
This series is a collection of cleanups for
alternative-macros.hwith the main motivation being that adding newALTERNATIVE_3,ALTERNATIVE_4, ... will be possible without lots of bloat. For example, addingALTERNATIVE_3should look something like the diff below andALTERNATIVE_4the same. This has really only been compile tested, as not all alternatives are used when quickly booting over QEMU, which I also did.Thanks,
drew
I was trying to find the cover from patchwork - but it really hates this diff for some reason and treats it like another patch... I dunno how you would work around that, maybe put a -- line above the patch?
Anyways, what was going to say was that it'd be nice if you had the inter-version changelog somewhere - especially for something touching this neck of the woods. b4 diff to the rescue though, it is just the missing \s from v1.
I'm kinda with Heiko in the "I'll leave the judgement on its viability to others" camp, but I'm in favour of simplifying the process of adding alternatives so:
Thanks,
Conor.
Quoted 91 lines
arch/riscv/include/asm/alternative-macros.h +36
-0@@ -50,8 +50,17 @@ ALT_NEW_CONTENT \vendor_id_2, \errata_id_2, \enable_2, \new_c_2 .endm +.macro ALTERNATIVE_CFG_3 old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2, \ + new_c_3, vendor_id_3, errata_id_3, enable_3 + ALTERNATIVE_CFG_2 \old_c, \new_c_1, \vendor_id_1, \errata_id_1, \enable_1, \ + \new_c_2, \vendor_id_2, \errata_id_2, \enable_2 + ALT_NEW_CONTENT \vendor_id_3, \errata_id_3, \enable_3, \new_c_3 +.endm + #define __ALTERNATIVE_CFG(...) ALTERNATIVE_CFG __VA_ARGS__ #define __ALTERNATIVE_CFG_2(...) ALTERNATIVE_CFG_2 __VA_ARGS__ +#define __ALTERNATIVE_CFG_3(...) ALTERNATIVE_CFG_3 __VA_ARGS__#else /* !__ASSEMBLY__ */ @@ -98,6 +107,13 @@ __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1) \ ALT_NEW_CONTENT(vendor_id_2, errata_id_2, enable_2, new_c_2) +#define __ALTERNATIVE_CFG_3 (old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2, \ + new_c_3, vendor_id_3, errata_id_3, enable_3) \ + __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, errata_id_1, enable_1, \ + new_c_2, vendor_id_2, errata_id_2, enable_2) \ + ALT_NEW_CONTENT(vendor_id_3, errata_id_3, enable_3, new_c_3) +#endif /* __ASSEMBLY__ */ #define _ALTERNATIVE_CFG (old_c, new_c, vendor_id, errata_id, CONFIG_k) \@@ -108,6 +124,13 @@__ALTERNATIVE_CFG_2 (old_c, new_c_1, vendor_id_1, errata_id_1,IS_ENABLED (CONFIG_k_1), \ new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2)) +#define _ALTERNATIVE_CFG_3 (old_c, new_c_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_c_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_c_3, vendor_id_3, errata_id_3, CONFIG_k_3) \ + __ALTERNATIVE_CFG_3(old_c, new_c_1, vendor_id_1, errata_id_1, IS_ENABLED(CONFIG_k_1), \ + new_c_2, vendor_id_2, errata_id_2, IS_ENABLED(CONFIG_k_2), \ + new_c_3, vendor_id_3, errata_id_3, IS_ENABLED(CONFIG_k_3)) +#else /* CONFIG_RISCV_ALTERNATIVE */ #ifdef __ASSEMBLY__@@ -121,6 +144,9 @@#define _ALTERNATIVE_CFG_2 (old_c, ...) \ ALTERNATIVE_CFG old_c +#define _ALTERNATIVE_CFG_3 (old_c, ...) \ + ALTERNATIVE_CFG old_c +#else /* !__ASSEMBLY__ */ #define __ALTERNATIVE_CFG (old_c) \@@ -132,6 +158,9 @@#define _ALTERNATIVE_CFG_2 (old_c, ...) \ __ALTERNATIVE_CFG(old_c) +#define _ALTERNATIVE_CFG_3 (old_c, ...) \ + __ALTERNATIVE_CFG(old_c) +#endif /* __ASSEMBLY__ */ #endif /* CONFIG_RISCV_ALTERNATIVE */ @@ -163,4 +192,11 @@_ALTERNATIVE_CFG_2 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2) +#define ALTERNATIVE_3 (old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_content_3, vendor_id_3, errata_id_3, CONFIG_k_3) \ + _ALTERNATIVE_CFG_3(old_content, new_content_1, vendor_id_1, errata_id_1, CONFIG_k_1, \ + new_content_2, vendor_id_2, errata_id_2, CONFIG_k_2, \ + new_content_3, vendor_id_3, errata_id_3, CONFIG_k_3) +#endif Andrew Jones (4):
riscv: Don't duplicate__ALTERNATIVE_CFGin__ALTERNATIVE_CFG_2
riscv: alternatives: Don't name unused macro parameters
riscv: alternatives: Drop the underscores from the assembly macro
names
riscv: Don't duplicate _ALTERNATIVE_CFG* macros
Quoted 12 lines
arch/riscv/include/asm/alternative-macros.h | 99 +++++++-------------- 1 file changed, 30 insertions(+), 69 deletions(-)Signature · 7 lines
2.38.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Palmer Dabbelt
AppliedQuoted 9 lines · Andrew Jones
This series is a collection of cleanups for
alternative-macros.hwith the main motivation being that adding newALTERNATIVE_3,ALTERNATIVE_4, ... will be possible without lots of bloat. For example, addingALTERNATIVE_3should look something like the diff below andALTERNATIVE_4the same. This has really only been compile tested, as not all alternatives are used when quickly booting over QEMU, which I also did.[...]
Applied, thanks!
[0/4] riscv: alternative-macros.h cleanups
https://git.kernel.org/palmer/c/a0b4c0f7a0a2 [1/4] riscv: Don't duplicate __ALTERNATIVE_CFG in __ALTERNATIVE_CFG_2 https://git.kernel.org/palmer/c/2ba8c7dc71c0 [2/4] riscv: alternatives: Don't name unused macro parameters https://git.kernel.org/palmer/c/7d52eace1bf5 [3/4] riscv: alternatives: Drop the underscores from the assembly macro names https://git.kernel.org/palmer/c/bb2efcde5946 [4/4] riscv: Don't duplicate _ALTERNATIVE_CFG* macros https://git.kernel.org/palmer/c/26fb4b90b745
Best regards,
Signature · 6 lines
Palmer Dabbelt <[email protected]> _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v2 1/4] riscv: Don't duplicate __ALTERNATIVE_CFG in __ALTERNATIVE_CFG_2
In reply to Andrew JonesThis series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Hello:
This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Quoted 7 lines · On Tue, 29 Nov 2022 16:00:50 +0100 you wrote:
Build
__ALTERNATIVE_CFG_2by adding on to__ALTERNATIVE_CFGrather than duplicating it.Signed-off-by Andrew Jones <[email protected]>--- arch/riscv/include/asm/alternative-macros.h | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-)
Here is the summary with links:
- [v2,1/4] riscv: Don't duplicate __ALTERNATIVE_CFG in __ALTERNATIVE_CFG_2
https://git.kernel.org/riscv/c/2ba8c7dc71c0 - [v2,2/4] riscv: alternatives: Don't name unused macro parameters https://git.kernel.org/riscv/c/7d52eace1bf5 - [v2,3/4] riscv: alternatives: Drop the underscores from the assembly macro names https://git.kernel.org/riscv/c/bb2efcde5946 - [v2,4/4] riscv: Don't duplicate _ALTERNATIVE_CFG* macros https://git.kernel.org/riscv/c/26fb4b90b745
You are awesome, thank you!
Signature · 9 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv