Skip to contentSkip to conversation

ACPI: PAD: use sysfs_emit() to instead of scnprintf()

PATCH In review [email protected] 2 participants 2 messages Nov 29, 2022 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: PAD: use sysfs_emit() to instead of scnprintf()

From: ye xingchen <[email protected]>

Replace the open-code with sysfs_emit() to simplify the code.

---
 drivers/acpi/acpi_pad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/acpi_pad.c +2 -2
index edbb28faee2a..02f1a1b1143c 100644
@@ -287,7 +287,7 @@ static ssize_t rrtime_store(struct device *dev,
 static ssize_t rrtime_show(struct device *dev,
 	struct device_attribute *attr, char *buf)
 {
-	return scnprintf(buf, PAGE_SIZE, "%d\n", round_robin_time);
+	return sysfs_emit(buf, "%d\n", round_robin_time);
 }
 static DEVICE_ATTR_RW(rrtime);
 
@@ -309,7 +309,7 @@ static ssize_t idlepct_store(struct device *dev,
 static ssize_t idlepct_show(struct device *dev,
 	struct device_attribute *attr, char *buf)
 {
-	return scnprintf(buf, PAGE_SIZE, "%d\n", idle_pct);
+	return sysfs_emit(buf, "%d\n", idle_pct);
 }
 static DEVICE_ATTR_RW(idlepct);
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · On Tue, Nov 29, 2022 at 12:32 PM <[email protected]> wrote:

From: ye xingchen <[email protected]>

Replace the open-code with sysfs_emit() to simplify the code.

Can you please send one combo patch for this for all of the affected code in drivers/acpi/?

Quoted 28 lines
---
 drivers/acpi/acpi_pad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/acpi_pad.c +2 -3
index edbb28faee2a..02f1a1b1143c 100644
@@ -287,7 +287,7 @@ static ssize_t rrtime_store(struct device *dev,
 static ssize_t rrtime_show(struct device *dev,
        struct device_attribute *attr, char *buf)
 {
-       return scnprintf(buf, PAGE_SIZE, "%d\n", round_robin_time);
+       return sysfs_emit(buf, "%d\n", round_robin_time);
 }
 static DEVICE_ATTR_RW(rrtime);
 
@@ -309,7 +309,7 @@ static ssize_t idlepct_store(struct device *dev,
 static ssize_t idlepct_show(struct device *dev,
        struct device_attribute *attr, char *buf)
 {
-       return scnprintf(buf, PAGE_SIZE, "%d\n", idle_pct);
+       return sysfs_emit(buf, "%d\n", idle_pct);
 }
 static DEVICE_ATTR_RW(idlepct);
 
--

2.25.1