lib/string_helpers: Add missing header files to MAINTAINERS database
Subsystems (2)
PATCH 1/3 lib/string_helpers: Add missing header files to MAINTAINERS database
The header files string.h and string_helpers.h are missing in the MAINTAINERS. Add them.
Signed-off-by Andy Shevchenko <[email protected]>
--- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
@@ -8721,6 +8721,8 @@ F: drivers/input/touchscreen/resistive-adc-touch.c GENERIC STRING LIBRARY R: Andy Shevchenko <[email protected]> S: Maintained +F: include/linux/string.h +F: include/linux/string_helpers.h F: lib/string.c F: lib/string_helpers.c F: lib/test_string.c
Signature · 1 line
2.35.1
PATCH 2/3 lib/string_helpers: Add str_high_low() helper
Add str_high_low() helper to return 'high' or 'low' string literal.
Signed-off-by Andy Shevchenko <[email protected]>
--- include/linux/string_helpers.h | 5 +++++ 1 file changed, 5 insertions(+)
include/linux/string_helpers.h +5 -0
@@ -128,6 +128,11 @@ static inline const char *str_enabled_disabled(bool v)return v ?"enabled" :"disabled" ; } +static inline const char *str_high_low (bool v) +{ +return v ?"high" :"low" ; +} +static inline const char *str_read_write (bool v) {return v ?"read" :"write" ;
Signature · 1 line
2.35.1
PATCH 3/3 lib/string_helpers: Split out string_choices.h
In reply to Andy ShevchenkoSome users may only need the string choice APIs. Split the respective header, i.e. string_choices.h. Include it in the string_helpers.h.
Signed-off-by Andy Shevchenko <[email protected]>
--- MAINTAINERS | 1 + include/linux/string_choices.h | 37 ++++++++++++++++++++++++++++++++++ include/linux/string_helpers.h | 31 +--------------------------- 3 files changed, 39 insertions(+), 30 deletions(-) create mode 100644 include/linux/string_choices.h
MAINTAINERS +1 -0
@@ -8722,6 +8722,7 @@ GENERIC STRING LIBRARY R: Andy Shevchenko <[email protected]> S: Maintained F: include/linux/string.h +F: include/linux/string_choices.h F: include/linux/string_helpers.h F: lib/string.c F: lib/string_helpers.c
include/linux/string_choices.h new file +37 -0
@@ -0,0 +1,37 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_STRING_CHOICES_H_ +#define _LINUX_STRING_CHOICES_H_ + +#include <linux/types.h> + +static inline const char *str_enable_disable (bool v) +{ +return v ?"enable" :"disable" ; +} + +static inline const char *str_enabled_disabled (bool v) +{ +return v ?"enabled" :"disabled" ; +} + +static inline const char *str_high_low (bool v) +{ +return v ?"high" :"low" ; +} + +static inline const char *str_read_write (bool v) +{ +return v ?"read" :"write" ; +} + +static inline const char *str_on_off (bool v) +{ +return v ?"on" :"off" ; +} + +static inline const char *str_yes_no (bool v) +{ +return v ?"yes" :"no" ; +} + +#endif
include/linux/string_helpers.h +1 -30
@@ -5,6 +5,7 @@#include <linux/bits.h> #include <linux/ctype.h> #include <linux/string.h> +#include <linux/string_choices.h> #include <linux/types.h> struct device ;
@@ -108,34 +109,4 @@ void kfree_strarray(char **array, size_t n);char **devm_kasprintf_strarray (struct device *dev,const char *prefix,size_t n); -static inline const char *str_yes_no (bool v) -{ -return v ?"yes" :"no" ; -} - -static inline const char *str_on_off (bool v) -{ -return v ?"on" :"off" ; -} - -static inline const char *str_enable_disable (bool v) -{ -return v ?"enable" :"disable" ; -} - -static inline const char *str_enabled_disabled (bool v) -{ -return v ?"enabled" :"disabled" ; -} - -static inline const char *str_high_low (bool v) -{ -return v ?"high" :"low" ; -} - -static inline const char *str_read_write (bool v) -{ -return v ?"read" :"write" ; -} -#endif
Signature · 1 line
2.35.1
Re: [PATCH v1 3/3] lib/string_helpers: Split out string_choices.h
Quoted 3 lines · Andy Shevchenko
Some users may only need the string choice APIs. Split the respective header, i.e.
string_choices.h. Include it in thestring_helpers.h.
This one can be skipped for now, can be considered just an idea.
Signature · 2 lines
With Best Regards, Andy Shevchenko