Skip to contentSkip to conversation

ARM: Remove redundant arch_cpu_idle_prepare()

PATCH In review Yajun Deng 1 participant 2 messages Dec 1, 2022 – Dec 30, 2022 Arm (32-bit)

lore
Share & tools
lore

Yajun Deng

author
#0 lore raw

PATCH 1/1 ARM: Remove redundant arch_cpu_idle_prepare()

arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is just a wrapper for local_fiq_enable().

The local_fiq_enable() was already called before cpu_startup_entry().

So remove redundant arch_cpu_idle_prepare().

---
 arch/arm/kernel/process.c | 5 -----
 1 file changed, 5 deletions(-)
arch/arm/kernel/process.c +0 -5
index f811733a8fc5..e3f490ab95f4 100644
@@ -81,11 +81,6 @@ void arch_cpu_idle(void)
 	raw_local_irq_enable();
 }
 
-void arch_cpu_idle_prepare(void)
-{
-	local_fiq_enable();
-}
-
 void arch_cpu_idle_enter(void)
 {
 	ledtrig_cpu(CPU_LED_IDLE_START);
Signature · 1 line
2.25.1
author
#1 lore raw
Quoted 30 lines · Yajun Deng

arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is just a wrapper for local_fiq_enable().

The local_fiq_enable() was already called before cpu_startup_entry().

So remove redundant arch_cpu_idle_prepare().

---
arch/arm/kernel/process.c | 5 -----

1 file changed, 5 deletions(-)
arch/arm/kernel/process.c +0 -5
index f811733a8fc5..e3f490ab95f4 100644
@@ -81,11 +81,6 @@ void arch_cpu_idle(void)
 raw_local_irq_enable();
 }
 
-void arch_cpu_idle_prepare(void)
-{
- local_fiq_enable();
-}
-
 void arch_cpu_idle_enter(void)
 {
 ledtrig_cpu(CPU_LED_IDLE_START);
Signature · 1 line
2.25.1

Ping.