Skip to contentSkip to conversation

mmc: sdhci: Remove unneeded semicolon

PATCH Superseded [email protected] 2 participants 2 messages Dec 1, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci: Remove unneeded semicolon

From: zhang songyi <[email protected]>

The semicolon after the "}" is unneeded.

---
 drivers/mmc/host/sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci.c +1 -1
index 42aaeabcad22..8413180a1039 100644
@@ -2289,7 +2289,7 @@ static bool sdhci_timing_has_preset(unsigned char timing)
        case MMC_TIMING_UHS_DDR50:
        case MMC_TIMING_MMC_DDR52:
                return true;
-       };
+       }
        return false;
 }
 

--
2.15.2

#1 lore raw
Quoted 6 lines · On Thu, 1 Dec 2022 at 02:26, <[email protected]> wrote:

From: zhang songyi <[email protected]>

The semicolon after the "}" is unneeded.

Please run checkpatch (./scripts/checkpatch.pl) to make sure there are no obvious formatting problems with your patch. This time it gives the below warning, please fix it and resubmit a new version.

WARNING: please, no spaces at the start of a line
#79: FILE: drivers/mmc/host/sdhci.c:2292:
+ }$

total: 0 errors, 1 warnings, 8 lines checked

Kind regards
Uffe

Quoted 19 lines
---
 drivers/mmc/host/sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci.c +1 -2
index 42aaeabcad22..8413180a1039 100644
@@ -2289,7 +2289,7 @@ static bool sdhci_timing_has_preset(unsigned char timing)
        case MMC_TIMING_UHS_DDR50:
        case MMC_TIMING_MMC_DDR52:
                return true;
-       };
+       }
        return false;
 }
 
--

2.15.2