bus: use sysfs_emit() to instead of scnprintf()
PATCH 1/1 bus: use sysfs_emit() to instead of scnprintf()
From: ye xingchen <[email protected]>
Replace the open-code with sysfs_emit() to simplify the code.
Signed-off-by ye xingchen <[email protected]>
--- drivers/bus/bt1-apb.c | 6 +++--- drivers/bus/bt1-axi.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/bus/bt1-apb.c +3 -3
@@ -265,7 +265,7 @@ static ssize_t count_show(struct device *dev, struct device_attribute *attr, {struct bt1_apb *apb =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%d\n" ,atomic_read (&apb->count)); +return sysfs_emit (buf,"%d\n" ,atomic_read (&apb->count)); }static DEVICE_ATTR_RO (count);
@@ -283,7 +283,7 @@ static ssize_t timeout_show(struct device *dev, struct device_attribute *attr, timeout =bt1_apb_n_to_timeout_us (apb, n); -return scnprintf (buf,PAGE_SIZE ,"%lu\n" , timeout); +return sysfs_emit (buf,"%lu\n" , timeout); } static ssize_t timeout_store(struct device *dev,
@@ -310,7 +310,7 @@ static DEVICE_ATTR_RW(timeout);static ssize_t inject_error_show (struct device *dev,struct device_attribute *attr,char *buf) { -return scnprintf (buf,PAGE_SIZE ,"Error injection: nodev irq\n" ); +return sysfs_emit (buf,"Error injection: nodev irq\n" ); } static ssize_t inject_error_store(struct device *dev,
drivers/bus/bt1-axi.c +2 -2
@@ -197,14 +197,14 @@ static ssize_t count_show(struct device *dev, {struct bt1_axi *axi =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%d\n" ,atomic_read (&axi->count)); +return sysfs_emit (buf,"%d\n" ,atomic_read (&axi->count)); }static DEVICE_ATTR_RO (count);static ssize_t inject_error_show (struct device *dev,struct device_attribute *attr,char *buf) { -return scnprintf (buf,PAGE_SIZE ,"Error injection: bus unaligned\n" ); +return sysfs_emit (buf,"Error injection: bus unaligned\n" ); } static ssize_t inject_error_store(struct device *dev,
Signature · 1 line
2.25.1
Quoted 3 lines · On Thu, Dec 01, 2022 at 09:38:14AM +0800, [email protected] wrote:
From: ye xingchen <[email protected]>
Replace the open-code with
sysfs_emit()to simplify the code.
Nice cleanup. Thanks.
Acked-by Serge Semin <[email protected]>
* One note. Next time please use the scripts/get_maintainer.pl script to get the driver maintainers list and their actual email addresses.
-Sergey
Quoted 62 lines
Signed-off-by ye xingchen <[email protected]>--- drivers/bus/bt1-apb.c | 6 +++--- drivers/bus/bt1-axi.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)drivers/bus/bt1-apb.c +3
-3@@ -265,7 +265,7 @@ static ssize_t count_show(struct device *dev, struct device_attribute *attr, {struct bt1_apb *apb =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%d\n" ,atomic_read (&apb->count)); +return sysfs_emit (buf,"%d\n" ,atomic_read (&apb->count)); }static DEVICE_ATTR_RO (count);@@ -283,7 +283,7 @@ static ssize_t timeout_show(struct device *dev, struct device_attribute *attr, timeout =bt1_apb_n_to_timeout_us (apb, n); -return scnprintf (buf,PAGE_SIZE ,"%lu\n" , timeout); +return sysfs_emit (buf,"%lu\n" , timeout); } static ssize_t timeout_store(struct device *dev,@@ -310,7 +310,7 @@ static DEVICE_ATTR_RW(timeout);static ssize_t inject_error_show (struct device *dev,struct device_attribute *attr,char *buf) { -return scnprintf (buf,PAGE_SIZE ,"Error injection: nodev irq\n" ); +return sysfs_emit (buf,"Error injection: nodev irq\n" ); } static ssize_t inject_error_store(struct device *dev,drivers/bus/bt1-axi.c +2
-2@@ -197,14 +197,14 @@ static ssize_t count_show(struct device *dev, {struct bt1_axi *axi =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%d\n" ,atomic_read (&axi->count)); +return sysfs_emit (buf,"%d\n" ,atomic_read (&axi->count)); }static DEVICE_ATTR_RO (count);static ssize_t inject_error_show (struct device *dev,struct device_attribute *attr,char *buf) { -return scnprintf (buf,PAGE_SIZE ,"Error injection: bus unaligned\n" ); +return sysfs_emit (buf,"Error injection: bus unaligned\n" ); } static ssize_t inject_error_store(struct device *dev,Signature · 1 line
2.25.1