x86/reboot: KVM: Clean up "emergency" virt code
Sean Christopherson
maintainercover x86/reboot: KVM: Clean up "emergency" virt code
Instead of having the reboot code blindly try to disable virtualization during an emergency, use the existing callback into KVM to disable virt as "needed". In quotes because KVM still somewhat blindly attempts to disable virt, e.g. if KVM is loaded but doesn't have active VMs and thus hasn't enabled hardware. That could theoretically be "fixed", but due to the callback being invoked from NMI context, I'm not convinced it would be worth the complexity. E.g. false positives would still be possible, and KVM would have to play games with the per-CPU hardware_enabled flag to ensure there are no false negatives.
The callback is currently used only to VMCLEAR the per-CPU list of VMCSes, but not using the callback to disable virt isn't intentional. Arguably, a callback should have been used in the initial "disable virt" code added by commit d176720d34c7 ("x86: disable VMX on all CPUs on reboot"). And the kexec logic added (much later) by commit f23d1f4a1160 ("x86/kexec: VMCLEAR VMCSs loaded on all cpus if necessary") simply missed the opportunity to use the callback for all virtualization needs.
Once KVM handles disabling virt, move all of the helpers provided by virtext.h into KVM proper.
There's one outlier patch, "Make KVM_AMD depend on CPU_SUP_AMD or CPU_SUP_HYGON", that I included here because it felt weird to pull in the "must be AMD or Hygon" check without KVM demanding that at build time.
Note, there have been conversations at various times about supporting additional in-tree users of virtualization. Somewhat counter-intuitively, giving KVM full ownership of virt actually make it _easier_ to support additional virt users as having all of the code in one place makes it easier to extract the bits that need to be shared.
This applies on
git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm/queue
plus two series (order shouldn't matter)
1. https://lore.kernel.org/all/[email protected]
2. https://lore.kernel.org/all/[email protected]
#1 is a cleanup of the related NMI shootdown logic. #2 is a large overhaul of code surrouding KVM's hardware enabling/disabling. If/when folks are happy with this series, my preference is to take it through the KVM tree as I'm hoping #1 will get merged sooner than later (bug fixes), and there are non-trivial conflicts with #2.
Sean Christopherson (16):
x86/reboot: VMCLEAR active VMCSes before emergency reboot x86/reboot: Expose VMCS crash hooks if and only if KVM_INTEL is
enabled
x86/reboot: Harden virtualization hooks for emergency reboot x86/reboot: Assert that IRQs are disabled when turning off
virtualization
x86/reboot: KVM: Handle VMXOFF in KVM's reboot callback x86/reboot: KVM: Disable SVM during reboot via virt/KVM reboot
callback
x86/reboot: Hoist "disable virt" helpers above "emergency reboot" path x86/reboot: Disable virtualization during reboot iff callback is
registered
x86/virt: KVM: Open code cpu_has_vmx() in KVM VMX x86/virt: KVM: Move VMXOFF helpers into KVM VMX
KVM: SVM: Make KVM_AMD depend on CPU_SUP_AMD or CPU_SUP_HYGON x86/virt: Drop unnecessary check on extended CPUID level in
cpu_has_svm()
x86/virt: KVM: Open code cpu_has_svm() into kvm_is_svm_supported() x86/virt: KVM: Move "disable SVM" helper into KVM SVM
KVM: x86: Force kvm_rebooting=true during emergency reboot/crash
KVM: SVM: Use "standard" stgi() helper when disabling SVM
arch/x86/include/asm/kexec.h | 2 - arch/x86/include/asm/reboot.h | 7 ++ arch/x86/include/asm/virtext.h | 151 --------------------------------- arch/x86/kernel/crash.c | 31 ------- arch/x86/kernel/reboot.c | 59 ++++++++++--- arch/x86/kvm/Kconfig | 2 +- arch/x86/kvm/svm/svm.c | 51 +++++++++-- arch/x86/kvm/vmx/vmx.c | 51 +++++++---- 8 files changed, 133 insertions(+), 221 deletions(-) delete mode 100644 arch/x86/include/asm/virtext.h
base-commit: 02f831ac0dcd7593f8dbb5495135406ffd55952c
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 1/16 x86/reboot: VMCLEAR active VMCSes before emergency reboot
VMCLEAR active VMCSes before any emergency reboot, not just if the kernel may kexec into a new kernel after a crash. Per Intel's SDM, the VMX architecture doesn't require the CPU to flush the VMCS cache on INIT. If an emergency reboot doesn't RESET CPUs, cached VMCSes could theoretically be kept and only be written back to memory after the new kernel is booted, i.e. could effectively corrupt memory after reboot.
Opportunistically remove the setting of the global pointer to NULL to make checkpatch happy.
--- arch/x86/include/asm/kexec.h | 2 -- arch/x86/include/asm/reboot.h | 2 ++ arch/x86/kernel/crash.c | 31 ------------------------------- arch/x86/kernel/reboot.c | 22 ++++++++++++++++++++++ arch/x86/kvm/vmx/vmx.c | 10 +++------- 5 files changed, 27 insertions(+), 40 deletions(-)
arch/x86/include/asm/kexec.h +0 -2
@@ -208,8 +208,6 @@ int arch_kimage_file_post_load_cleanup(struct kimage *image);#endif #endif -typedef void crash_vmclear_fn (void ); -extern crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss;extern void kdump_nmi_shootdown_cpus (void );#endif /* __ASSEMBLY__ */
arch/x86/include/asm/reboot.h +2 -0
@@ -25,6 +25,8 @@ void __noreturn machine_real_restart(unsigned int type);#define MRR_BIOS 0#define MRR_APM 1 +typedef void crash_vmclear_fn (void ); +extern crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss;void cpu_emergency_disable_virtualization (void );typedef void (*nmi_shootdown_cb )(int ,struct pt_regs *);
arch/x86/kernel/crash.c +0 -31
@@ -48,38 +48,12 @@ struct crash_memmap_data {unsigned int type; }; -/* -* This is used to VMCLEAR all VMCSs loaded on the -* processor. And when loading kvm_intel module, the -* callback function pointer will be assigned. -* -* protected by rcu. -*/ -crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss =NULL ; -EXPORT_SYMBOL_GPL (crash_vmclear_loaded_vmcss); - -static inline void cpu_crash_vmclear_loaded_vmcss (void ) -{ -crash_vmclear_fn *do_vmclear_operation =NULL ; - -rcu_read_lock (); - do_vmclear_operation =rcu_dereference (crash_vmclear_loaded_vmcss); -if (do_vmclear_operation) -do_vmclear_operation (); -rcu_read_unlock (); -} -#if defined(CONFIG_SMP ) && defined(CONFIG_X86_LOCAL_APIC )static void kdump_nmi_callback (int cpu,struct pt_regs *regs) {crash_save_cpu (regs, cpu); -/* -* VMCLEAR VMCSs loaded on all cpus if needed. -*/ -cpu_crash_vmclear_loaded_vmcss (); -/* * Disable Intel PT to stop its logging */
@@ -133,11 +107,6 @@ void native_machine_crash_shutdown(struct pt_regs *regs)crash_smp_send_stop (); -/* -* VMCLEAR VMCSs loaded on this cpu if needed. -*/ -cpu_crash_vmclear_loaded_vmcss (); -cpu_emergency_disable_virtualization ();/*
arch/x86/kernel/reboot.c +22 -0
@@ -787,6 +787,26 @@ void machine_crash_shutdown(struct pt_regs *regs) }#endif +/* +* This is used to VMCLEAR all VMCSs loaded on the +* processor. And when loading kvm_intel module, the +* callback function pointer will be assigned. +* +* protected by rcu. +*/ +crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss; +EXPORT_SYMBOL_GPL (crash_vmclear_loaded_vmcss); + +static inline void cpu_crash_vmclear_loaded_vmcss (void ) +{ +crash_vmclear_fn *do_vmclear_operation =NULL ; + +rcu_read_lock (); + do_vmclear_operation =rcu_dereference (crash_vmclear_loaded_vmcss); +if (do_vmclear_operation) +do_vmclear_operation (); +rcu_read_unlock (); +}/* This is the CPU performing the emergency shutdown work. */ int crashing_cpu =-1 ;
@@ -798,6 +818,8 @@ int crashing_cpu = -1;*/ void cpu_emergency_disable_virtualization (void ) { +cpu_crash_vmclear_loaded_vmcss (); +cpu_emergency_vmxoff ();cpu_emergency_svm_disable (); }
arch/x86/kvm/vmx/vmx.c +3 -7
@@ -41,7 +41,7 @@#include <asm/idtentry.h> #include <asm/io.h> #include <asm/irq_remapping.h> -#include <asm/kexec.h> +#include <asm/reboot.h> #include <asm/perf_event.h> #include <asm/mmu_context.h> #include <asm/mshyperv.h>
@@ -743,7 +743,6 @@ static int vmx_set_guest_uret_msr(struct vcpu_vmx *vmx,return ret; } -#ifdef CONFIG_KEXEC_CORE static void crash_vmclear_local_loaded_vmcss (void ) {int cpu =raw_smp_processor_id ();
@@ -753,7 +752,6 @@ static void crash_vmclear_local_loaded_vmcss(void) loaded_vmcss_on_cpu_link) vmcs_clear(v->vmcs); } -#endif /* CONFIG_KEXEC_CORE */ static void __loaded_vmcs_clear (void *arg) {
@@ -8528,10 +8526,9 @@ static void __vmx_exit(void) { allow_smaller_maxphyaddr = false; -#ifdef CONFIG_KEXEC_CORE RCU_INIT_POINTER (crash_vmclear_loaded_vmcss,NULL );synchronize_rcu (); -#endif +vmx_cleanup_l1d_flush (); }
@@ -8580,10 +8577,9 @@ static int __init vmx_init(void)pi_init_cpu (cpu); } -#ifdef CONFIG_KEXEC_CORE rcu_assign_pointer (crash_vmclear_loaded_vmcss, crash_vmclear_local_loaded_vmcss); -#endif +vmx_check_vmcs12_offsets ();/*
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 2/16 x86/reboot: Expose VMCS crash hooks if and only if KVM_INTEL is enabled
In reply to Sean ChristophersonExpose the crash/reboot hooks used by KVM to do VMCLEAR+VMXOFF if and only if there's a potential in-tree user, KVM_INTEL.
--- arch/x86/include/asm/reboot.h | 2 ++ arch/x86/kernel/reboot.c | 4 ++++ 2 files changed, 6 insertions(+)
arch/x86/include/asm/reboot.h +2 -0
@@ -25,8 +25,10 @@ void __noreturn machine_real_restart(unsigned int type);#define MRR_BIOS 0#define MRR_APM 1 +#if IS_ENABLED (CONFIG_KVM_INTEL )typedef void crash_vmclear_fn (void );extern crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss; +#endif void cpu_emergency_disable_virtualization (void );typedef void (*nmi_shootdown_cb )(int ,struct pt_regs *);
arch/x86/kernel/reboot.c +4 -0
@@ -787,6 +787,7 @@ void machine_crash_shutdown(struct pt_regs *regs) }#endif +#if IS_ENABLED (CONFIG_KVM_INTEL )/* * This is used to VMCLEAR all VMCSs loaded on the * processor. And when loading kvm_intel module, the
@@ -807,6 +808,7 @@ static inline void cpu_crash_vmclear_loaded_vmcss(void)do_vmclear_operation (); rcu_read_unlock(); } +#endif /* This is the CPU performing the emergency shutdown work. */ int crashing_cpu =-1 ;
@@ -818,7 +820,9 @@ int crashing_cpu = -1;*/ void cpu_emergency_disable_virtualization (void ) { +#if IS_ENABLED (CONFIG_KVM_INTEL )cpu_crash_vmclear_loaded_vmcss (); +#endif cpu_emergency_vmxoff ();cpu_emergency_svm_disable ();
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 3/16 x86/reboot: Harden virtualization hooks for emergency reboot
In reply to Sean ChristophersonProvide dedicated helpers to (un)register virt hooks used during an emergency crash/reboot, and WARN if there is an attempt to overwrite the registered callback, or an attempt to do an unpaired unregister.
Opportunsitically use rcu_assign_pointer() instead of RCU_INIT_POINTER(), mainly so that the set/unset paths are more symmetrical, but also because any performance gains from using RCU_INIT_POINTER() are meaningless for this code.
--- arch/x86/include/asm/reboot.h | 5 +++-- arch/x86/kernel/reboot.c | 30 ++++++++++++++++++++++++------ arch/x86/kvm/vmx/vmx.c | 6 ++---- 3 files changed, 29 insertions(+), 12 deletions(-)
arch/x86/include/asm/reboot.h +3 -2
@@ -26,8 +26,9 @@ void __noreturn machine_real_restart(unsigned int type);#define MRR_APM 1#if IS_ENABLED (CONFIG_KVM_INTEL ) -typedef void crash_vmclear_fn (void ); -extern crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss; +typedef void (cpu_emergency_virt_cb )(void ); +void cpu_emergency_register_virt_callback (cpu_emergency_virt_cb *callback); +void cpu_emergency_unregister_virt_callback (cpu_emergency_virt_cb *callback);#endif void cpu_emergency_disable_virtualization (void );
arch/x86/kernel/reboot.c +24 -6
@@ -795,17 +795,35 @@ void machine_crash_shutdown(struct pt_regs *regs)* * protected by rcu. */ -crash_vmclear_fn __rcu *crash_vmclear_loaded_vmcss; -EXPORT_SYMBOL_GPL (crash_vmclear_loaded_vmcss); +static cpu_emergency_virt_cb __rcu *cpu_emergency_virt_callback; + +void cpu_emergency_register_virt_callback (cpu_emergency_virt_cb *callback) +{ +if (WARN_ON_ONCE (rcu_access_pointer (cpu_emergency_virt_callback))) +return ; + +rcu_assign_pointer (cpu_emergency_virt_callback, callback); +} +EXPORT_SYMBOL_GPL (cpu_emergency_register_virt_callback); + +void cpu_emergency_unregister_virt_callback (cpu_emergency_virt_cb *callback) +{ +if (WARN_ON_ONCE (rcu_access_pointer (cpu_emergency_virt_callback) != callback)) +return ; + +rcu_assign_pointer (cpu_emergency_virt_callback,NULL ); +synchronize_rcu (); +} +EXPORT_SYMBOL_GPL (cpu_emergency_unregister_virt_callback);static inline void cpu_crash_vmclear_loaded_vmcss (void ) { -crash_vmclear_fn *do_vmclear_operation =NULL ; +cpu_emergency_virt_cb *callback;rcu_read_lock (); - do_vmclear_operation =rcu_dereference (crash_vmclear_loaded_vmcss); -if (do_vmclear_operation) -do_vmclear_operation (); + callback =rcu_dereference (cpu_emergency_virt_callback); +if (callback) +callback ();rcu_read_unlock (); }#endif
arch/x86/kvm/vmx/vmx.c +2 -4
@@ -8526,8 +8526,7 @@ static void __vmx_exit(void) { allow_smaller_maxphyaddr = false; -RCU_INIT_POINTER (crash_vmclear_loaded_vmcss,NULL ); -synchronize_rcu (); +cpu_emergency_unregister_virt_callback (crash_vmclear_local_loaded_vmcss);vmx_cleanup_l1d_flush (); }
@@ -8577,8 +8576,7 @@ static int __init vmx_init(void)pi_init_cpu (cpu); } -rcu_assign_pointer (crash_vmclear_loaded_vmcss, - crash_vmclear_local_loaded_vmcss); +cpu_emergency_register_virt_callback (crash_vmclear_local_loaded_vmcss);vmx_check_vmcs12_offsets ();
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 4/16 x86/reboot: Assert that IRQs are disabled when turning off virtualization
In reply to Sean ChristophersonAssert that IRQs are disabled when turning off virtualization in an emergency. KVM enables hardware via on_each_cpu(), i.e. could re-enable hardware if a pending IPI were delivered after disabling virtualization.
--- arch/x86/kernel/reboot.c | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/kernel/reboot.c +2 -0
@@ -838,6 +838,8 @@ int crashing_cpu = -1;*/ void cpu_emergency_disable_virtualization (void ) { +lockdep_assert_irqs_disabled (); +#if IS_ENABLED (CONFIG_KVM_INTEL )cpu_crash_vmclear_loaded_vmcss ();#endif
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 5/16 x86/reboot: KVM: Handle VMXOFF in KVM's reboot callback
In reply to Sean ChristophersonUse KVM VMX's reboot/crash callback to do VMXOFF in an emergency instead of manually and blindly doing VMXOFF. There's no need to attempt VMXOFF if KVM (or some other out-of-tree hypervisor) isn't loaded/active, i.e. if the CPU can't possibly be post-VMXON.
--- arch/x86/include/asm/virtext.h | 10 ---------- arch/x86/kernel/reboot.c | 30 +++++++++--------------------- arch/x86/kvm/vmx/vmx.c | 8 +++++--- 3 files changed, 14 insertions(+), 34 deletions(-)
arch/x86/include/asm/virtext.h +0 -10
@@ -70,16 +70,6 @@ static inline void __cpu_emergency_vmxoff(void)cpu_vmxoff (); } -/** Disable VMX if it is supported and enabled on the current CPU -*/ -static inline void cpu_emergency_vmxoff (void ) -{ -if (cpu_has_vmx ()) -__cpu_emergency_vmxoff (); -} - - -/* * SVM functions:
arch/x86/kernel/reboot.c +9 -21
@@ -788,13 +788,7 @@ void machine_crash_shutdown(struct pt_regs *regs)#endif #if IS_ENABLED (CONFIG_KVM_INTEL ) -/* -* This is used to VMCLEAR all VMCSs loaded on the -* processor. And when loading kvm_intel module, the -* callback function pointer will be assigned. -* -* protected by rcu. -*/ +/* RCU-protected callback to disable virtualization prior to reboot. */ static cpu_emergency_virt_cb __rcu *cpu_emergency_virt_callback;void cpu_emergency_register_virt_callback (cpu_emergency_virt_cb *callback)
@@ -815,17 +809,6 @@ void cpu_emergency_unregister_virt_callback(cpu_emergency_virt_cb *callback) synchronize_rcu(); }EXPORT_SYMBOL_GPL (cpu_emergency_unregister_virt_callback); - -static inline void cpu_crash_vmclear_loaded_vmcss (void ) -{ -cpu_emergency_virt_cb *callback; - -rcu_read_lock (); - callback =rcu_dereference (cpu_emergency_virt_callback); -if (callback) -callback (); -rcu_read_unlock (); -}#endif /* This is the CPU performing the emergency shutdown work. */
@@ -841,10 +824,15 @@ void cpu_emergency_disable_virtualization(void)lockdep_assert_irqs_disabled ();#if IS_ENABLED (CONFIG_KVM_INTEL ) -cpu_crash_vmclear_loaded_vmcss (); -#endif +cpu_emergency_virt_cb *callback; -cpu_emergency_vmxoff (); +rcu_read_lock (); + callback =rcu_dereference (cpu_emergency_virt_callback); +if (callback) +callback (); +rcu_read_unlock (); +#endif +/* KVM_AMD doesn't yet utilize the common callback. */ cpu_emergency_svm_disable (); }
arch/x86/kvm/vmx/vmx.c +5 -3
@@ -743,7 +743,7 @@ static int vmx_set_guest_uret_msr(struct vcpu_vmx *vmx,return ret; } -static void crash_vmclear_local_loaded_vmcss (void ) +static void vmx_emergency_disable (void ) {int cpu =raw_smp_processor_id ();struct loaded_vmcs *v;
@@ -751,6 +751,8 @@ static void crash_vmclear_local_loaded_vmcss(void)list_for_each_entry (v, &per_cpu (loaded_vmcss_on_cpu, cpu), loaded_vmcss_on_cpu_link)vmcs_clear (v->vmcs); + +__cpu_emergency_vmxoff (); }static void __loaded_vmcs_clear (void *arg)
@@ -8526,7 +8528,7 @@ static void __vmx_exit(void) { allow_smaller_maxphyaddr = false; -cpu_emergency_unregister_virt_callback (crash_vmclear_local_loaded_vmcss); +cpu_emergency_unregister_virt_callback (vmx_emergency_disable);vmx_cleanup_l1d_flush (); }
@@ -8576,7 +8578,7 @@ static int __init vmx_init(void)pi_init_cpu (cpu); } -cpu_emergency_register_virt_callback (crash_vmclear_local_loaded_vmcss); +cpu_emergency_register_virt_callback (vmx_emergency_disable);vmx_check_vmcs12_offsets ();
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 6/16 x86/reboot: KVM: Disable SVM during reboot via virt/KVM reboot callback
In reply to Sean ChristophersonUse the virt callback to disable SVM (and set GIF=1) during an emergency instead of blindly attempting to disable SVM. Like the VMX case, if KVM (or an out-of-tree hypervisor) isn't loaded/active, SVM can't be in use.
--- arch/x86/include/asm/reboot.h | 2 +- arch/x86/include/asm/virtext.h | 8 -------- arch/x86/kernel/reboot.c | 6 ++---- arch/x86/kvm/svm/svm.c | 19 +++++++++++++++++-- 4 files changed, 20 insertions(+), 15 deletions(-)
arch/x86/include/asm/reboot.h +1 -1
@@ -25,7 +25,7 @@ void __noreturn machine_real_restart(unsigned int type);#define MRR_BIOS 0#define MRR_APM 1 -#if IS_ENABLED (CONFIG_KVM_INTEL ) +#if IS_ENABLED (CONFIG_KVM_INTEL ) ||IS_ENABLED (CONFIG_KVM_AMD )typedef void (cpu_emergency_virt_cb )(void );void cpu_emergency_register_virt_callback (cpu_emergency_virt_cb *callback);void cpu_emergency_unregister_virt_callback (cpu_emergency_virt_cb *callback);
arch/x86/include/asm/virtext.h +0 -8
@@ -130,12 +130,4 @@ static inline void cpu_svm_disable(void) } } -/** Makes sure SVM is disabled, if it is supported on the CPU -*/ -static inline void cpu_emergency_svm_disable (void ) -{ -if (cpu_has_svm (NULL )) -cpu_svm_disable (); -} -#endif /* _ASM_X86_VIRTEX_H */
arch/x86/kernel/reboot.c +2 -4
@@ -787,7 +787,7 @@ void machine_crash_shutdown(struct pt_regs *regs) }#endif -#if IS_ENABLED (CONFIG_KVM_INTEL ) +#if IS_ENABLED (CONFIG_KVM_INTEL ) ||IS_ENABLED (CONFIG_KVM_AMD )/* RCU-protected callback to disable virtualization prior to reboot. */ static cpu_emergency_virt_cb __rcu *cpu_emergency_virt_callback;
@@ -823,7 +823,7 @@ void cpu_emergency_disable_virtualization(void) {lockdep_assert_irqs_disabled (); -#if IS_ENABLED (CONFIG_KVM_INTEL ) +#if IS_ENABLED (CONFIG_KVM_INTEL ) ||IS_ENABLED (CONFIG_KVM_AMD )cpu_emergency_virt_cb *callback;rcu_read_lock ();
@@ -832,8 +832,6 @@ void cpu_emergency_disable_virtualization(void)callback ();rcu_read_unlock ();#endif -/* KVM_AMD doesn't yet utilize the common callback. */ -cpu_emergency_svm_disable (); }#if defined(CONFIG_SMP )
arch/x86/kvm/svm/svm.c +17 -2
@@ -38,6 +38,7 @@#include <asm/spec-ctrl.h> #include <asm/cpu_device_id.h> #include <asm/traps.h> +#include <asm/reboot.h> #include <asm/fpu/api.h> #include <asm/virtext.h>
@@ -565,6 +566,11 @@ void __svm_write_tsc_multiplier(u64 multiplier)preempt_enable (); } +static void svm_emergency_disable (void ) +{ +cpu_svm_disable (); +} +static void svm_hardware_disable (void ) {/* Make sure we clean up behind us */
@@ -5084,6 +5090,13 @@ static struct kvm_x86_init_ops svm_init_ops __initdata = { .pmu_ops = &amd_pmu_ops, }; +static void __svm_exit (void ) +{ +kvm_x86_vendor_exit (); + +cpu_emergency_unregister_virt_callback (svm_emergency_disable); +} +static int __init svm_init (void ) {int r;
@@ -5097,6 +5110,8 @@ static int __init svm_init(void)if (r)return r; +cpu_emergency_register_virt_callback (svm_emergency_disable); +/* * Common KVM initialization _must_ come last, after this, /dev/kvm is * exposed to userspace!
@@ -5109,14 +5124,14 @@ static int __init svm_init(void)return 0 ; err_kvm_init: -kvm_x86_vendor_exit (); +__svm_exit ();return r; } static void __exit svm_exit(void) {kvm_exit (); -kvm_x86_vendor_exit (); +__svm_exit (); }module_init (svm_init)
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 7/16 x86/reboot: Hoist "disable virt" helpers above "emergency reboot" path
In reply to Sean ChristophersonMove the various "disable virtualization" helpers above the emergency reboot path so that emergency_reboot_disable_virtualization() can be stubbed out in a future patch if neither KVM_INTEL nor KVM_AMD is enabled, i.e. if there is no in-tree user of CPU virtualization.
No functional change intended.
--- arch/x86/include/asm/reboot.h | 4 +- arch/x86/kernel/reboot.c | 86 +++++++++++++++++------------------ 2 files changed, 45 insertions(+), 45 deletions(-)
arch/x86/include/asm/reboot.h +3 -1
@@ -29,8 +29,10 @@ void __noreturn machine_real_restart(unsigned int type);typedef void (cpu_emergency_virt_cb )(void );void cpu_emergency_register_virt_callback (cpu_emergency_virt_cb *callback);void cpu_emergency_unregister_virt_callback (cpu_emergency_virt_cb *callback); -#endif void cpu_emergency_disable_virtualization (void ); +#else +static inline void cpu_emergency_disable_virtualization (void ) {} +#endif typedef void (*nmi_shootdown_cb )(int ,struct pt_regs *);void nmi_panic_self_stop (struct pt_regs *regs);
arch/x86/kernel/reboot.c +42 -44
101 lines not on this page · raw message
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 8/16 x86/reboot: Disable virtualization during reboot iff callback is registered
In reply to Sean ChristophersonAttempt to disable virtualization during an emergency reboot if and only if there is a registered virt callback, i.e. iff a hypervisor (KVM) is active. If there's no active hypervisor, then the CPU can't be operating with VMX or SVM enabled (barring an egregious bug).
Note, IRQs are disabled, which prevents KVM from coming along and enabling virtualization after the fact.
--- arch/x86/kernel/reboot.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
arch/x86/kernel/reboot.c +4 -3
@@ -22,7 +22,6 @@#include <asm/reboot_fixups.h> #include <asm/reboot.h> #include <asm/pci_x86.h> -#include <asm/virtext.h> #include <asm/cpu.h> #include <asm/nmi.h> #include <asm/smp.h>
@@ -570,7 +569,6 @@ void cpu_emergency_disable_virtualization(void)callback ();rcu_read_unlock (); } -#endif /* CONFIG_KVM_INTEL || CONFIG_KVM_AMD */ static void emergency_reboot_disable_virtualization (void ) {
@@ -587,7 +585,7 @@ static void emergency_reboot_disable_virtualization(void)* Do the NMI shootdown even if virtualization is off on _this_ CPU, as * other CPUs may have virtualization enabled. */ -if (cpu_has_vmx () ||cpu_has_svm (NULL )) { +if (rcu_access_pointer (cpu_emergency_virt_callback)) {/* Safely force _this_ CPU out of VMX/SVM operation. */ cpu_emergency_disable_virtualization ();
@@ -595,6 +593,9 @@ static void emergency_reboot_disable_virtualization(void) nmi_shootdown_cpus_on_restart(); } } +#else +static void emergency_reboot_disable_virtualization (void ) { } +#endif /* CONFIG_KVM_INTEL || CONFIG_KVM_AMD */ void __attribute__((weak))mach_reboot_fixups (void )
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 9/16 x86/virt: KVM: Open code cpu_has_vmx() in KVM VMX
In reply to Sean ChristophersonFold the raw CPUID check for VMX into kvm_is_vmx_supported(), its sole user. Keep the check even though KVM also checks X86_FEATURE_VMX, as the intent is to provide a unique error message if VMX is unsupported by hardware, whereas X86_FEATURE_VMX may be clear due to firmware and/or kernel actions.
No functional change intended.
--- arch/x86/include/asm/virtext.h | 10 ---------- arch/x86/kvm/vmx/vmx.c | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-)
arch/x86/include/asm/virtext.h +0 -10
@@ -22,14 +22,6 @@/* * VMX functions: */ - -static inline int cpu_has_vmx (void ) -{ -unsigned long ecx =cpuid_ecx (1 ); -return test_bit (5 , &ecx);/* CPUID.1:ECX.VMX[bit 5] -> VT */ -} - -/** * cpu_vmxoff() - Disable VMX on the current CPU *
@@ -61,8 +53,6 @@ static inline int cpu_vmx_enabled(void) }/** Disable VMX if it is enabled on the current CPU -* -* You shouldn't call this if cpu_has_vmx() returns 0. */ static inline void __cpu_emergency_vmxoff (void ) {
arch/x86/kvm/vmx/vmx.c +1 -1
@@ -2713,7 +2713,7 @@ static bool kvm_is_vmx_supported(void) {int cpu =raw_smp_processor_id (); -if (!cpu_has_vmx ()) { +if (!(cpuid_ecx (1 ) &feature_bit (VMX ))) {pr_err ("VMX not supported by CPU %d\n" , cpu);return false; }
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 10/16 x86/virt: KVM: Move VMXOFF helpers into KVM VMX
In reply to Sean ChristophersonNow that VMX is disabled in emergencies via the virt callbacks, move the VMXOFF helpers into KVM, the only remaining user.
No functional change intended.
--- arch/x86/include/asm/virtext.h | 42 ---------------------------------- arch/x86/kvm/vmx/vmx.c | 29 ++++++++++++++++++++--- 2 files changed, 26 insertions(+), 45 deletions(-)
arch/x86/include/asm/virtext.h +0 -42
@@ -19,48 +19,6 @@#include <asm/svm.h> #include <asm/tlbflush.h> -/* -* VMX functions: -*/ -/** -* cpu_vmxoff() - Disable VMX on the current CPU -* -* Disable VMX and clear CR4.VMXE (even if VMXOFF faults) -* -* Note, VMXOFF causes a #UD if the CPU is !post-VMXON, but it's impossible to -* atomically track post-VMXON state, e.g. this may be called in NMI context. -* Eat all faults as all other faults on VMXOFF faults are mode related, i.e. -* faults are guaranteed to be due to the !post-VMXON check unless the CPU is -* magically in RM, VM86, compat mode, or at CPL>0. -*/ -static inline int cpu_vmxoff (void ) -{ - asm_volatile_goto("1: vmxoff\n\t" - _ASM_EXTABLE(1b, %l[fault]) - ::: "cc", "memory" : fault); - - cr4_clear_bits(X86_CR4_VMXE); -return 0 ; - -fault: -cr4_clear_bits (X86_CR4_VMXE ); -return -EIO ; -} - -static inline int cpu_vmx_enabled (void ) -{ -return __read_cr4 () &X86_CR4_VMXE ; -} - -/** Disable VMX if it is enabled on the current CPU -*/ -static inline void __cpu_emergency_vmxoff (void ) -{ -if (cpu_vmx_enabled ()) -cpu_vmxoff (); -} - -/* * SVM functions: */
arch/x86/kvm/vmx/vmx.c +26 -3
@@ -47,7 +47,6 @@#include <asm/mshyperv.h> #include <asm/mwait.h> #include <asm/spec-ctrl.h> -#include <asm/virtext.h> #include <asm/vmx.h> #include "capabilities.h"
@@ -743,6 +742,29 @@ static int vmx_set_guest_uret_msr(struct vcpu_vmx *vmx,return ret; } +/* +* Disable VMX and clear CR4.VMXE (even if VMXOFF faults) +* +* Note, VMXOFF causes a #UD if the CPU is !post-VMXON, but it's impossible to +* atomically track post-VMXON state, e.g. this may be called in NMI context. +* Eat all faults as all other faults on VMXOFF faults are mode related, i.e. +* faults are guaranteed to be due to the !post-VMXON check unless the CPU is +* magically in RM, VM86, compat mode, or at CPL>0. +*/ +static int kvm_cpu_vmxoff (void ) +{ + asm_volatile_goto("1: vmxoff\n\t" + _ASM_EXTABLE(1b, %l[fault]) + ::: "cc", "memory" : fault); + + cr4_clear_bits(X86_CR4_VMXE); +return 0 ; + +fault: +cr4_clear_bits (X86_CR4_VMXE ); +return -EIO ; +} +static void vmx_emergency_disable (void ) {int cpu =raw_smp_processor_id ();
@@ -752,7 +774,8 @@ static void vmx_emergency_disable(void) loaded_vmcss_on_cpu_link) vmcs_clear(v->vmcs); -__cpu_emergency_vmxoff (); +if (__read_cr4 () &X86_CR4_VMXE ) +kvm_cpu_vmxoff (); }static void __loaded_vmcs_clear (void *arg)
@@ -2814,7 +2837,7 @@ static void vmx_hardware_disable(void) {vmclear_local_loaded_vmcss (); -if (cpu_vmxoff ()) +if (kvm_cpu_vmxoff ())kvm_spurious_fault ();hv_reset_evmcs ();
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 11/16 KVM: SVM: Make KVM_AMD depend on CPU_SUP_AMD or CPU_SUP_HYGON
In reply to Sean ChristophersonMake building KVM SVM support depend on support for AMD or Hygon. KVM already effectively restricts SVM support to AMD and Hygon by virtue of the vendor string checks in cpu_has_svm(), and KVM VMX supports depends on one of its three known vendors (Intel, Centaur, or Zhaoxin).
Add the CPU_SUP_HYGON clause even though CPU_SUP_HYGON selects CPU_SUP_AMD to document that KVM SVM support isn't just for AMD CPUs, and to prevent breakage should Hygon support ever become a standalone thing.
--- arch/x86/kvm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/Kconfig +1 -1
@@ -102,7 +102,7 @@ config X86_SGX_KVM config KVM_AMD tristate "KVM for AMD processors support" - depends on KVM + depends on KVM && (CPU_SUP_AMD || CPU_SUP_HYGON) help Provides support for KVM on AMD processors equipped with the AMD-V (SVM) extensions.
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 12/16 x86/virt: Drop unnecessary check on extended CPUID level in cpu_has_svm()
In reply to Sean ChristophersonDrop the explicit check on the extended CPUID level in cpu_has_svm(), the kernel's cached CPUID info will leave the entire SVM leaf unset if said leaf is not supported by hardware. Prior to using cached information, the check was needed to avoid false positives due to Intel's rather crazy CPUID behavior of returning the values of the maximum supported leaf if the specified leaf is unsupported.
--- arch/x86/include/asm/virtext.h | 6 ------ 1 file changed, 6 deletions(-)
arch/x86/include/asm/virtext.h +0 -6
@@ -39,12 +39,6 @@ static inline int cpu_has_svm(const char **msg)return 0 ; } -if (boot_cpu_data.extended_cpuid_level <SVM_CPUID_FUNC ) { -if (msg) - *msg ="can't execute cpuid_8000000a" ; -return 0 ; - } -if (!boot_cpu_has (X86_FEATURE_SVM )) {if (msg) *msg ="svm not available" ;
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 13/16 x86/virt: KVM: Open code cpu_has_svm() into kvm_is_svm_supported()
In reply to Sean ChristophersonFold the guts of cpu_has_svm() into kvm_is_svm_supported(), its sole remaining user.
No functional change intended.
--- arch/x86/include/asm/virtext.h | 28 ---------------------------- arch/x86/kvm/svm/svm.c | 11 ++++++++--- 2 files changed, 8 insertions(+), 31 deletions(-)
arch/x86/include/asm/virtext.h +0 -28
@@ -22,35 +22,7 @@/* * SVM functions: */ - -/** Check if the CPU has SVM support -* -* You can use the 'msg' arg to get a message describing the problem, -* if the function returns zero. Simply pass NULL if you are not interested -* on the messages; gcc should take care of not generating code for -* the messages on this case. -*/ -static inline int cpu_has_svm (const char **msg) -{ -if (boot_cpu_data.x86_vendor !=X86_VENDOR_AMD && - boot_cpu_data.x86_vendor !=X86_VENDOR_HYGON ) { -if (msg) - *msg ="not amd or hygon" ; -return 0 ; - } - -if (!boot_cpu_has (X86_FEATURE_SVM )) { -if (msg) - *msg ="svm not available" ; -return 0 ; - } -return 1 ; -} - -/** Disable SVM on the current CPU -* -* You should call this only if cpu_has_svm() returned true. */ static inline void cpu_svm_disable (void ) {
arch/x86/kvm/svm/svm.c +8 -3
@@ -523,11 +523,16 @@ static void svm_init_osvw(struct kvm_vcpu *vcpu)static bool kvm_is_svm_supported (void ) {int cpu =raw_smp_processor_id (); -const char *msg;u64 vm_cr; -if (!cpu_has_svm (&msg)) { -pr_err ("SVM not supported by CPU %d, %s\n" , cpu, msg); +if (boot_cpu_data.x86_vendor !=X86_VENDOR_AMD && + boot_cpu_data.x86_vendor !=X86_VENDOR_HYGON ) { +pr_err ("CPU %d isn't AMD or Hygon\n" , cpu); +return false; + } + +if (!boot_cpu_has (X86_FEATURE_SVM )) { +pr_err ("SVM not supported by CPU %d\n" , cpu);return false; }
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 14/16 x86/virt: KVM: Move "disable SVM" helper into KVM SVM
In reply to Sean ChristophersonMove cpu_svm_disable() into KVM proper now that all hardware virtualization management is routed through KVM. Remove the now-empty virtext.h.
No functional change intended.
--- arch/x86/include/asm/virtext.h | 47 ---------------------------------- arch/x86/kvm/svm/svm.c | 25 +++++++++++++++--- 2 files changed, 22 insertions(+), 50 deletions(-) delete mode 100644 arch/x86/include/asm/virtext.h
arch/x86/include/asm/virtext.h deleted +0 -47
@@ -1,47 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* CPU virtualization extensions handling -* -* This should carry the code for handling CPU virtualization extensions -* that needs to live in the kernel core. -* -* Author: Eduardo Habkost <[email protected]> -* -* Copyright (C) 2008, Red Hat Inc. -* -* Contains code from KVM, Copyright (C) 2006 Qumranet, Inc. -*/ -#ifndef _ASM_X86_VIRTEX_H -#define _ASM_X86_VIRTEX_H - -#include <asm/processor.h> - -#include <asm/vmx.h> -#include <asm/svm.h> -#include <asm/tlbflush.h> - -/* -* SVM functions: -*/ -/** Disable SVM on the current CPU -*/ -static inline void cpu_svm_disable (void ) -{ -uint64_t efer; - -wrmsrl (MSR_VM_HSAVE_PA ,0 ); -rdmsrl (MSR_EFER , efer); -if (efer &EFER_SVME ) { -/* -* Force GIF=1 prior to disabling SVM, e.g. to ensure INIT and -* NMI aren't blocked. Eat faults on STGI, as it #UDs if SVM -* isn't enabled and SVM can be disabled by an NMI callback. -*/ - asm_volatile_goto("1: stgi\n\t" - _ASM_EXTABLE(1b, %l[fault]) - ::: "memory" : fault); -fault: - wrmsrl(MSR_EFER, efer & ~EFER_SVME); - } -} - -#endif /* _ASM_X86_VIRTEX_H */
arch/x86/kvm/svm/svm.c +22 -3
@@ -41,7 +41,6 @@#include <asm/reboot.h> #include <asm/fpu/api.h> -#include <asm/virtext.h> #include "trace.h" #include "svm.h"
@@ -571,9 +570,29 @@ void __svm_write_tsc_multiplier(u64 multiplier)preempt_enable (); } +static inline void kvm_cpu_svm_disable (void ) +{ +uint64_t efer; + +wrmsrl (MSR_VM_HSAVE_PA ,0 ); +rdmsrl (MSR_EFER , efer); +if (efer &EFER_SVME ) { +/* +* Force GIF=1 prior to disabling SVM, e.g. to ensure INIT and +* NMI aren't blocked. Eat faults on STGI, as it #UDs if SVM +* isn't enabled and SVM can be disabled by an NMI callback. +*/ + asm_volatile_goto("1: stgi\n\t" + _ASM_EXTABLE(1b, %l[fault]) + ::: "memory" : fault); +fault: + wrmsrl(MSR_EFER, efer & ~EFER_SVME); + } +} +static void svm_emergency_disable (void ) { -cpu_svm_disable (); +kvm_cpu_svm_disable (); }static void svm_hardware_disable (void )
@@ -582,7 +601,7 @@ static void svm_hardware_disable(void)if (tsc_scaling)__svm_write_tsc_multiplier (SVM_TSC_RATIO_DEFAULT ); -cpu_svm_disable (); +kvm_cpu_svm_disable ();amd_pmu_disable_virt (); }
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 15/16 KVM: x86: Force kvm_rebooting=true during emergency reboot/crash
In reply to Sean ChristophersonSet kvm_rebooting when virtualization is disabled in an emergency so that KVM eats faults on virtualization instructions even if kvm_reboot() isn't reached.
--- arch/x86/kvm/svm/svm.c | 2 ++ arch/x86/kvm/vmx/vmx.c | 2 ++ 2 files changed, 4 insertions(+)
arch/x86/kvm/svm/svm.c +2 -0
@@ -592,6 +592,8 @@ static inline void kvm_cpu_svm_disable(void)static void svm_emergency_disable (void ) { + kvm_rebooting = true; +kvm_cpu_svm_disable (); }
arch/x86/kvm/vmx/vmx.c +2 -0
@@ -770,6 +770,8 @@ static void vmx_emergency_disable(void)int cpu =raw_smp_processor_id ();struct loaded_vmcs *v; + kvm_rebooting = true; +list_for_each_entry (v, &per_cpu (loaded_vmcss_on_cpu, cpu), loaded_vmcss_on_cpu_link)vmcs_clear (v->vmcs);
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Sean Christopherson
maintainerPATCH 16/16 KVM: SVM: Use "standard" stgi() helper when disabling SVM
In reply to Sean ChristophersonNow that kvm_rebooting is guaranteed to be true prior to disabling SVM in an emergency, use the existing stgi() helper instead of open coding STGI. In effect, eat faults on STGI if and only if kvm_rebooting==true.
--- arch/x86/kvm/svm/svm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
arch/x86/kvm/svm/svm.c +2 -6
@@ -579,13 +579,9 @@ static inline void kvm_cpu_svm_disable(void)if (efer &EFER_SVME ) {/* * Force GIF=1 prior to disabling SVM, e.g. to ensure INIT and -* NMI aren't blocked. Eat faults on STGI, as it #UDs if SVM -* isn't enabled and SVM can be disabled by an NMI callback. +* NMI aren't blocked. */ - asm_volatile_goto("1: stgi\n\t" - _ASM_EXTABLE(1b, %l[fault]) - ::: "memory" : fault); -fault: +stgi ();wrmsrl (MSR_EFER , efer & ~EFER_SVME ); } }
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog