Skip to contentSkip to conversation

mips/pci: use devm_platform_ioremap_resource()

PATCH Applied [email protected] 3 participants 3 messages Dec 2, 2022 MIPS

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH v2 1/1 mips/pci: use devm_platform_ioremap_resource()

From: zhang songyi <[email protected]>

Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately

Signed-off-by zhang songyi <[email protected]>
---
 arch/mips/pci/pci-rt3883.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/mips/pci/pci-rt3883.c +1 -3
index e07ae098bdd8..d59888aaed81 100644
@@ -404,7 +404,6 @@ static int rt3883_pci_probe(struct platform_device *pdev)
 	struct rt3883_pci_controller *rpc;
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
-	struct resource *res;
 	struct device_node *child;
 	u32 val;
 	int err;

@@ -414,8 +413,7 @@ static int rt3883_pci_probe(struct platform_device *pdev)
 	if (!rpc)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	rpc->base = devm_ioremap_resource(dev, res);
+	rpc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(rpc->base))
 		return PTR_ERR(rpc->base);
Signature · 1 line
2.15.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · On 2/12/22 03:28, [email protected] wrote:

From: zhang songyi <[email protected]>

Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately

Signed-off-by zhang songyi <[email protected]>
---
  arch/mips/pci/pci-rt3883.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
maintainer Applied
#2 lore raw
In reply to [email protected]
Quoted 10 lines · On Fri, Dec 02, 2022 at 10:28:15AM +0800, [email protected] wrote:

From: zhang songyi <[email protected]>

Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately

Signed-off-by zhang songyi <[email protected]>
---
 arch/mips/pci/pci-rt3883.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]