wifi: ath10k: fix QCOM_SMEM dependency
PATCH 1/1 wifi: ath10k: fix QCOM_SMEM dependency
From: Kalle Valo <[email protected]>
Nathan noticed that when HWSPINLOCK is disabled there's a Kconfig warning:
WARNING: unmet direct dependencies detected for QCOM_SMEM
Depends on [n]: (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && HWSPINLOCK [=n]
Selected by [m]:
- ATH10K_SNOC [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH10K [=m] && (ARCH_QCOM [=y] || COMPILE_TEST [=n])
The problem here is that QCOM_SMEM depends on HWSPINLOCK so we cannot select QCOM_SMEM and instead we neeed to use 'depends on'.
--- drivers/net/wireless/ath/ath10k/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/Kconfig +1 -1
@@ -44,7 +44,7 @@ config ATH10K_SNOC tristate "Qualcomm ath10k SNOC support" depends on ATH10K depends on ARCH_QCOM || COMPILE_TEST - select QCOM_SMEM + depends on QCOM_SMEM select QCOM_SCM select QCOM_QMI_HELPERS help
base-commit: e9ab0b2e680b069437f54bf4076310f636af05e6
Signature · 1 line
2.30.2
Quoted 9 lines · Kalle Valo
From: Kalle Valo <[email protected]>
Nathan noticed that when HWSPINLOCK is disabled there's a
Kconfigwarning:WARNING: unmet direct dependencies detected for
QCOM_SMEM
Depends on [n]: (ARCH_QCOM[=y] ||COMPILE_TEST[=n]) && HWSPINLOCK [=n]
Selected by [m]:
-ATH10K_SNOC[=m] && NETDEVICES [=y] && WLAN [=y] &&WLAN_VENDOR_ATH[=y] && ATH10K [=m] && (ARCH_QCOM[=y] ||COMPILE_TEST[=n])
Quoted 7 lines
The problem here is that
QCOM_SMEMdepends on HWSPINLOCK so we cannot selectQCOM_SMEMand instead we neeed to use 'depends on'.Reported-by Nathan Chancellor <[email protected]>Fixes 4d79f6f34bbb ("wifi: ath10k: Store WLAN firmware version in SMEM image table")Signed-off-by Kalle Valo <[email protected]>
Patch applied to wireless-next.git, thanks.
d03407183d97 wifi: ath10k: fix QCOM_SMEM dependency
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches