acpi: allow usage of acpi_tad without PRW
PATCH 1/1 acpi: allow usage of acpi_tad without PRW
From: "Bart Groeneveld | GPX Solutions B.V." <[email protected]>
Not all tads have the PRW capability, which is totally OK, according to the ACPI spec [1]:
Quoted 2 lines
_PRWis only required for devices that have the ability to wake the system from a system sleeping state.
This partially solves [2] and [3].
[1]: https://uefi.org/sites/default/files/resources/ACPI_Spec_6_4_Jan22.pdf
[2]: https://bugzilla.kernel.org/show_bug.cgi?id=212313
[3]: https://github.com/linux-surface/linux-surface/issues/415
--- drivers/acpi/acpi_tad.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/acpi/acpi_tad.c +0 -5
@@ -604,11 +604,6 @@ static int acpi_tad_probe(struct platform_device *pdev)return -ENODEV ; } -if (!acpi_has_method (handle,"_PRW" )) { -dev_info (dev,"Missing _PRW\n" ); -return -ENODEV ; - } - dd =devm_kzalloc (dev,sizeof (*dd),GFP_KERNEL );if (!dd)return -ENOMEM ;
Signature · 1 line
2.38.1
Rafael J. Wysocki
maintainerQuoted 8 lines · Bart Groeneveld | GPX Solutions B.V
From: "Bart Groeneveld | GPX Solutions B.V." <[email protected]>
Not all tads have the PRW capability, which is totally OK, according to the ACPI spec [1]:
Quoted 2 lines
_PRWis only required for devices that have the ability to wake the system from a system sleeping state.
No, the ACPI TAD definition in Section 9.17 (ACPI 6.5) specifically requires _PRW to be present unless the system is hardware-reduced.
Anyway, the RTC part can still be supported without _PRW, but then the wakeup-related attributes should not be present in such cases.
Quoted 16 lines
This partially solves [2] and [3].
[1]: https://uefi.org/sites/default/files/resources/ACPI_Spec_6_4_Jan22.pdf
[2]: https://bugzilla.kernel.org/show_bug.cgi?id=212313
[3]: https://github.com/linux-surface/linux-surface/issues/415Signed-off-by Bart Groeneveld | GPX Solutions B.V. <[email protected]>--- drivers/acpi/acpi_tad.c | 5 ----- 1 file changed, 5 deletions(-)drivers/acpi/acpi_tad.c +0
-0
drivers/acpi/acpi_tad.c static int acpi_tad_probe(struct platform_device *pdev) · line 611
Quoted 8 lines
drivers/acpi/acpi_tad.c +0
-5@@ -604,11 +604,6 @@ static int acpi_tad_probe(struct platform_device *pdev)return -ENODEV ; } -if (!acpi_has_method (handle,"_PRW" )) { -dev_info (dev,"Missing _PRW\n" ); -return -ENODEV ; - } -
This may be sufficient for the RTC part alone to work, but making the wakeup-related attributes available doesn't really make sense in the _PRW absent case, so they all should be made optional.
Quoted 4 lines
drivers/acpi/acpi_tad.c +0
-1dd =devm_kzalloc (dev,sizeof (*dd),GFP_KERNEL );if (!dd)return -ENOMEM ; --
PATCH v2 1/1 acpi: allow usage of acpi_tad on HW-reduced platforms
From: "Bart Groeneveld | GPX Solutions B.V." <[email protected]>
The specification [1] allows so-called HW-reduced platforms, which do not implement everything, especially the wakeup related stuff.
In that case, it is still usable as a RTC. This is helpful for [2] and [3], which is about a device with no other working RTC, but it does have an HW-reduced TAD, which can be used as a RTC instead.
[1]: https://uefi.org/specs/ACPI/6.5/09_ACPI_Defined_Devices_and_Device_Specific_Objects.html#time-and-alarm-device
[2]: https://bugzilla.kernel.org/show_bug.cgi?id=212313
[3]: https://github.com/linux-surface/linux-surface/issues/415
--- drivers/acpi/acpi_tad.c | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-)
drivers/acpi/acpi_tad.c +24 -11
@@ -432,6 +432,14 @@ static ssize_t caps_show(struct device *dev, struct device_attribute *attr,static DEVICE_ATTR_RO (caps); +static struct attribute *acpi_tad_attrs[] = { + &dev_attr_caps.attr, +NULL , +}; +static const struct attribute_group acpi_tad_attr_group = { + .attrs = acpi_tad_attrs, +}; +static ssize_t ac_alarm_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t count) {
@@ -480,15 +488,14 @@ static ssize_t ac_status_show(struct device *dev, struct device_attribute *attr,static DEVICE_ATTR_RW (ac_status); -static struct attribute *acpi_tad_attrs[] = { - &dev_attr_caps.attr, +static struct attribute *acpi_tad_ac_attrs[] = { &dev_attr_ac_alarm.attr, &dev_attr_ac_policy.attr, &dev_attr_ac_status.attr,NULL , }; -static const struct attribute_group acpi_tad_attr_group = { - .attrs = acpi_tad_attrs, +static const struct attribute_group acpi_tad_ac_attr_group = { + .attrs = acpi_tad_ac_attrs, }; static ssize_t dc_alarm_store(struct device *dev, struct device_attribute *attr,
@@ -563,13 +570,18 @@ static int acpi_tad_remove(struct platform_device *pdev)pm_runtime_get_sync (dev); +if (dd->capabilities &ACPI_TAD_AC_WAKE ) +sysfs_remove_group (&dev->kobj, &acpi_tad_ac_attr_group); +if (dd->capabilities &ACPI_TAD_DC_WAKE )sysfs_remove_group (&dev->kobj, &acpi_tad_dc_attr_group);sysfs_remove_group (&dev->kobj, &acpi_tad_attr_group); -acpi_tad_disable_timer (dev,ACPI_TAD_AC_TIMER ); -acpi_tad_clear_status (dev,ACPI_TAD_AC_TIMER ); +if (dd->capabilities &ACPI_TAD_AC_WAKE ) { +acpi_tad_disable_timer (dev,ACPI_TAD_AC_TIMER ); +acpi_tad_clear_status (dev,ACPI_TAD_AC_TIMER ); + }if (dd->capabilities &ACPI_TAD_DC_WAKE ) {acpi_tad_disable_timer (dev,ACPI_TAD_DC_TIMER );acpi_tad_clear_status (dev,ACPI_TAD_DC_TIMER );
@@ -604,11 +616,6 @@ static int acpi_tad_probe(struct platform_device *pdev)return -ENODEV ; } -if (!acpi_has_method (handle,"_PRW" )) { -dev_info (dev,"Missing _PRW\n" ); -return -ENODEV ; - } - dd =devm_kzalloc (dev,sizeof (*dd),GFP_KERNEL );if (!dd)return -ENOMEM ;
@@ -637,6 +644,12 @@ static int acpi_tad_probe(struct platform_device *pdev)if (ret) goto fail; +if (caps &ACPI_TAD_AC_WAKE ) { + ret =sysfs_create_group (&dev->kobj, &acpi_tad_ac_attr_group); +if (ret) + goto fail; + } +if (caps &ACPI_TAD_DC_WAKE ) { ret =sysfs_create_group (&dev->kobj, &acpi_tad_dc_attr_group);if (ret)
Signature · 1 line
2.38.1