platform/chrome: use sysfs_emit() to instead of scnprintf()
Subsystems (2)
PATCH 1/1 platform/chrome: use sysfs_emit() to instead of scnprintf()
From: ye xingchen <[email protected]>
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
--- drivers/platform/chrome/cros_ec_lightbar.c | 14 ++++++-------- drivers/platform/chrome/cros_ec_sysfs.c | 4 ++-- drivers/platform/chrome/wilco_ec/sysfs.c | 3 +-- 3 files changed, 9 insertions(+), 12 deletions(-)
drivers/platform/chrome/cros_ec_lightbar.c +6 -8
@@ -34,7 +34,7 @@ static ssize_t interval_msec_show(struct device *dev, {unsigned long msec = lb_interval_jiffies *1000 /HZ ; -return scnprintf (buf,PAGE_SIZE ,"%lu\n" , msec); +return sysfs_emit (buf,"%lu\n" , msec); } static ssize_t interval_msec_store(struct device *dev,
@@ -169,7 +169,7 @@ static ssize_t version_show(struct device *dev,if (!get_lightbar_version (ec, &version, &flags))return -EIO ; -return scnprintf (buf,PAGE_SIZE ,"%d %d\n" , version, flags); +return sysfs_emit (buf,"%d %d\n" , version, flags); } static ssize_t brightness_store(struct device *dev,
@@ -302,17 +302,15 @@ static ssize_t sequence_show(struct device *dev, ret =cros_ec_cmd_xfer_status (ec->ec_dev, msg);if (ret <0 ) { - ret =scnprintf (buf,PAGE_SIZE ,"XFER / EC ERROR %d / %d\n" , - ret, msg->result); + ret =sysfs_emit (buf,"XFER / EC ERROR %d / %d\n" , ret, msg->result); goto exit; } resp = (struct ec_response_lightbar *)msg->data;if (resp->get_seq.num >=ARRAY_SIZE (seqname)) - ret =scnprintf (buf,PAGE_SIZE ,"%d\n" , resp->get_seq.num); + ret =sysfs_emit (buf,"%d\n" , resp->get_seq.num);else - ret =scnprintf (buf,PAGE_SIZE ,"%s\n" , - seqname[resp->get_seq.num]); + ret =sysfs_emit (buf,"%s\n" , seqname[resp->get_seq.num]); exit:kfree (msg);
@@ -483,7 +481,7 @@ static ssize_t userspace_control_show(struct device *dev,struct device_attribute *attr, char *buf) { - return scnprintf(buf, PAGE_SIZE, "%d\n", userspace_control); + return sysfs_emit(buf, "%d\n", userspace_control); } static ssize_t userspace_control_store(struct device *dev,
drivers/platform/chrome/cros_ec_sysfs.c +2 -2
@@ -227,7 +227,7 @@ static ssize_t flashinfo_show(struct device *dev, resp = (struct ec_response_flash_info *)msg->data; - ret = scnprintf(buf, PAGE_SIZE, + ret = sysfs_emit(buf, "FlashSize %d\nWriteSize %d\n" "EraseSize %d\nProtectSize %d\n", resp->flash_size, resp->write_block_size,
@@ -264,7 +264,7 @@ static ssize_t kb_wake_angle_show(struct device *dev, goto exit; resp = (struct ec_response_motion_sense *)msg->data; - ret =scnprintf (buf,PAGE_SIZE ,"%d\n" , resp->kb_wake_angle.ret); + ret =sysfs_emit (buf,"%d\n" , resp->kb_wake_angle.ret); exit:kfree (msg);return ret;
drivers/platform/chrome/wilco_ec/sysfs.c +1 -2
@@ -119,8 +119,7 @@ static ssize_t get_info(struct device *dev, char *buf, enum get_ec_info_op op)if (ret <0 )return ret; -return scnprintf (buf,PAGE_SIZE ,"%.*s\n" , (int )sizeof (resp.value), - (char *)&resp.value); +return sysfs_emit (buf,"%.*s\n" , (int )sizeof (resp.value), (char *)&resp.value); } static ssize_t version_show(struct device *dev, struct device_attribute *attr,
Signature · 1 line
2.25.1
This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:
Quoted 9 lines · On Fri, 2 Dec 2022 16:56:04 +0800 (CST) you wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.Signed-off-by ye xingchen <[email protected]>[...]
Here is the summary with links:
- platform/chrome: use sysfs_emit() to instead of scnprintf()
https://git.kernel.org/chrome-platform/c/7af6ee18ad6e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Tzung-Bi Shih
maintainerQuoted 7 lines · On Fri, Dec 02, 2022 at 04:56:04PM +0800, [email protected] wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.Signed-off-by ye xingchen <[email protected]>
Fixed the commit message a bit and queued the patch.
Also, I found a little more here: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/
This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:
Hello:
This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:
Quoted 9 lines · On Fri, 2 Dec 2022 16:56:04 +0800 (CST) you wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.Signed-off-by ye xingchen <[email protected]>[...]
Here is the summary with links:
- platform/chrome: use sysfs_emit() to instead of scnprintf()
https://git.kernel.org/chrome-platform/c/7af6ee18ad6e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html