iommu/vt-d: Fix buggy QAT device mask
Subsystems (2)
PATCH 1/1 iommu/vt-d: Fix buggy QAT device mask
Impacted QAT device IDs that need extra dtlb flush quirk is ranging from 0x4940 to 0x4943. After bitwise AND device ID with 0xfffc the result should be 0x4940 instead of 0x494c to identify these devices.
--- drivers/iommu/intel/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel/iommu.c +1 -1
@@ -1401,7 +1401,7 @@ static void domain_update_iotlb(struct dmar_domain *domain)* This quirk is exempted from risky_device() check because it applies only * to the built-in QAT devices and it doesn't grant additional privileges. */ -#define BUGGY_QAT_DEVID_MASK 0x494c +#define BUGGY_QAT_DEVID_MASK 0x4940static bool dev_needs_extra_dtlb_flush (struct pci_dev *pdev) {if (pdev->vendor !=PCI_VENDOR_ID_INTEL )
Signature · 1 line
2.25.1
Quoted 3 lines · Jacob Pan
Impacted QAT device IDs that need extra dtlb flush quirk is ranging from
0x4940to0x4943. After bitwise AND device ID with0xfffcthe result should be0x4940instead of0x494cto identify these devices.
Can you add the lore link for the original post here just for reference.
as a Link: tag, since this depends on the other patch.
Quoted 3 lines
Reported-by Raghunathan Srinivasan <[email protected]>Signed-off-by Jacob Pan <[email protected]>
Quoted 20 lines
--- drivers/iommu/intel/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iommu/intel/iommu.c +1
-1@@ -1401,7 +1401,7 @@ static void domain_update_iotlb(struct dmar_domain *domain)* This quirk is exempted from risky_device() check because it applies only * to the built-in QAT devices and it doesn't grant additional privileges. */ -#define BUGGY_QAT_DEVID_MASK 0x494c +#define BUGGY_QAT_DEVID_MASK 0x4940static bool dev_needs_extra_dtlb_flush (struct pci_dev *pdev) {if (pdev->vendor !=PCI_VENDOR_ID_INTEL )Signature · 1 line
2.25.1
Hi Ashok,
Quoted 8 lines · Ashok Raj
Quoted 3 lines · Jacob Pan
Impacted QAT device IDs that need extra dtlb flush quirk is ranging from
0x4940to0x4943. After bitwise AND device ID with0xfffcthe result should be0x4940instead of0x494cto identify these devices.Can you add the lore link for the original post here just for reference.
as a Link: tag, since this depends on the other patch.
yes, Looks like Baolu has already taken care of it.
Thank you both!
Jacob