RISC-V IPI Improvements
Subsystems (6)
v15 cover RISC-V IPI Improvements
This series aims to improve IPI support in Linux RISC-V in following ways:
1) Treat IPIs as normal per-CPU interrupts instead of having custom RISC-V specific hooks. This also makes Linux RISC-V IPI support aligned with other architectures.
2) Remote TLB flushes and icache flushes should prefer local IPIs instead of SBI calls whenever we have specialized hardware (such as RISC-V AIA IMSIC and RISC-V SWI) which allows S-mode software to directly inject IPIs without any assistance from M-mode runtime firmware.
These patches were originally part of the "Linux RISC-V ACLINT Support" series but this now a separate series so that it can be merged independently of the "Linux RISC-V ACLINT Support" series.
(Refer, https://lore.kernel.org/lkml/[email protected]/)
These patches are also a preparatory patches for the up-coming:
1) Linux RISC-V AIA support
2) Linux RISC-V SWI support
These patches can also be found in riscv_ipi_imp_v15 branch at:
https://github.com/avpatel/linux.git
Changes since v14:
- Minor fixes in commit description of PATCH3 (as suggested by tglx)
- Don't disable parent IPI when CPU goes offline for SBI IPI driver and CLINT driver in PATCH4.
- Include Apple AIC driver changes from Marc Z as PATCH9
Changes since v13:
- Included changes suggested by Marc Z in PATCH3
- Use chained handlers in PATCH4
- Added new PATCH8 to have empty irq_eoi() in RISC-V INTC driver. This avoids the unnecessary mask/unmask dance at time of handling interrupts.
Changes since v12:
- Rebased on Linux-6.1-rc7
- Bring-back the IPI optimization in ipi_mux_send_mask() for PATCH3
- Call ipi_mux_send() for one target CPU at a time in PATCH3
Changes since v11:
- Removed ipi_mux_pre/post_handle() callbacks in PATCH3
- Removed sturct ipi_mux_ops in PATCH3
- Removed parent_virq and data pointer from everywhere in PATCH3
- Removed struct ipi_mux_control in PATCH3
- Improved function signature of ipi_mux_send() callback in PATCH3
- Used unsigned type with atomic operation in PATCH3
Changes since v10:
- Rebased on Linux-6.1-rc5
- Drop the "!(pending & ibit)" check in ipi_mux_send_mask() of PATCH3
- Disable local interrupts in ipi_mux_send_mask() of PATCH3 because we can be preempted while using a per-CPU temporary variable.
Changes since v9:
- Rebased on Linux-6.1-rc3
- Updated header comment block of ipi-mux.c in PATCH3
- Use a struct for global data of ipi-mux.c in PATCH3
- Add per-CPU temp cpumask for sending IPIs in PATCH3
- Drop the use of fwspec in PATCH3
- Use static key for ipi_mux_pre_handle() and ipi_mux_post_handle() in PATCH3
- Remove redundant pr_warn_ratelimited() called by ipi_mux_process() in PATCH3
- Remove CPUHP thingy from ipi_mux_create() in PATCH3
Changes since v8:
- Rebased on Linux-6.0-rc3
- Use dummy percpu data as parameter for request_percpu_irq() in PATCH4.
Changes since v7:
- Rebased on Linux-6.0-rc1
- Use atomic operations to track per-CPU pending and enabled IPIs in PATCH3. (Note: this is inspired from IPI muxing implemented in drivers/irqchip/irq-apple-aic.c)
- Made "struct ipi_mux_ops" (added by PATCH3) flexible so that drivers/irqchip/irq-apple-aic.c can adopt it in future.
Changes since v6:
- Rebased on Linux-5.19-rc7
- Added documentation for struct ipi_mux_ops in PATCH3
- Dropped dummy irq_mask()/unmask() in PATCH3
- Added const for "ipi_mux_chip" in PATCH3
- Removed "type" initialization from ipi_mux_domain_alloc() in PATCH3
- Dropped translate() from "ipi_mux_domain_ops" in PATCH3
- Improved barrier documentation in ipi_mux_process() of PATCH3
- Added percpu check in ipi_mux_create() for parent_virq of PATCH3
- Added nr_ipi parameter in ipi_mux_create() of PATCH3
Changes since v5:
- Rebased on Linux-5.18-rc3
- Used kernel doc style in PATCH3
- Removed redundant loop in ipi_mux_process() of PATCH3
- Removed "RISC-V" prefix form ipi_mux_chip.name of PATCH3
- Removed use of "this patch" in PATCH3 commit description
- Addressed few other nit comments in PATCH3
Changes since v4:
- Rebased on Linux-5.17
- Includes new PATCH3 which adds mechanism to multiplex a single HW IPI
Changes since v3:
- Rebased on Linux-5.17-rc6
- Updated PATCH2 to not export riscv_set_intc_hwnode_fn()
- Simplified riscv_intc_hwnode() in PATCH2
Changes since v2:
- Rebased on Linux-5.17-rc4
- Updated PATCH2 to not create synthetic INTC fwnode and instead provide a function which allows drivers to directly discover INTC fwnode
Changes since v1:
- Use synthetic fwnode for INTC instead of irq_set_default_host() in PATCH2
Anup Patel (8):
RISC-V: Clear SIP bit only when using SBI IPI operations irqchip/riscv-intc: Allow drivers to directly discover INTC hwnode
genirq: Add mechanism to multiplex a single HW IPI
RISC-V: Treat IPIs as normal Linux IRQs
RISC-V: Allow marking IPIs as suitable for remote FENCEs
RISC-V: Use IPIs for remote TLB flush when possible
RISC-V: Use IPIs for remote icache flush when possible irqchip/riscv-intc: Add empty irq_eoi() for chained irq handlers
Marc Zyngier (1):
irqchip/apple-aic: Move over to core ipi-mux
arch/riscv/Kconfig | 2 + arch/riscv/include/asm/irq.h | 4 + arch/riscv/include/asm/sbi.h | 10 +- arch/riscv/include/asm/smp.h | 49 +++++-- arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/cpu-hotplug.c | 3 +- arch/riscv/kernel/irq.c | 21 ++- arch/riscv/kernel/sbi-ipi.c | 77 +++++++++++ arch/riscv/kernel/sbi.c | 100 +++------------ arch/riscv/kernel/smp.c | 166 ++++++++++++------------ arch/riscv/kernel/smpboot.c | 5 +- arch/riscv/mm/cacheflush.c | 5 +- arch/riscv/mm/tlbflush.c | 93 +++++++++++--- drivers/clocksource/timer-clint.c | 65 +++++++--- drivers/irqchip/Kconfig | 2 + drivers/irqchip/irq-apple-aic.c | 161 ++--------------------- drivers/irqchip/irq-riscv-intc.c | 71 ++++++---- include/linux/irq.h | 3 + kernel/irq/Kconfig | 5 + kernel/irq/Makefile | 1 + kernel/irq/ipi-mux.c | 207 ++++++++++++++++++++++++++++++ 21 files changed, 654 insertions(+), 397 deletions(-) create mode 100644 arch/riscv/kernel/sbi-ipi.c create mode 100644 kernel/irq/ipi-mux.c
Signature · 1 line
2.34.1
PATCH v15 1/9 RISC-V: Clear SIP bit only when using SBI IPI operations
The software interrupt pending (i.e. [M|S]SIP) bit is writeable for S-mode but read-only for M-mode so we clear this bit only when using SBI IPI operations.
--- arch/riscv/kernel/sbi.c | 8 +++++++- arch/riscv/kernel/smp.c | 2 -- 2 files changed, 7 insertions(+), 3 deletions(-)
arch/riscv/kernel/sbi.c +7 -1
@@ -646,8 +646,14 @@ static void sbi_send_cpumask_ipi(const struct cpumask *target)sbi_send_ipi (target); } +static void sbi_ipi_clear (void ) +{ +csr_clear (CSR_IP ,IE_SIE ); +} +static const struct riscv_ipi_ops sbi_ipi_ops = { - .ipi_inject = sbi_send_cpumask_ipi + .ipi_inject = sbi_send_cpumask_ipi, + .ipi_clear = sbi_ipi_clear };void __init sbi_init (void )
arch/riscv/kernel/smp.c +0 -2
@@ -83,8 +83,6 @@ void riscv_clear_ipi(void) {if (ipi_ops && ipi_ops->ipi_clear) ipi_ops->ipi_clear (); - -csr_clear (CSR_IP ,IE_SIE ); }EXPORT_SYMBOL_GPL (riscv_clear_ipi);
Signature · 1 line
2.34.1
PATCH v15 2/9 irqchip/riscv-intc: Allow drivers to directly discover INTC hwnode
In reply to Anup PatelVarious RISC-V drivers (such as SBI IPI, SBI Timer, SBI PMU, and KVM RISC-V) don't have associated DT node but these drivers need standard per-CPU (local) interrupts defined by the RISC-V privileged specification.
We add riscv_get_intc_hwnode() in arch/riscv which allows RISC-V drivers not having DT node to discover INTC hwnode which in-turn helps these drivers to map per-CPU (local) interrupts provided by the INTC driver.
--- arch/riscv/include/asm/irq.h | 4 ++++ arch/riscv/kernel/irq.c | 18 ++++++++++++++++++ drivers/irqchip/irq-riscv-intc.c | 7 +++++++ 3 files changed, 29 insertions(+)
arch/riscv/include/asm/irq.h +4 -0
@@ -12,6 +12,10 @@#include <asm-generic/irq.h> +void riscv_set_intc_hwnode_fn (struct fwnode_handle *(*fn)(void )); + +struct fwnode_handle *riscv_get_intc_hwnode (void ); +extern void __init init_IRQ (void );#endif /* _ASM_RISCV_IRQ_H */
arch/riscv/kernel/irq.c +18 -0
@@ -7,9 +7,27 @@#include <linux/interrupt.h> #include <linux/irqchip.h> +#include <linux/irqdomain.h> +#include <linux/module.h> #include <linux/seq_file.h> #include <asm/smp.h> +static struct fwnode_handle *(*__get_intc_node)(void ); + +void riscv_set_intc_hwnode_fn (struct fwnode_handle *(*fn)(void )) +{ + __get_intc_node = fn; +} + +struct fwnode_handle *riscv_get_intc_hwnode (void ) +{ +if (__get_intc_node) +return __get_intc_node (); + +return NULL ; +} +EXPORT_SYMBOL_GPL (riscv_get_intc_hwnode); +int arch_show_interrupts (struct seq_file *p,int prec) {show_ipi_stats (p, prec);
drivers/irqchip/irq-riscv-intc.c +7 -0
@@ -92,6 +92,11 @@ static const struct irq_domain_ops riscv_intc_domain_ops = { .xlate = irq_domain_xlate_onecell, }; +static struct fwnode_handle *riscv_intc_hwnode (void ) +{ +return intc_domain->fwnode; +} +static int __init riscv_intc_init (struct device_node *node,struct device_node *parent) {
@@ -126,6 +131,8 @@ static int __init riscv_intc_init(struct device_node *node,return rc; } +riscv_set_intc_hwnode_fn (riscv_intc_hwnode); + cpuhp_setup_state(CPUHP_AP_IRQ_RISCV_STARTING, "irqchip/riscv/intc:starting", riscv_intc_cpu_starting,
Signature · 1 line
2.34.1
PATCH v15 3/9 genirq: Add mechanism to multiplex a single HW IPI
In reply to Anup PatelAll RISC-V platforms have a single HW IPI provided by the INTC local interrupt controller. The HW method to trigger INTC IPI can be through external irqchip (e.g. RISC-V AIA), through platform specific device (e.g. SiFive CLINT timer), or through firmware (e.g. SBI IPI call).
To support multiple IPIs on RISC-V, add a generic IPI multiplexing mechanism which help us create multiple virtual IPIs using a single HW IPI. This generic IPI multiplexing is inspired by the Apple AIC irqchip driver and it is shared by various RISC-V irqchip drivers.
--- include/linux/irq.h | 3 + kernel/irq/Kconfig | 5 ++ kernel/irq/Makefile | 1 + kernel/irq/ipi-mux.c | 207 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 216 insertions(+) create mode 100644 kernel/irq/ipi-mux.c
include/linux/irq.h +3 -0
@@ -1266,6 +1266,9 @@ int __ipi_send_mask(struct irq_desc *desc, const struct cpumask *dest);int ipi_send_single (unsigned int virq,unsigned int cpu);int ipi_send_mask (unsigned int virq,const struct cpumask *dest); +void ipi_mux_process (void ); +int ipi_mux_create (unsigned int nr_ipi,void (*mux_send)(unsigned int cpu)); +#ifdef CONFIG_GENERIC_IRQ_MULTI_HANDLER /* * Registers a generic IRQ handling function as the top-level IRQ handler in
kernel/irq/Kconfig +5 -0
@@ -86,6 +86,11 @@ config GENERIC_IRQ_IPI depends on SMP select IRQ_DOMAIN_HIERARCHY +# Generic IRQ IPI Mux support +config GENERIC_IRQ_IPI_MUX + bool + depends on SMP + # Generic MSI interrupt support config GENERIC_MSI_IRQ bool
kernel/irq/Makefile +1 -0
@@ -15,6 +15,7 @@ obj-$(CONFIG_GENERIC_IRQ_MIGRATION) += cpuhotplug.o obj-$(CONFIG_PM_SLEEP) += pm.o obj-$(CONFIG_GENERIC_MSI_IRQ) += msi.o obj-$(CONFIG_GENERIC_IRQ_IPI) += ipi.o +obj-$(CONFIG_GENERIC_IRQ_IPI_MUX) += ipi-mux.o obj-$(CONFIG_SMP) += affinity.o obj-$(CONFIG_GENERIC_IRQ_DEBUGFS) += debugfs.o obj-$(CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR) += matrix.o
kernel/irq/ipi-mux.c new file +207 -0
207 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v15 3/9] genirq: Add mechanism to multiplex a single HW IPI
Quoted 264 lines · Anup Patel
All RISC-V platforms have a single HW IPI provided by the INTC local interrupt controller. The HW method to trigger INTC IPI can be through external irqchip (e.g. RISC-V AIA), through platform specific device (e.g. SiFive CLINT timer), or through firmware (e.g. SBI IPI call).
To support multiple IPIs on RISC-V, add a generic IPI multiplexing mechanism which help us create multiple virtual IPIs using a single HW IPI. This generic IPI multiplexing is inspired by the Apple AIC irqchip driver and it is shared by various RISC-V irqchip drivers.
Signed-off-by Anup Patel <[email protected]>--- include/linux/irq.h | 3 + kernel/irq/Kconfig | 5 ++ kernel/irq/Makefile | 1 + kernel/irq/ipi-mux.c | 207 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 216 insertions(+) create mode 100644 kernel/irq/ipi-mux.cinclude/linux/irq.h +3
-0@@ -1266,6 +1266,9 @@ int __ipi_send_mask(struct irq_desc *desc, const struct cpumask *dest);int ipi_send_single (unsigned int virq,unsigned int cpu);int ipi_send_mask (unsigned int virq,const struct cpumask *dest); +void ipi_mux_process (void ); +int ipi_mux_create (unsigned int nr_ipi,void (*mux_send)(unsigned int cpu)); +#ifdef CONFIG_GENERIC_IRQ_MULTI_HANDLER /* * Registers a generic IRQ handling function as the top-level IRQ handler in kernel/irq/Kconfig +5
-0@@ -86,6 +86,11 @@ config GENERIC_IRQ_IPI depends on SMP select IRQ_DOMAIN_HIERARCHY +# Generic IRQ IPI Mux support +config GENERIC_IRQ_IPI_MUX + bool + depends on SMP + # Generic MSI interrupt support config GENERIC_MSI_IRQ boolkernel/irq/Makefile +1
-0@@ -15,6 +15,7 @@ obj-$(CONFIG_GENERIC_IRQ_MIGRATION) += cpuhotplug.o obj-$(CONFIG_PM_SLEEP) += pm.o obj-$(CONFIG_GENERIC_MSI_IRQ) += msi.o obj-$(CONFIG_GENERIC_IRQ_IPI) += ipi.o +obj-$(CONFIG_GENERIC_IRQ_IPI_MUX) += ipi-mux.o obj-$(CONFIG_SMP) += affinity.o obj-$(CONFIG_GENERIC_IRQ_DEBUGFS) += debugfs.o obj-$(CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR) += matrix.okernel/irq/ipi-mux.c new file +197
-0@@ -0,0 +1,207 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Multiplex several virtual IPIs over a single HW IPI. +* +* Copyright The Asahi Linux Contributors +* Copyright (c) 2022 Ventana Micro Systems Inc. +*/ + +#define pr_fmt (fmt) "ipi-mux: " fmt +#include <linux/cpu.h> +#include <linux/init.h> +#include <linux/irq.h> +#include <linux/irqchip.h> +#include <linux/irqchip/chained_irq.h> +#include <linux/irqdomain.h> +#include <linux/jump_label.h> +#include <linux/percpu.h> +#include <linux/smp.h> + +struct ipi_mux_cpu { +atomic_t enable; +atomic_t bits; +}; + +static struct ipi_mux_cpu __percpu *ipi_mux_pcpu; +static struct irq_domain *ipi_mux_domain; +static void (*ipi_mux_send)(unsigned int cpu); + +static void ipi_mux_mask (struct irq_data *d) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); + +atomic_andnot (BIT (irqd_to_hwirq (d)), &icpu->enable); +} + +static void ipi_mux_unmask (struct irq_data *d) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +u32 ibit =BIT (irqd_to_hwirq (d)); + +atomic_or (ibit, &icpu->enable); + +/* +* The atomic_or() above must complete before the atomic_read() +* below to avoid racing ipi_mux_send_mask(). +*/ +smp_mb__after_atomic (); + +/* If a pending IPI was unmasked, raise a parent IPI immediately. */ +if (atomic_read (&icpu->bits) & ibit) +ipi_mux_send (smp_processor_id ()); +} + +static void ipi_mux_send_mask (struct irq_data *d,const struct cpumask *mask) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +u32 ibit =BIT (irqd_to_hwirq (d)); +unsigned long pending; +int cpu; + +for_each_cpu (cpu, mask) { + icpu =per_cpu_ptr (ipi_mux_pcpu, cpu); + +/* +* This sequence is the mirror of the one in ipi_mux_unmask(); +* see the comment there. Additionally, release semantics +* ensure that the vIPI flag set is ordered after any shared +* memory accesses that precede it. This therefore also pairs +* with the atomic_fetch_andnot in ipi_mux_process(). +*/ + pending =atomic_fetch_or_release (ibit, &icpu->bits); + +/* +* The atomic_fetch_or_release() above must complete +* before the atomic_read() below to avoid racing with +* ipi_mux_unmask(). +*/ +smp_mb__after_atomic (); + +/* +* The flag writes must complete before the physical IPI is +* issued to another CPU. This is implied by the control +* dependency on the result of atomic_read() below, which is +* itself already ordered after the vIPI flag write. +*/ +if (!(pending & ibit) && (atomic_read (&icpu->enable) & ibit)) +ipi_mux_send (cpu); + } +} + +static const struct irq_chip ipi_mux_chip = { + .name ="IPI Mux" , + .irq_mask = ipi_mux_mask, + .irq_unmask = ipi_mux_unmask, + .ipi_send_mask = ipi_mux_send_mask, +}; + +static int ipi_mux_domain_alloc (struct irq_domain *d,unsigned int virq, +unsigned int nr_irqs,void *arg) +{ +int i; + +for (i =0 ; i < nr_irqs; i++) { +irq_set_percpu_devid (virq + i); +irq_domain_set_info (d, virq + i, i, &ipi_mux_chip,NULL , + handle_percpu_devid_irq,NULL ,NULL ); + } + +return 0 ; +} + +static const struct irq_domain_ops ipi_mux_domain_ops = { + .alloc = ipi_mux_domain_alloc, + .free = irq_domain_free_irqs_top, +}; + +/** +* ipi_mux_process - Process multiplexed virtual IPIs +*/ +void ipi_mux_process (void ) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +irq_hw_number_t hwirq; +unsigned long ipis; +unsigned int en; + +/* +* Reading enable mask does not need to be ordered as long as +* this function is called from interrupt handler because only +* the CPU itself can change it's own enable mask. +*/ + en =atomic_read (&icpu->enable); + +/* +* Clear the IPIs we are about to handle. This pairs with the +* atomic_fetch_or_release() in ipi_mux_send_mask(). +*/ + ipis =atomic_fetch_andnot (en, &icpu->bits) & en; + +for_each_set_bit (hwirq, &ipis,BITS_PER_TYPE (int)) +generic_handle_domain_irq (ipi_mux_domain, hwirq); +} + +/** +* ipi_mux_create - Create virtual IPIs multiplexed on top of a single +* parent IPI. +* @nr_ipi: number of virtual IPIs to create. This should +* be <= BITS_PER_TYPE(int) +* @mux_send: callback to trigger parent IPI for a particular CPU +* +* Returns first virq of the newly created virtual IPIs upon success +* or <=0 upon failure +*/ +int ipi_mux_create (unsigned int nr_ipi,void (*mux_send)(unsigned int cpu)) +{ +struct fwnode_handle *fwnode; +struct irq_domain *domain; +int rc; + +if (ipi_mux_domain) +return -EEXIST ; + +if (BITS_PER_TYPE (int) < nr_ipi || !mux_send) +return -EINVAL ; + + ipi_mux_pcpu =alloc_percpu (typeof (*ipi_mux_pcpu)); +if (!ipi_mux_pcpu) +return -ENOMEM ; + + fwnode =irq_domain_alloc_named_fwnode ("IPI-Mux" ); +if (!fwnode) { +pr_err ("unable to create IPI Mux fwnode\n" ); + rc = -ENOMEM ; + goto fail_free_cpu; + } + + domain =irq_domain_create_linear (fwnode, nr_ipi, + &ipi_mux_domain_ops,NULL ); +if (!domain) { +pr_err ("unable to add IPI Mux domain\n" ); + rc = -ENOMEM ; + goto fail_free_fwnode; + } + + domain->flags |=IRQ_DOMAIN_FLAG_IPI_SINGLE ; +irq_domain_update_bus_token (domain,DOMAIN_BUS_IPI ); + + rc =__irq_domain_alloc_irqs (domain,-1 , nr_ipi, +NUMA_NO_NODE ,NULL , false,NULL ); +if (rc <=0 ) { +pr_err ("unable to alloc IRQs from IPI Mux domain\n" ); + goto fail_free_domain; + } + + ipi_mux_domain = domain; + ipi_mux_send = mux_send; +
kernel/irq/ipi-mux.c line 207
Quoted 10 lines
kernel/irq/ipi-mux.c new file +10
-0+return rc; + +fail_free_domain: +irq_domain_remove (domain); +fail_free_fwnode: +irq_domain_free_fwnode (fwnode); +fail_free_cpu: +free_percpu (ipi_mux_pcpu); +return rc; +}
I was actually surprised this wasn't already a solved problem when I first had to write this code. Glad RISC-V found it useful :)
Note: we agonized over the memory ordering here quite a bit when this was first written, and all that was viewed through the lens of the ARM64 memory model. You might want to do a similarly thorough review from a RISC-V perspective to make sure it isn't relying on any ARMisms (or that RISC-V isn't failing to meet the underlying Linux model - we already ran into a core kernel bitop issue once for ARM too!).
- Hector
Re: [PATCH v15 3/9] genirq: Add mechanism to multiplex a single HW IPI
Quoted 283 lines · Hector Martin
Quoted 264 lines · Anup Patel
All RISC-V platforms have a single HW IPI provided by the INTC local interrupt controller. The HW method to trigger INTC IPI can be through external irqchip (e.g. RISC-V AIA), through platform specific device (e.g. SiFive CLINT timer), or through firmware (e.g. SBI IPI call).
To support multiple IPIs on RISC-V, add a generic IPI multiplexing mechanism which help us create multiple virtual IPIs using a single HW IPI. This generic IPI multiplexing is inspired by the Apple AIC irqchip driver and it is shared by various RISC-V irqchip drivers.
Signed-off-by Anup Patel <[email protected]>--- include/linux/irq.h | 3 + kernel/irq/Kconfig | 5 ++ kernel/irq/Makefile | 1 + kernel/irq/ipi-mux.c | 207 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 216 insertions(+) create mode 100644 kernel/irq/ipi-mux.cinclude/linux/irq.h +3
-0@@ -1266,6 +1266,9 @@ int __ipi_send_mask(struct irq_desc *desc, const struct cpumask *dest);int ipi_send_single (unsigned int virq,unsigned int cpu);int ipi_send_mask (unsigned int virq,const struct cpumask *dest); +void ipi_mux_process (void ); +int ipi_mux_create (unsigned int nr_ipi,void (*mux_send)(unsigned int cpu)); +#ifdef CONFIG_GENERIC_IRQ_MULTI_HANDLER /* * Registers a generic IRQ handling function as the top-level IRQ handler in kernel/irq/Kconfig +5
-0@@ -86,6 +86,11 @@ config GENERIC_IRQ_IPI depends on SMP select IRQ_DOMAIN_HIERARCHY +# Generic IRQ IPI Mux support +config GENERIC_IRQ_IPI_MUX + bool + depends on SMP + # Generic MSI interrupt support config GENERIC_MSI_IRQ boolkernel/irq/Makefile +1
-0@@ -15,6 +15,7 @@ obj-$(CONFIG_GENERIC_IRQ_MIGRATION) += cpuhotplug.o obj-$(CONFIG_PM_SLEEP) += pm.o obj-$(CONFIG_GENERIC_MSI_IRQ) += msi.o obj-$(CONFIG_GENERIC_IRQ_IPI) += ipi.o +obj-$(CONFIG_GENERIC_IRQ_IPI_MUX) += ipi-mux.o obj-$(CONFIG_SMP) += affinity.o obj-$(CONFIG_GENERIC_IRQ_DEBUGFS) += debugfs.o obj-$(CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR) += matrix.okernel/irq/ipi-mux.c new file +197
-0@@ -0,0 +1,207 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Multiplex several virtual IPIs over a single HW IPI. +* +* Copyright The Asahi Linux Contributors +* Copyright (c) 2022 Ventana Micro Systems Inc. +*/ + +#define pr_fmt (fmt) "ipi-mux: " fmt +#include <linux/cpu.h> +#include <linux/init.h> +#include <linux/irq.h> +#include <linux/irqchip.h> +#include <linux/irqchip/chained_irq.h> +#include <linux/irqdomain.h> +#include <linux/jump_label.h> +#include <linux/percpu.h> +#include <linux/smp.h> + +struct ipi_mux_cpu { +atomic_t enable; +atomic_t bits; +}; + +static struct ipi_mux_cpu __percpu *ipi_mux_pcpu; +static struct irq_domain *ipi_mux_domain; +static void (*ipi_mux_send)(unsigned int cpu); + +static void ipi_mux_mask (struct irq_data *d) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); + +atomic_andnot (BIT (irqd_to_hwirq (d)), &icpu->enable); +} + +static void ipi_mux_unmask (struct irq_data *d) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +u32 ibit =BIT (irqd_to_hwirq (d)); + +atomic_or (ibit, &icpu->enable); + +/* +* The atomic_or() above must complete before the atomic_read() +* below to avoid racing ipi_mux_send_mask(). +*/ +smp_mb__after_atomic (); + +/* If a pending IPI was unmasked, raise a parent IPI immediately. */ +if (atomic_read (&icpu->bits) & ibit) +ipi_mux_send (smp_processor_id ()); +} + +static void ipi_mux_send_mask (struct irq_data *d,const struct cpumask *mask) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +u32 ibit =BIT (irqd_to_hwirq (d)); +unsigned long pending; +int cpu; + +for_each_cpu (cpu, mask) { + icpu =per_cpu_ptr (ipi_mux_pcpu, cpu); + +/* +* This sequence is the mirror of the one in ipi_mux_unmask(); +* see the comment there. Additionally, release semantics +* ensure that the vIPI flag set is ordered after any shared +* memory accesses that precede it. This therefore also pairs +* with the atomic_fetch_andnot in ipi_mux_process(). +*/ + pending =atomic_fetch_or_release (ibit, &icpu->bits); + +/* +* The atomic_fetch_or_release() above must complete +* before the atomic_read() below to avoid racing with +* ipi_mux_unmask(). +*/ +smp_mb__after_atomic (); + +/* +* The flag writes must complete before the physical IPI is +* issued to another CPU. This is implied by the control +* dependency on the result of atomic_read() below, which is +* itself already ordered after the vIPI flag write. +*/ +if (!(pending & ibit) && (atomic_read (&icpu->enable) & ibit)) +ipi_mux_send (cpu); + } +} + +static const struct irq_chip ipi_mux_chip = { + .name ="IPI Mux" , + .irq_mask = ipi_mux_mask, + .irq_unmask = ipi_mux_unmask, + .ipi_send_mask = ipi_mux_send_mask, +}; + +static int ipi_mux_domain_alloc (struct irq_domain *d,unsigned int virq, +unsigned int nr_irqs,void *arg) +{ +int i; + +for (i =0 ; i < nr_irqs; i++) { +irq_set_percpu_devid (virq + i); +irq_domain_set_info (d, virq + i, i, &ipi_mux_chip,NULL , + handle_percpu_devid_irq,NULL ,NULL ); + } + +return 0 ; +} + +static const struct irq_domain_ops ipi_mux_domain_ops = { + .alloc = ipi_mux_domain_alloc, + .free = irq_domain_free_irqs_top, +}; + +/** +* ipi_mux_process - Process multiplexed virtual IPIs +*/ +void ipi_mux_process (void ) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +irq_hw_number_t hwirq; +unsigned long ipis; +unsigned int en; + +/* +* Reading enable mask does not need to be ordered as long as +* this function is called from interrupt handler because only +* the CPU itself can change it's own enable mask. +*/ + en =atomic_read (&icpu->enable); + +/* +* Clear the IPIs we are about to handle. This pairs with the +* atomic_fetch_or_release() in ipi_mux_send_mask(). +*/ + ipis =atomic_fetch_andnot (en, &icpu->bits) & en; + +for_each_set_bit (hwirq, &ipis,BITS_PER_TYPE (int)) +generic_handle_domain_irq (ipi_mux_domain, hwirq); +} + +/** +* ipi_mux_create - Create virtual IPIs multiplexed on top of a single +* parent IPI. +* @nr_ipi: number of virtual IPIs to create. This should +* be <= BITS_PER_TYPE(int) +* @mux_send: callback to trigger parent IPI for a particular CPU +* +* Returns first virq of the newly created virtual IPIs upon success +* or <=0 upon failure +*/ +int ipi_mux_create (unsigned int nr_ipi,void (*mux_send)(unsigned int cpu)) +{ +struct fwnode_handle *fwnode; +struct irq_domain *domain; +int rc; + +if (ipi_mux_domain) +return -EEXIST ; + +if (BITS_PER_TYPE (int) < nr_ipi || !mux_send) +return -EINVAL ; + + ipi_mux_pcpu =alloc_percpu (typeof (*ipi_mux_pcpu)); +if (!ipi_mux_pcpu) +return -ENOMEM ; + + fwnode =irq_domain_alloc_named_fwnode ("IPI-Mux" ); +if (!fwnode) { +pr_err ("unable to create IPI Mux fwnode\n" ); + rc = -ENOMEM ; + goto fail_free_cpu; + } + + domain =irq_domain_create_linear (fwnode, nr_ipi, + &ipi_mux_domain_ops,NULL ); +if (!domain) { +pr_err ("unable to add IPI Mux domain\n" ); + rc = -ENOMEM ; + goto fail_free_fwnode; + } + + domain->flags |=IRQ_DOMAIN_FLAG_IPI_SINGLE ; +irq_domain_update_bus_token (domain,DOMAIN_BUS_IPI ); + + rc =__irq_domain_alloc_irqs (domain,-1 , nr_ipi, +NUMA_NO_NODE ,NULL , false,NULL ); +if (rc <=0 ) { +pr_err ("unable to alloc IRQs from IPI Mux domain\n" ); + goto fail_free_domain; + } + + ipi_mux_domain = domain; + ipi_mux_send = mux_send; +kernel/irq/ipi-mux.c line 207
Quoted 10 lines
kernel/irq/ipi-mux.c new file +10
-0+return rc; + +fail_free_domain: +irq_domain_remove (domain); +fail_free_fwnode: +irq_domain_free_fwnode (fwnode); +fail_free_cpu: +free_percpu (ipi_mux_pcpu); +return rc; +}Reviewed-by Hector Martin <[email protected]>Tested-by Hector Martin <[email protected]>I was actually surprised this wasn't already a solved problem when I first had to write this code. Glad RISC-V found it useful :)
Quoted 7 lines
Note: we agonized over the memory ordering here quite a bit when this was first written, and all that was viewed through the lens of the ARM64 memory model. You might want to do a similarly thorough review from a RISC-V perspective to make sure it isn't relying on any ARMisms (or that RISC-V isn't failing to meet the underlying Linux model - we already ran into a core kernel bitop issue once for ARM too!).
Thanks, your work is certainly useful to the RISC-V. We already have three RISC-V irqchip drivers (SBI IPI, CLINT,and IMSIC) which benefit from this code. The RISC-V IMSIC driver was recently submitted on LKML whereas the other two are already used on existing platforms.
Regarding memory-model, RISC-V platforms by default have weak memory ordering (same as ARM). We also have optional TSO extension but currently there are no platforms implementing it.
Regarding atomics used in this patch, there is only one difference in atomic_fetch_or_release() where RISC-V implements it as __atomic_release_fence() plus atomic_fetch_or_relaxed().
Regards,
Anup
Re: [PATCH v15 3/9] genirq: Add mechanism to multiplex a single HW IPI
Quoted 282 lines · Anup Patel
Quoted 280 lines · Hector Martin
Quoted 264 lines · Anup Patel
All RISC-V platforms have a single HW IPI provided by the INTC local interrupt controller. The HW method to trigger INTC IPI can be through external irqchip (e.g. RISC-V AIA), through platform specific device (e.g. SiFive CLINT timer), or through firmware (e.g. SBI IPI call).
To support multiple IPIs on RISC-V, add a generic IPI multiplexing mechanism which help us create multiple virtual IPIs using a single HW IPI. This generic IPI multiplexing is inspired by the Apple AIC irqchip driver and it is shared by various RISC-V irqchip drivers.
Signed-off-by Anup Patel <[email protected]>--- include/linux/irq.h | 3 + kernel/irq/Kconfig | 5 ++ kernel/irq/Makefile | 1 + kernel/irq/ipi-mux.c | 207 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 216 insertions(+) create mode 100644 kernel/irq/ipi-mux.cinclude/linux/irq.h +3
-0@@ -1266,6 +1266,9 @@ int __ipi_send_mask(struct irq_desc *desc, const struct cpumask *dest);int ipi_send_single (unsigned int virq,unsigned int cpu);int ipi_send_mask (unsigned int virq,const struct cpumask *dest); +void ipi_mux_process (void ); +int ipi_mux_create (unsigned int nr_ipi,void (*mux_send)(unsigned int cpu)); +#ifdef CONFIG_GENERIC_IRQ_MULTI_HANDLER /* * Registers a generic IRQ handling function as the top-level IRQ handler in kernel/irq/Kconfig +5
-0@@ -86,6 +86,11 @@ config GENERIC_IRQ_IPI depends on SMP select IRQ_DOMAIN_HIERARCHY +# Generic IRQ IPI Mux support +config GENERIC_IRQ_IPI_MUX + bool + depends on SMP + # Generic MSI interrupt support config GENERIC_MSI_IRQ boolkernel/irq/Makefile +1
-0@@ -15,6 +15,7 @@ obj-$(CONFIG_GENERIC_IRQ_MIGRATION) += cpuhotplug.o obj-$(CONFIG_PM_SLEEP) += pm.o obj-$(CONFIG_GENERIC_MSI_IRQ) += msi.o obj-$(CONFIG_GENERIC_IRQ_IPI) += ipi.o +obj-$(CONFIG_GENERIC_IRQ_IPI_MUX) += ipi-mux.o obj-$(CONFIG_SMP) += affinity.o obj-$(CONFIG_GENERIC_IRQ_DEBUGFS) += debugfs.o obj-$(CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR) += matrix.okernel/irq/ipi-mux.c new file +197
-0@@ -0,0 +1,207 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Multiplex several virtual IPIs over a single HW IPI. +* +* Copyright The Asahi Linux Contributors +* Copyright (c) 2022 Ventana Micro Systems Inc. +*/ + +#define pr_fmt (fmt) "ipi-mux: " fmt +#include <linux/cpu.h> +#include <linux/init.h> +#include <linux/irq.h> +#include <linux/irqchip.h> +#include <linux/irqchip/chained_irq.h> +#include <linux/irqdomain.h> +#include <linux/jump_label.h> +#include <linux/percpu.h> +#include <linux/smp.h> + +struct ipi_mux_cpu { +atomic_t enable; +atomic_t bits; +}; + +static struct ipi_mux_cpu __percpu *ipi_mux_pcpu; +static struct irq_domain *ipi_mux_domain; +static void (*ipi_mux_send)(unsigned int cpu); + +static void ipi_mux_mask (struct irq_data *d) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); + +atomic_andnot (BIT (irqd_to_hwirq (d)), &icpu->enable); +} + +static void ipi_mux_unmask (struct irq_data *d) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +u32 ibit =BIT (irqd_to_hwirq (d)); + +atomic_or (ibit, &icpu->enable); + +/* +* The atomic_or() above must complete before the atomic_read() +* below to avoid racing ipi_mux_send_mask(). +*/ +smp_mb__after_atomic (); + +/* If a pending IPI was unmasked, raise a parent IPI immediately. */ +if (atomic_read (&icpu->bits) & ibit) +ipi_mux_send (smp_processor_id ()); +} + +static void ipi_mux_send_mask (struct irq_data *d,const struct cpumask *mask) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +u32 ibit =BIT (irqd_to_hwirq (d)); +unsigned long pending; +int cpu; + +for_each_cpu (cpu, mask) { + icpu =per_cpu_ptr (ipi_mux_pcpu, cpu); + +/* +* This sequence is the mirror of the one in ipi_mux_unmask(); +* see the comment there. Additionally, release semantics +* ensure that the vIPI flag set is ordered after any shared +* memory accesses that precede it. This therefore also pairs +* with the atomic_fetch_andnot in ipi_mux_process(). +*/ + pending =atomic_fetch_or_release (ibit, &icpu->bits); + +/* +* The atomic_fetch_or_release() above must complete +* before the atomic_read() below to avoid racing with +* ipi_mux_unmask(). +*/ +smp_mb__after_atomic (); + +/* +* The flag writes must complete before the physical IPI is +* issued to another CPU. This is implied by the control +* dependency on the result of atomic_read() below, which is +* itself already ordered after the vIPI flag write. +*/ +if (!(pending & ibit) && (atomic_read (&icpu->enable) & ibit)) +ipi_mux_send (cpu); + } +} + +static const struct irq_chip ipi_mux_chip = { + .name ="IPI Mux" , + .irq_mask = ipi_mux_mask, + .irq_unmask = ipi_mux_unmask, + .ipi_send_mask = ipi_mux_send_mask, +}; + +static int ipi_mux_domain_alloc (struct irq_domain *d,unsigned int virq, +unsigned int nr_irqs,void *arg) +{ +int i; + +for (i =0 ; i < nr_irqs; i++) { +irq_set_percpu_devid (virq + i); +irq_domain_set_info (d, virq + i, i, &ipi_mux_chip,NULL , + handle_percpu_devid_irq,NULL ,NULL ); + } + +return 0 ; +} + +static const struct irq_domain_ops ipi_mux_domain_ops = { + .alloc = ipi_mux_domain_alloc, + .free = irq_domain_free_irqs_top, +}; + +/** +* ipi_mux_process - Process multiplexed virtual IPIs +*/ +void ipi_mux_process (void ) +{ +struct ipi_mux_cpu *icpu =this_cpu_ptr (ipi_mux_pcpu); +irq_hw_number_t hwirq; +unsigned long ipis; +unsigned int en; + +/* +* Reading enable mask does not need to be ordered as long as +* this function is called from interrupt handler because only +* the CPU itself can change it's own enable mask. +*/ + en =atomic_read (&icpu->enable); + +/* +* Clear the IPIs we are about to handle. This pairs with the +* atomic_fetch_or_release() in ipi_mux_send_mask(). +*/ + ipis =atomic_fetch_andnot (en, &icpu->bits) & en; + +for_each_set_bit (hwirq, &ipis,BITS_PER_TYPE (int)) +generic_handle_domain_irq (ipi_mux_domain, hwirq); +} + +/** +* ipi_mux_create - Create virtual IPIs multiplexed on top of a single +* parent IPI. +* @nr_ipi: number of virtual IPIs to create. This should +* be <= BITS_PER_TYPE(int) +* @mux_send: callback to trigger parent IPI for a particular CPU +* +* Returns first virq of the newly created virtual IPIs upon success +* or <=0 upon failure +*/ +int ipi_mux_create (unsigned int nr_ipi,void (*mux_send)(unsigned int cpu)) +{ +struct fwnode_handle *fwnode; +struct irq_domain *domain; +int rc; + +if (ipi_mux_domain) +return -EEXIST ; + +if (BITS_PER_TYPE (int) < nr_ipi || !mux_send) +return -EINVAL ; + + ipi_mux_pcpu =alloc_percpu (typeof (*ipi_mux_pcpu)); +if (!ipi_mux_pcpu) +return -ENOMEM ; + + fwnode =irq_domain_alloc_named_fwnode ("IPI-Mux" ); +if (!fwnode) { +pr_err ("unable to create IPI Mux fwnode\n" ); + rc = -ENOMEM ; + goto fail_free_cpu; + } + + domain =irq_domain_create_linear (fwnode, nr_ipi, + &ipi_mux_domain_ops,NULL ); +if (!domain) { +pr_err ("unable to add IPI Mux domain\n" ); + rc = -ENOMEM ; + goto fail_free_fwnode; + } + + domain->flags |=IRQ_DOMAIN_FLAG_IPI_SINGLE ; +irq_domain_update_bus_token (domain,DOMAIN_BUS_IPI ); + + rc =__irq_domain_alloc_irqs (domain,-1 , nr_ipi, +NUMA_NO_NODE ,NULL , false,NULL ); +if (rc <=0 ) { +pr_err ("unable to alloc IRQs from IPI Mux domain\n" ); + goto fail_free_domain; + } + + ipi_mux_domain = domain; + ipi_mux_send = mux_send; +kernel/irq/ipi-mux.c line 207
Quoted 10 lines
kernel/irq/ipi-mux.c new file +10
-0+return rc; + +fail_free_domain: +irq_domain_remove (domain); +fail_free_fwnode: +irq_domain_free_fwnode (fwnode); +fail_free_cpu: +free_percpu (ipi_mux_pcpu); +return rc; +}Reviewed-by Hector Martin <[email protected]>Tested-by Hector Martin <[email protected]>
Quoted 2 lines
Quoted 2 lines
I was actually surprised this wasn't already a solved problem when I first had to write this code. Glad RISC-V found it useful :)
There are a few other potential customers for this code, such as openrisc (see drivers/irqchip/irq-ompic.c as a scary example).
Quoted 9 lines
Quoted 8 lines
Note: we agonized over the memory ordering here quite a bit when this was first written, and all that was viewed through the lens of the ARM64 memory model. You might want to do a similarly thorough review from a RISC-V perspective to make sure it isn't relying on any ARMisms (or that RISC-V isn't failing to meet the underlying Linux model - we already ran into a core kernel bitop issue once for ARM too!).
Quoted 8 lines
Thanks, your work is certainly useful to the RISC-V. We already have three RISC-V irqchip drivers (SBI IPI, CLINT,and IMSIC) which benefit from this code. The RISC-V IMSIC driver was recently submitted on LKML whereas the other two are already used on existing platforms.
Regarding memory-model, RISC-V platforms by default have weak memory ordering (same as ARM). We also have optional TSO extension but currently there are no platforms implementing it.
Weak doesn't mean similar. See Power for an example of "weak but different".
Quoted 4 lines
Regarding atomics used in this patch, there is only one difference in
atomic_fetch_or_release()where RISC-V implements it as__atomic_release_fence()plusatomic_fetch_or_relaxed().
But the point here is that we're using the Linux memory model, not the arm64 one. Both architectures are free to implement it as they want, as long as the implementation is not weaker than what the kernel requires.
I'm sure we'll find issues along the way, but the more common code we have around this, the better.
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
PATCH v15 4/9 RISC-V: Treat IPIs as normal Linux IRQs
In reply to Anup PatelCurrently, the RISC-V kernel provides arch specific hooks (i.e. struct riscv_ipi_ops) to register IPI handling methods. The stats gathering of IPIs is also arch specific in the RISC-V kernel.
Other architectures (such as ARM, ARM64, and MIPS) have moved away from custom arch specific IPI handling methods. Currently, these architectures have Linux irqchip drivers providing a range of Linux IRQ numbers to be used as IPIs and IPI triggering is done using generic IPI APIs. This approach allows architectures to treat IPIs as normal Linux IRQs and IPI stats gathering is done by the generic Linux IRQ subsystem.
We extend the RISC-V IPI handling as-per above approach so that arch specific IPI handling methods (struct riscv_ipi_ops) can be removed and the IPI handling is done through the Linux IRQ subsystem.
--- arch/riscv/Kconfig | 2 + arch/riscv/include/asm/sbi.h | 10 +- arch/riscv/include/asm/smp.h | 35 ++++--- arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/cpu-hotplug.c | 3 +- arch/riscv/kernel/irq.c | 3 +- arch/riscv/kernel/sbi-ipi.c | 77 +++++++++++++++ arch/riscv/kernel/sbi.c | 106 +++----------------- arch/riscv/kernel/smp.c | 155 +++++++++++++++--------------- arch/riscv/kernel/smpboot.c | 5 +- drivers/clocksource/timer-clint.c | 65 ++++++++++--- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-riscv-intc.c | 55 +++++------ 13 files changed, 283 insertions(+), 235 deletions(-) create mode 100644 arch/riscv/kernel/sbi-ipi.c
arch/riscv/Kconfig +2 -0
@@ -61,6 +61,8 @@ config RISCV select GENERIC_GETTIMEOFDAY if HAVE_GENERIC_VDSO select GENERIC_IDLE_POLL_SETUP select GENERIC_IOREMAP if MMU + select GENERIC_IRQ_IPI if SMP + select GENERIC_IRQ_IPI_MUX if SMP select GENERIC_IRQ_MULTI_HANDLER select GENERIC_IRQ_SHOW select GENERIC_IRQ_SHOW_LEVEL
arch/riscv/include/asm/sbi.h +8 -2
@@ -268,8 +268,7 @@ long sbi_get_marchid(void);long sbi_get_mimpid (void );void sbi_set_timer (uint64_t stime_value);void sbi_shutdown (void ); -void sbi_clear_ipi (void ); -int sbi_send_ipi (const struct cpumask *cpu_mask); +void sbi_send_ipi (unsigned int cpu);int sbi_remote_fence_i (const struct cpumask *cpu_mask); int sbi_remote_sfence_vma(const struct cpumask *cpu_mask, unsigned long start,
@@ -327,4 +326,11 @@ int sbi_err_map_linux_errno(int err);static inline int sbi_remote_fence_i (const struct cpumask *cpu_mask) {return -1 ; }static inline void sbi_init (void ) {}#endif /* CONFIG_RISCV_SBI */ + +#if IS_ENABLED (CONFIG_SMP ) &&IS_ENABLED (CONFIG_RISCV_SBI ) +void sbi_ipi_init (void ); +#else +static inline void sbi_ipi_init (void ) { } +#endif +#endif /* _ASM_RISCV_SBI_H */
arch/riscv/include/asm/smp.h +21 -14
@@ -15,11 +15,6 @@struct seq_file ;extern unsigned long boot_cpu_hartid; -struct riscv_ipi_ops { -void (*ipi_inject)(const struct cpumask *target); -void (*ipi_clear)(void ); -}; -#ifdef CONFIG_SMP /* * Mapping between linux logical cpu index and hartid.
@@ -33,9 +28,6 @@ void show_ipi_stats(struct seq_file *p, int prec);/* SMP initialization hook for setup_arch */ void __init setup_smp (void ); -/* Called from C code, this handles an IPI. */ -void handle_IPI (struct pt_regs *regs); -/* Hook for the generic smp_call_function_many() routine. */ void arch_send_call_function_ipi_mask (struct cpumask *mask);
@@ -44,11 +36,17 @@ void arch_send_call_function_single_ipi(int cpu);int riscv_hartid_to_cpuid (unsigned long hartid); -/* Set custom IPI operations */ -void riscv_set_ipi_ops (const struct riscv_ipi_ops *ops); +/* Enable IPI for CPU hotplug */ +void riscv_ipi_enable (void ); + +/* Disable IPI for CPU hotplug */ +void riscv_ipi_disable (void ); -/* Clear IPI for current CPU */ -void riscv_clear_ipi (void ); +/* Check if IPI interrupt numbers are available */ +bool riscv_ipi_have_virq_range (void ); + +/* Set the IPI interrupt numbers for arch (called by irqchip drivers) */ +void riscv_ipi_set_virq_range (int virq,int nr);/* Secondary hart entry */ asmlinkage void smp_callin(void);
@@ -82,11 +80,20 @@ static inline unsigned long cpuid_to_hartid_map(int cpu)return boot_cpu_hartid; } -static inline void riscv_set_ipi_ops (const struct riscv_ipi_ops *ops) +static inline void riscv_ipi_enable (void ) { } -static inline void riscv_clear_ipi (void ) +static inline void riscv_ipi_disable (void ) +{ +} + +static inline bool riscv_ipi_have_virq_range (void ) +{ +return false; +} + +static inline void riscv_ipi_set_virq_range (int virq,int nr) { }
arch/riscv/kernel/Makefile +1 -0
@@ -74,6 +74,7 @@ obj-$(CONFIG_PERF_EVENTS) += perf_callchain.o obj-$(CONFIG_HAVE_PERF_REGS) += perf_regs.o obj-$(CONFIG_RISCV_SBI) += sbi.o ifeq ($(CONFIG_RISCV_SBI), y) +obj-$(CONFIG_SMP) += sbi-ipi.o obj-$(CONFIG_SMP) += cpu_ops_sbi.o endif obj-$(CONFIG_HOTPLUG_CPU) += cpu-hotplug.o
arch/riscv/kernel/cpu-hotplug.c +2 -1
@@ -13,7 +13,7 @@#include <asm/irq.h> #include <asm/cpu_ops.h> #include <asm/numa.h> -#include <asm/sbi.h> +#include <asm/smp.h> bool cpu_has_hotplug (unsigned int cpu) {
@@ -43,6 +43,7 @@ int __cpu_disable(void)remove_cpu_topology (cpu);numa_remove_cpu (cpu);set_cpu_online (cpu, false); +riscv_ipi_disable ();irq_migrate_all_off_this_cpu ();return ret;
arch/riscv/kernel/irq.c +2 -1
@@ -10,7 +10,7 @@#include <linux/irqdomain.h> #include <linux/module.h> #include <linux/seq_file.h> -#include <asm/smp.h> +#include <asm/sbi.h> static struct fwnode_handle *(*__get_intc_node)(void );
@@ -39,4 +39,5 @@ void __init init_IRQ(void)irqchip_init ();if (!handle_arch_irq)panic ("No interrupt controller found." ); +sbi_ipi_init (); }
arch/riscv/kernel/sbi-ipi.c new file +77 -0
77 lines not on this page · raw message
arch/riscv/kernel/sbi.c +16 -90
164 lines not on this page · raw message
arch/riscv/kernel/smp.c +78 -77
211 lines not on this page · raw message
arch/riscv/kernel/smpboot.c +2 -3
@@ -30,7 +30,6 @@#include <asm/numa.h> #include <asm/tlbflush.h> #include <asm/sections.h> -#include <asm/sbi.h> #include <asm/smp.h> #include "head.h"
@@ -157,12 +156,12 @@ asmlinkage __visible void smp_callin(void)struct mm_struct *mm = &init_mm;unsigned int curr_cpuid =smp_processor_id (); -riscv_clear_ipi (); -/* All kernel threads share the same mm context. */ mmgrab (mm); current->active_mm = mm; +riscv_ipi_enable (); +store_cpu_topology (curr_cpuid);notify_cpu_starting (curr_cpuid);numa_add_cpu (curr_cpuid);
drivers/clocksource/timer-clint.c +49 -16
129 lines not on this page · raw message
drivers/irqchip/Kconfig +1 -0
@@ -540,6 +540,7 @@ config TI_PRUSS_INTC config RISCV_INTC bool "RISC-V Local Interrupt Controller" depends on RISCV + select IRQ_DOMAIN_HIERARCHY default y help This enables support for the per-HART local interrupt controller
drivers/irqchip/irq-riscv-intc.c +24 -31
82 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v15 5/9 RISC-V: Allow marking IPIs as suitable for remote FENCEs
In reply to Anup PatelTo do remote FENCEs (i.e. remote TLB flushes) using IPI calls on the RISC-V kernel, we need hardware mechanism to directly inject IPI from the supervisor mode (i.e. RISC-V kernel) instead of using SBI calls.
The upcoming AIA IMSIC devices allow direct IPI injection from the supervisor mode (i.e. RISC-V kernel). To support this, we extend the riscv_ipi_set_virq_range() function so that IPI provider (i.e. irqchip drivers can mark IPIs as suitable for remote FENCEs.
--- arch/riscv/include/asm/smp.h | 18 ++++++++++++++++-- arch/riscv/kernel/sbi-ipi.c | 2 +- arch/riscv/kernel/smp.c | 11 ++++++++++- drivers/clocksource/timer-clint.c | 2 +- 4 files changed, 28 insertions(+), 5 deletions(-)
arch/riscv/include/asm/smp.h +16 -2
@@ -16,6 +16,9 @@ struct seq_file;extern unsigned long boot_cpu_hartid;#ifdef CONFIG_SMP + +#include <linux/jump_label.h> +/* * Mapping between linux logical cpu index and hartid. */
@@ -46,7 +49,12 @@ void riscv_ipi_disable(void);bool riscv_ipi_have_virq_range (void );/* Set the IPI interrupt numbers for arch (called by irqchip drivers) */ -void riscv_ipi_set_virq_range (int virq,int nr); +void riscv_ipi_set_virq_range (int virq,int nr,bool use_for_rfence); + +/* Check if we can use IPIs for remote FENCEs */ +DECLARE_STATIC_KEY_FALSE (riscv_ipi_for_rfence); +#define riscv_use_ipi_for_rfence () \ + static_branch_unlikely(&riscv_ipi_for_rfence)/* Secondary hart entry */ asmlinkage void smp_callin(void);
@@ -93,10 +101,16 @@ static inline bool riscv_ipi_have_virq_range(void) return false; } -static inline void riscv_ipi_set_virq_range (int virq,int nr) +static inline void riscv_ipi_set_virq_range (int virq,int nr, +bool use_for_rfence) { } +static inline bool riscv_use_ipi_for_rfence (void ) +{ +return false; +} +#endif /* CONFIG_SMP */ #if defined(CONFIG_HOTPLUG_CPU ) && (CONFIG_SMP )
arch/riscv/kernel/sbi-ipi.c +1 -1
@@ -72,6 +72,6 @@ void __init sbi_ipi_init(void)"irqchip/sbi-ipi:starting" , sbi_ipi_starting_cpu, NULL); -riscv_ipi_set_virq_range (virq,BITS_PER_BYTE ); +riscv_ipi_set_virq_range (virq,BITS_PER_BYTE , false);pr_info ("providing IPIs using SBI IPI extension\n" ); }
arch/riscv/kernel/smp.c +10 -1
@@ -145,7 +145,10 @@ bool riscv_ipi_have_virq_range(void)return (ipi_virq_base) ? true : false; } -void riscv_ipi_set_virq_range (int virq,int nr) +DEFINE_STATIC_KEY_FALSE (riscv_ipi_for_rfence); +EXPORT_SYMBOL_GPL (riscv_ipi_for_rfence); + +void riscv_ipi_set_virq_range (int virq,int nr,bool use_for_rfence) {int i, err;
@@ -168,6 +171,12 @@ void riscv_ipi_set_virq_range(int virq, int nr)/* Enabled IPIs for boot CPU immediately */ riscv_ipi_enable (); + +/* Update RFENCE static key */ +if (use_for_rfence) +static_branch_enable (&riscv_ipi_for_rfence); +else +static_branch_disable (&riscv_ipi_for_rfence); }EXPORT_SYMBOL_GPL (riscv_ipi_set_virq_range);
drivers/clocksource/timer-clint.c +1 -1
@@ -251,7 +251,7 @@ static int __init clint_timer_init_dt(struct device_node *np) }irq_set_chained_handler (clint_ipi_irq, clint_ipi_interrupt); -riscv_ipi_set_virq_range (rc,BITS_PER_BYTE ); +riscv_ipi_set_virq_range (rc,BITS_PER_BYTE , true);clint_clear_ipi ();#endif
Signature · 1 line
2.34.1
PATCH v15 6/9 RISC-V: Use IPIs for remote TLB flush when possible
In reply to Anup PatelIf we have specialized interrupt controller (such as AIA IMSIC) which allows supervisor mode to directly inject IPIs without any assistance from M-mode or HS-mode then using such specialized interrupt controller, we can do remote TLB flushes directly from supervisor mode instead of using the SBI RFENCE calls.
This patch extends remote TLB flush functions to use supervisor mode IPIs whenever direct supervisor mode IPIs.are supported by interrupt controller.
--- arch/riscv/mm/tlbflush.c | 93 +++++++++++++++++++++++++++++++++------- 1 file changed, 78 insertions(+), 15 deletions(-)
arch/riscv/mm/tlbflush.c +78 -15
@@ -23,14 +23,62 @@ static inline void local_flush_tlb_page_asid(unsigned long addr, : "memory"); } +static inline void local_flush_tlb_range (unsigned long start, +unsigned long size,unsigned long stride) +{ +if (size <= stride) +local_flush_tlb_page (start); +else +local_flush_tlb_all (); +} + +static inline void local_flush_tlb_range_asid (unsigned long start, +unsigned long size,unsigned long stride,unsigned long asid) +{ +if (size <= stride) +local_flush_tlb_page_asid (start, asid); +else +local_flush_tlb_all_asid (asid); +} + +static void __ipi_flush_tlb_all (void *info) +{ +local_flush_tlb_all (); +} +void flush_tlb_all (void ) { -sbi_remote_sfence_vma (NULL ,0 ,-1 ); +if (riscv_use_ipi_for_rfence ()) +on_each_cpu (__ipi_flush_tlb_all,NULL ,1 ); +else +sbi_remote_sfence_vma (NULL ,0 ,-1 ); +} + +struct flush_tlb_range_data { +unsigned long asid; +unsigned long start; +unsigned long size; +unsigned long stride; +}; + +static void __ipi_flush_tlb_range_asid (void *info) +{ +struct flush_tlb_range_data *d = info; + +local_flush_tlb_range_asid (d->start, d->size, d->stride, d->asid); +} + +static void __ipi_flush_tlb_range (void *info) +{ +struct flush_tlb_range_data *d = info; + +local_flush_tlb_range (d->start, d->size, d->stride); } -static void __sbi_tlb_flush_range (struct mm_struct *mm,unsigned long start, -unsigned long size,unsigned long stride) +static void __flush_tlb_range (struct mm_struct *mm,unsigned long start, +unsigned long size,unsigned long stride) { +struct flush_tlb_range_data ftd;struct cpumask *cmask =mm_cpumask (mm);unsigned int cpuid;bool broadcast;
@@ -45,19 +93,34 @@ static void __sbi_tlb_flush_range(struct mm_struct *mm, unsigned long start,unsigned long asid =atomic_long_read (&mm->context.id);if (broadcast) { -sbi_remote_sfence_vma_asid (cmask, start, size, asid); - }else if (size <= stride) { -local_flush_tlb_page_asid (start, asid); +if (riscv_use_ipi_for_rfence ()) { + ftd.asid = asid; + ftd.start = start; + ftd.size = size; + ftd.stride = stride; +on_each_cpu_mask (cmask, + __ipi_flush_tlb_range_asid, + &ftd,1 ); + }else +sbi_remote_sfence_vma_asid (cmask, + start, size, asid); }else { -local_flush_tlb_all_asid (asid); +local_flush_tlb_range_asid (start, size, stride, asid); } }else {if (broadcast) { -sbi_remote_sfence_vma (cmask, start, size); - }else if (size <= stride) { -local_flush_tlb_page (start); +if (riscv_use_ipi_for_rfence ()) { + ftd.asid =0 ; + ftd.start = start; + ftd.size = size; + ftd.stride = stride; +on_each_cpu_mask (cmask, + __ipi_flush_tlb_range, + &ftd,1 ); + }else +sbi_remote_sfence_vma (cmask, start, size); }else { -local_flush_tlb_all (); +local_flush_tlb_range (start, size, stride); } }
@@ -66,23 +129,23 @@ static void __sbi_tlb_flush_range(struct mm_struct *mm, unsigned long start,void flush_tlb_mm (struct mm_struct *mm) { -__sbi_tlb_flush_range (mm,0 ,-1 ,PAGE_SIZE ); +__flush_tlb_range (mm,0 ,-1 ,PAGE_SIZE ); }void flush_tlb_page (struct vm_area_struct *vma,unsigned long addr) { -__sbi_tlb_flush_range (vma->vm_mm, addr,PAGE_SIZE ,PAGE_SIZE ); +__flush_tlb_range (vma->vm_mm, addr,PAGE_SIZE ,PAGE_SIZE ); }void flush_tlb_range (struct vm_area_struct *vma,unsigned long start,unsigned long end) { -__sbi_tlb_flush_range (vma->vm_mm, start, end - start,PAGE_SIZE ); +__flush_tlb_range (vma->vm_mm, start, end - start,PAGE_SIZE ); }#ifdef CONFIG_TRANSPARENT_HUGEPAGE void flush_pmd_tlb_range (struct vm_area_struct *vma,unsigned long start,unsigned long end) { -__sbi_tlb_flush_range (vma->vm_mm, start, end - start,PMD_SIZE ); +__flush_tlb_range (vma->vm_mm, start, end - start,PMD_SIZE ); }#endif
Signature · 1 line
2.34.1
PATCH v15 7/9 RISC-V: Use IPIs for remote icache flush when possible
In reply to Anup PatelIf we have specialized interrupt controller (such as AIA IMSIC) which allows supervisor mode to directly inject IPIs without any assistance from M-mode or HS-mode then using such specialized interrupt controller, we can do remote icache flushe directly from supervisor mode instead of using the SBI RFENCE calls.
This patch extends remote icache flush functions to use supervisor mode IPIs whenever direct supervisor mode IPIs.are supported by interrupt controller.
--- arch/riscv/mm/cacheflush.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/riscv/mm/cacheflush.c +3 -2
@@ -19,7 +19,7 @@ void flush_icache_all(void) {local_flush_icache_all (); -if (IS_ENABLED (CONFIG_RISCV_SBI )) +if (IS_ENABLED (CONFIG_RISCV_SBI ) && !riscv_use_ipi_for_rfence ())sbi_remote_fence_i (NULL );else on_each_cpu (ipi_remote_fence_i,NULL ,1 );
@@ -67,7 +67,8 @@ void flush_icache_mm(struct mm_struct *mm, bool local)* with flush_icache_deferred(). */ smp_mb (); - }else if (IS_ENABLED (CONFIG_RISCV_SBI )) { + }else if (IS_ENABLED (CONFIG_RISCV_SBI ) && + !riscv_use_ipi_for_rfence ()) {sbi_remote_fence_i (&others); }else {on_each_cpu_mask (&others, ipi_remote_fence_i,NULL ,1 );
Signature · 1 line
2.34.1
PATCH v15 8/9 irqchip/riscv-intc: Add empty irq_eoi() for chained irq handlers
In reply to Anup PatelWe add empty irq_eoi() in RISC-V INTC driver for child irqchip drivers (such as PLIC, SBI IPI, CLINT, APLIC, IMSIC, etc) which implement chained handlers for parent per-HART local interrupts. This hels us avoid unnecessary mask/unmask of per-HART local interrupts at the time of handling interrupts.
--- drivers/irqchip/irq-riscv-intc.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/irqchip/irq-riscv-intc.c +17 -0
@@ -46,10 +46,27 @@ static void riscv_intc_irq_unmask(struct irq_data *d)csr_set (CSR_IE ,BIT (d->hwirq)); } +static void riscv_intc_irq_eoi (struct irq_data *d) +{ +/* +* The RISC-V INTC driver uses handle_percpu_devid_irq() flow +* for the per-HART local interrupts and child irqchip drivers +* (such as PLIC, SBI IPI, CLINT, APLIC, IMSIC, etc) implement +* chained handlers for the per-HART local interrupts. +* +* In the absence of irq_eoi(), the chained_irq_enter() and +* chained_irq_exit() functions (used by child irqchip drivers) +* will do unnecessary mask/unmask of per-HART local interrupts +* at the time of handling interrupts. To avoid this, we provide +* an empty irq_eoi() callback for RISC-V INTC irqchip. +*/ +} +static struct irq_chip riscv_intc_chip = { .name ="RISC-V INTC" , .irq_mask = riscv_intc_irq_mask, .irq_unmask = riscv_intc_irq_unmask, + .irq_eoi = riscv_intc_irq_eoi, }; static int riscv_intc_domain_map(struct irq_domain *d, unsigned int irq,
Signature · 1 line
2.34.1
PATCH v15 9/9 irqchip/apple-aic: Move over to core ipi-mux
In reply to Anup PatelFrom: Marc Zyngier <[email protected]>
Now that the complexity of the AIC IPI mux has been copied into the core code for the benefit of the riscv architecture, shrink the AIC driver by the same amount by using that infrastructure.
--- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-apple-aic.c | 161 ++------------------------------ 2 files changed, 9 insertions(+), 153 deletions(-)
drivers/irqchip/Kconfig +1 -0
@@ -675,6 +675,7 @@ config APPLE_AIC bool "Apple Interrupt Controller (AIC)" depends on ARM64 depends on ARCH_APPLE || COMPILE_TEST + select GENERIC_IRQ_IPI_MUX help Support for the Apple Interrupt Controller found on Apple Silicon SoCs, such as the M1.
drivers/irqchip/irq-apple-aic.c +8 -153
204 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v15 9/9] irqchip/apple-aic: Move over to core ipi-mux
Quoted 227 lines · Anup Patel
From: Marc Zyngier <[email protected]>
Now that the complexity of the AIC IPI mux has been copied into the core code for the benefit of the riscv architecture, shrink the AIC driver by the same amount by using that infrastructure.
Signed-off-by Marc Zyngier <[email protected]>--- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-apple-aic.c | 161 ++------------------------------ 2 files changed, 9 insertions(+), 153 deletions(-)drivers/irqchip/Kconfig +1
-0@@ -675,6 +675,7 @@ config APPLE_AIC bool "Apple Interrupt Controller (AIC)" depends on ARM64 depends on ARCH_APPLE || COMPILE_TEST + select GENERIC_IRQ_IPI_MUX help Support for the Apple Interrupt Controller found on Apple Silicon SoCs, such as the M1.drivers/irqchip/irq-apple-aic.c +8
-150@@ -292,7 +292,6 @@ struct aic_irq_chip {void __iomem *base;void __iomem *event;struct irq_domain *hw_domain; -struct irq_domain *ipi_domain;struct {cpumask_t aff; } *fiq_aff[AIC_NR_FIQ ];@@ -307,9 +306,6 @@ struct aic_irq_chip { static DEFINE_PER_CPU(uint32_t, aic_fiq_unmasked); -static DEFINE_PER_CPU(atomic_t, aic_vipi_flag); -static DEFINE_PER_CPU(atomic_t, aic_vipi_enable); -static struct aic_irq_chip *aic_irqc;static void aic_handle_ipi (struct pt_regs *regs);@@ -751,98 +747,8 @@ static void aic_ipi_send_fast(int cpu)isb (); } -static void aic_ipi_mask (struct irq_data *d) -{ -u32 irq_bit =BIT (irqd_to_hwirq (d)); - -/* No specific ordering requirements needed here. */ -atomic_andnot (irq_bit,this_cpu_ptr (&aic_vipi_enable)); -} - -static void aic_ipi_unmask (struct irq_data *d) -{ -struct aic_irq_chip *ic =irq_data_get_irq_chip_data (d); -u32 irq_bit =BIT (irqd_to_hwirq (d)); - -atomic_or (irq_bit,this_cpu_ptr (&aic_vipi_enable)); - -/* -* The atomic_or() above must complete before the atomic_read() -* below to avoid racing aic_ipi_send_mask(). -*/ -smp_mb__after_atomic (); - -/* -* If a pending vIPI was unmasked, raise a HW IPI to ourselves. -* No barriers needed here since this is a self-IPI. -*/ -if (atomic_read (this_cpu_ptr (&aic_vipi_flag)) & irq_bit) { -if (static_branch_likely (&use_fast_ipi)) -aic_ipi_send_fast (smp_processor_id ()); -else -aic_ic_write (ic,AIC_IPI_SEND ,AIC_IPI_SEND_CPU (smp_processor_id ())); - } -} - -static void aic_ipi_send_mask (struct irq_data *d,const struct cpumask *mask) -{ -struct aic_irq_chip *ic =irq_data_get_irq_chip_data (d); -u32 irq_bit =BIT (irqd_to_hwirq (d)); -u32 send =0 ; -int cpu; -unsigned long pending; - -for_each_cpu (cpu, mask) { -/* -* This sequence is the mirror of the one in aic_ipi_unmask(); -* see the comment there. Additionally, release semantics -* ensure that the vIPI flag set is ordered after any shared -* memory accesses that precede it. This therefore also pairs -* with the atomic_fetch_andnot in aic_handle_ipi(). -*/ - pending =atomic_fetch_or_release (irq_bit,per_cpu_ptr (&aic_vipi_flag, cpu)); - -/* -* The atomic_fetch_or_release() above must complete before the -* atomic_read() below to avoid racing aic_ipi_unmask(). -*/ -smp_mb__after_atomic (); - -if (!(pending & irq_bit) && - (atomic_read (per_cpu_ptr (&aic_vipi_enable, cpu)) & irq_bit)) { -if (static_branch_likely (&use_fast_ipi)) -aic_ipi_send_fast (cpu); -else - send |=AIC_IPI_SEND_CPU (cpu); - } - } - -/* -* The flag writes must complete before the physical IPI is issued -* to another CPU. This is implied by the control dependency on -* the result of atomic_read_acquire() above, which is itself -* already ordered after the vIPI flag write. -*/ -if (send) -aic_ic_write (ic,AIC_IPI_SEND , send); -} - -static struct irq_chip ipi_chip = { - .name ="AIC-IPI" , - .irq_mask = aic_ipi_mask, - .irq_unmask = aic_ipi_unmask, - .ipi_send_mask = aic_ipi_send_mask, -}; - -/* -* IPI IRQ domain -*/ -static void aic_handle_ipi (struct pt_regs *regs) { -int i; -unsigned long enabled, firing; -/* * Ack the IPI. We need to order this after the AIC event read, but * that is enforced by normal MMIO ordering guarantees. @@ -857,27 +763,7 @@ static void aic_handle_ipi(struct pt_regs *regs)aic_ic_write (aic_irqc,AIC_IPI_ACK ,AIC_IPI_OTHER ); } -/* -* The mask read does not need to be ordered. Only we can change -* our own mask anyway, so no races are possible here, as long as -* we are properly in the interrupt handler (which is covered by -* the barrier that is part of the top-level AIC handler's readl()). -*/ - enabled =atomic_read (this_cpu_ptr (&aic_vipi_enable)); - -/* -* Clear the IPIs we are about to handle. This pairs with the -* atomic_fetch_or_release() in aic_ipi_send_mask(), and needs to be -* ordered after the aic_ic_write() above (to avoid dropping vIPIs) and -* before IPI handling code (to avoid races handling vIPIs before they -* are signaled). The former is taken care of by the release semantics -* of the write portion, while the latter is taken care of by the -* acquire semantics of the read portion. -*/ - firing =atomic_fetch_andnot (enabled,this_cpu_ptr (&aic_vipi_flag)) & enabled; - -for_each_set_bit (i, &firing,AIC_NR_SWIPI ) -generic_handle_domain_irq (aic_irqc->ipi_domain, i); +ipi_mux_process ();/* * No ordering needed here; at worst this just changes the timing of @@ -887,55 +773,24 @@ static void aic_handle_ipi(struct pt_regs *regs)aic_ic_write (aic_irqc,AIC_IPI_MASK_CLR ,AIC_IPI_OTHER ); } -static int aic_ipi_alloc (struct irq_domain *d,unsigned int virq, -unsigned int nr_irqs,void *args) +static void aic_ipi_send_single (unsigned int cpu) { -int i; - -for (i =0 ; i < nr_irqs; i++) { -irq_set_percpu_devid (virq + i); -irq_domain_set_info (d, virq + i, i, &ipi_chip, d->host_data, - handle_percpu_devid_irq,NULL ,NULL ); - } - -return 0 ; -} - -static void aic_ipi_free (struct irq_domain *d,unsigned int virq,unsigned int nr_irqs) -{ -/* Not freeing IPIs */ +if (static_branch_likely (&use_fast_ipi)) +aic_ipi_send_fast (cpu); +else +aic_ic_write (aic_irqc,AIC_IPI_SEND ,AIC_IPI_SEND_CPU (cpu)); } -static const struct irq_domain_ops aic_ipi_domain_ops = { - .alloc = aic_ipi_alloc, - .free = aic_ipi_free, -}; -static int __init aic_init_smp (struct aic_irq_chip *irqc,struct device_node *node) { -struct irq_domain *ipi_domain;int base_ipi; - ipi_domain =irq_domain_create_linear (irqc->hw_domain->fwnode,AIC_NR_SWIPI , - &aic_ipi_domain_ops, irqc); -if (WARN_ON (!ipi_domain)) -return -ENODEV ; - - ipi_domain->flags |=IRQ_DOMAIN_FLAG_IPI_SINGLE ; -irq_domain_update_bus_token (ipi_domain,DOMAIN_BUS_IPI ); - - base_ipi =__irq_domain_alloc_irqs (ipi_domain,-1 ,AIC_NR_SWIPI , -NUMA_NO_NODE ,NULL , false,NULL ); - -if (WARN_ON (!base_ipi)) { -irq_domain_remove (ipi_domain); + base_ipi =ipi_mux_create (AIC_NR_SWIPI , aic_ipi_send_single); +if (WARN_ON (base_ipi <=0 ))
drivers/irqchip/irq-apple-aic.c static void aic_handle_ipi(struct pt_regs *regs) · line 796
Quoted 10 lines
drivers/irqchip/irq-apple-aic.c +0
-3return -ENODEV ; - }set_smp_ipi_range (base_ipi,AIC_NR_SWIPI ); - irqc->ipi_domain = ipi_domain; -return 0 ; }
Smoke tested on t8112, nothing exploded :)
- Hector
Hector Martin
Acked-byRe: [PATCH v15 9/9] irqchip/apple-aic: Move over to core ipi-mux
Quoted 2 lines · Hector Martin
Quoted 1 line · Anup Patel
From: Marc Zyngier <[email protected]>
<snip>
Quoted 7 lines
Reviewed-by Hector Martin <[email protected]>Tested-by Hector Martin <[email protected]>Smoke tested on t8112, nothing exploded :)
- Hector
Come to think of it, rather than r-b, that (and #3) ought to be:
- Hector