Skip to contentSkip to conversation

objtool: Fix memory leak in create_static_call_sections

PATCH Applied Miaoqian Lin 2 participants 2 messages Dec 5, 2022 – Jan 7, 2023 objtool

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 objtool: Fix memory leak in create_static_call_sections

strdup() allocates memory for key_name. We need to release the memory in the following error paths. Add free to avoid memory leak.

Fixes 1e7e47883830 ("x86/static_call: Add inline static call implementation for x86-64")
---
 tools/objtool/check.c | 2 ++
 1 file changed, 2 insertions(+)
tools/objtool/check.c +2 -0
index 43ec14c29a60..55ce695017f8 100644
@@ -668,6 +668,7 @@ static int create_static_call_sections(struct objtool_file *file)
 		if (strncmp(key_name, STATIC_CALL_TRAMP_PREFIX_STR,
 			    STATIC_CALL_TRAMP_PREFIX_LEN)) {
 			WARN("static_call: trampoline name malformed: %s", key_name);
+			free(key_name);
 			return -1;
 		}
 		tmp = key_name + STATIC_CALL_TRAMP_PREFIX_LEN - STATIC_CALL_KEY_PREFIX_LEN;
@@ -677,6 +678,7 @@ static int create_static_call_sections(struct objtool_file *file)
 		if (!key_sym) {
 			if (!opts.module) {
 				WARN("static_call: can't find static_call_key symbol: %s", tmp);
+				free(key_name);
 				return -1;
 			}
 
Signature · 1 line
2.25.1
merge bot Applied
#1 lore raw

[tip: objtool/core] objtool: Fix memory leak in create_static_call_sections()

The following commit has been merged into the objtool/core branch of tip:

The following commit has been merged into the objtool/core branch of tip:

Commit-ID:     3da73f102309fe29150e5c35acd20dd82063ff67
Gitweb:        https://git.kernel.org/tip/3da73f102309fe29150e5c35acd20dd82063ff67
Author:        Miaoqian Lin <[email protected]>
AuthorDate:    Mon, 05 Dec 2022 12:06:42 +04:00
Committer:     Ingo Molnar <[email protected]>
CommitterDate: Sat, 07 Jan 2023 11:45:24 +01:00

objtool: Fix memory leak in create_static_call_sections()

strdup() allocates memory for key_name. We need to release the memory in the following error paths. Add free() to avoid memory leak.

Fixes 1e7e47883830 ("x86/static_call: Add inline static call implementation for x86-64")
Cc Josh Poimboeuf <[email protected]>
Cc Peter Zijlstra <[email protected]>
---
 tools/objtool/check.c | 2 ++
 1 file changed, 2 insertions(+)
tools/objtool/check.c +2 -0
index 4350be7..cab1a16 100644
@@ -679,6 +679,7 @@ static int create_static_call_sections(struct objtool_file *file)
 		if (strncmp(key_name, STATIC_CALL_TRAMP_PREFIX_STR,
 			    STATIC_CALL_TRAMP_PREFIX_LEN)) {
 			WARN("static_call: trampoline name malformed: %s", key_name);
+			free(key_name);
 			return -1;
 		}
 		tmp = key_name + STATIC_CALL_TRAMP_PREFIX_LEN - STATIC_CALL_KEY_PREFIX_LEN;
@@ -688,6 +689,7 @@ static int create_static_call_sections(struct objtool_file *file)
 		if (!key_sym) {
 			if (!opts.module) {
 				WARN("static_call: can't find static_call_key symbol: %s", tmp);
+				free(key_name);
 				return -1;
 			}