Skip to contentSkip to conversation

xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

PATCH In review [email protected] 3 participants 7 messages Dec 5, 2022 – Dec 12, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

From: Mingli Yu <[email protected]>

xf86-input-synaptics depends on virtual/xserver which needs opengl DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.

---
 meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-driver/xorg-driver-common.inc +1 -1
index 8b3f19426b..3fc54af3e4 100644
@@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
 inherit ${XORGBUILDCLASS} pkgconfig features_check
 
 # depends on virtual/xserver
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 # FIXME: We don't want to include the libtool archives (*.la) from modules
 # directory, as they serve no useful purpose. Upstream should fix Makefile.am
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 packagegroup-core-x11-xserver: add opengl to REQUIRED_DISTRO_FEATURES

From: Mingli Yu <[email protected]>

Fixes:
ERROR: Nothing RPROVIDES 'xf86-video-vesa' (but /build/layers/oe-core/meta/recipes-graphics/packagegroups/packagegroup-core-x11-xserver.bb RDEPENDS on or otherwise requires it) xf86-video-vesa was skipped: missing required distro feature 'opengl' (not in DISTRO_FEATURES)
NOTE: Runtime target 'xf86-video-vesa' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['xf86-video-vesa']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'packagegroup-core-x11-xserver', 'xf86-video-vesa']

---
 .../packagegroups/packagegroup-core-x11-base.bb                 | 2 +-
 .../packagegroups/packagegroup-core-x11-xserver.bb              | 2 +-
 meta/recipes-graphics/packagegroups/packagegroup-core-x11.bb    | 2 +-
 meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
meta/recipes-graphics/packagegroups/packagegroup-core-x11-base.bb +1 -1
index 0185c93354..042b8cb30e 100644
@@ -4,7 +4,7 @@ PR = "r1"
 
 inherit packagegroup features_check
 # rdepends on matchbox-wm
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 RDEPENDS:${PN} = "\
     packagegroup-core-x11-xserver \
meta/recipes-graphics/packagegroups/packagegroup-core-x11-xserver.bb +1 -1
index 3bb308fbba..32cecfb8a1 100644
@@ -9,7 +9,7 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
 
 inherit packagegroup features_check
 # rdepends on XSERVER
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 XSERVER ?= "xserver-xorg xf86-video-fbdev"
 XSERVERCODECS ?= ""
meta/recipes-graphics/packagegroups/packagegroup-core-x11.bb +1 -1
index 9ca058b38b..341a76a02b 100644
@@ -5,7 +5,7 @@
 PR = "r40"
 
 inherit packagegroup features_check
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 PACKAGES = "${PN} ${PN}-utils"
 
meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb +1 -1
index 6866a4d738..aa850ce955 100644
@@ -10,7 +10,7 @@ PR = "r33"
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
 inherit packagegroup features_check
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 PACKAGES = "${PN} ${PN}-base ${PN}-apps ${PN}-games"
 
Signature · 1 line
2.25.1
#2 lore raw
In reply to [email protected]

Both of these patches seem very wrong. X11 definitely does not require opengl. I just confirmed it by building xf86-input-synaptics without opengl in DISTRO_FEATURES.

Can you show how the issue can be reproduced on plain poky? It seems like your local config or distro or BSP layer does something which triggers this.

Alex

Quoted 36 lines · Mingli

From: Mingli Yu <[email protected]>

xf86-input-synaptics depends on virtual/xserver which needs opengl DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.

---
 meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-driver/xorg-driver-common.inc +1 -2
index 8b3f19426b..3fc54af3e4 100644
@@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
 inherit ${XORGBUILDCLASS} pkgconfig features_check
 
 # depends on virtual/xserver
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 # FIXME: We don't want to include the libtool archives (*.la) from modules
 # directory, as they serve no useful purpose. Upstream should fix Makefile.am
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174279): https://lists.openembedded.org/g/openembedded-core/message/174279
Mute This Topic: https://lists.openembedded.org/mt/95465698/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw

Hi Alex,

The error as below:
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/meta-openembedded/meta-oe/recipes-graphics/xorg-driver/xf86-video-amdgpu_22.0.0.bb DEPENDS on or otherwise requires it). Close matches:
virtual/libc
virtual/libomxil
virtual/libusb0
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-video-amdgpu', 'virtual/libgbm']

Thanks,
________________________________
From: [email protected] <[email protected]> on behalf of Alexander Kanavin <[email protected]>
Sent: Monday, December 5, 2022 18:04
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Both of these patches seem very wrong. X11 definitely does not require opengl. I just confirmed it by building xf86-input-synaptics without opengl in DISTRO_FEATURES.

Can you show how the issue can be reproduced on plain poky? It seems like your local config or distro or BSP layer does something which triggers this.

Alex

Quoted 30 lines · Mingli

From: Mingli Yu <[email protected]>

xf86-input-synaptics depends on virtual/xserver which needs opengl DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.

---
 meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-driver/xorg-driver-common.inc +1 -2
index 8b3f19426b..3fc54af3e4 100644
@@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
 inherit ${XORGBUILDCLASS} pkgconfig features_check
 
 # depends on virtual/xserver
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 # FIXME: We don't want to include the libtool archives (*.la) from modules
 # directory, as they serve no useful purpose. Upstream should fix Makefile.am
--

2.25.1

#4 lore raw

Hello,

this means that xf86-video-amdgpu_22.0.0.bb needs the REQUIRED_DISTRO_FEATURES = "opengl"
line, but other x11 recipes do not need to be changed.

Alex

Quoted 65 lines · Mingli

Hi Alex,

The error as below:
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/meta-openembedded/meta-oe/recipes-graphics/xorg-driver/xf86-video-amdgpu_22.0.0.bb DEPENDS on or otherwise requires it). Close matches:
virtual/libc
virtual/libomxil
virtual/libusb0
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-video-amdgpu', 'virtual/libgbm']

Thanks,
________________________________
From: [email protected] <[email protected]> on behalf of Alexander Kanavin <[email protected]>
Sent: Monday, December 5, 2022 18:04
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Both of these patches seem very wrong. X11 definitely does not require opengl. I just confirmed it by building xf86-input-synaptics without opengl in DISTRO_FEATURES.

Can you show how the issue can be reproduced on plain poky? It seems like your local config or distro or BSP layer does something which triggers this.

Alex

Quoted 30 lines · Mingli

From: Mingli Yu <[email protected]>

xf86-input-synaptics depends on virtual/xserver which needs opengl DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.

---
 meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-driver/xorg-driver-common.inc +1 -2
index 8b3f19426b..3fc54af3e4 100644
@@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
 inherit ${XORGBUILDCLASS} pkgconfig features_check
 
 # depends on virtual/xserver
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 # FIXME: We don't want to include the libtool archives (*.la) from modules
 # directory, as they serve no useful purpose. Upstream should fix Makefile.am
--

2.25.1

#5 lore raw

Hi Alex,

Not only xf86-video-amdgpu_22.0.0.bb needs the REQUIRED_DISTRO_FEATURES = "opengl", there still comes below error if we only add REQUIRED_DISTRO_FEATURES = "opengl" for xf86-video-amdgpu_22.0.0.bb.
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/oe-core/meta/recipes-graphics/xorg-xserver/xserver-xorg_21.1.4.bb DEPENDS on or otherwise requires it) libmali-xlnx PROVIDES virtual/libgbm but was skipped: incompatible with machine qemux86-64 (not in COMPATIBLE_MACHINE)
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-input-mouse', 'virtual/xserver', 'virtual/libgbm']

Thanks,

________________________________
From: Alexander Kanavin <[email protected]>
Sent: Friday, December 9, 2022 17:05
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

this means that xf86-video-amdgpu_22.0.0.bb needs the REQUIRED_DISTRO_FEATURES = "opengl"
line, but other x11 recipes do not need to be changed.

Alex

Quoted 65 lines · Mingli

Hi Alex,

The error as below:
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/meta-openembedded/meta-oe/recipes-graphics/xorg-driver/xf86-video-amdgpu_22.0.0.bb DEPENDS on or otherwise requires it). Close matches:
virtual/libc
virtual/libomxil
virtual/libusb0
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-video-amdgpu', 'virtual/libgbm']

Thanks,
________________________________
From: [email protected] <[email protected]> on behalf of Alexander Kanavin <[email protected]>
Sent: Monday, December 5, 2022 18:04
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Both of these patches seem very wrong. X11 definitely does not require opengl. I just confirmed it by building xf86-input-synaptics without opengl in DISTRO_FEATURES.

Can you show how the issue can be reproduced on plain poky? It seems like your local config or distro or BSP layer does something which triggers this.

Alex

Quoted 30 lines · Mingli

From: Mingli Yu <[email protected]>

xf86-input-synaptics depends on virtual/xserver which needs opengl DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.

---
 meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-driver/xorg-driver-common.inc +1 -2
index 8b3f19426b..3fc54af3e4 100644
@@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
 inherit ${XORGBUILDCLASS} pkgconfig features_check
 
 # depends on virtual/xserver
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 # FIXME: We don't want to include the libtool archives (*.la) from modules
 # directory, as they serve no useful purpose. Upstream should fix Makefile.am
--

2.25.1

#6 lore raw

"libmali-xlnx PROVIDES virtual/libgbm but was skipped: incompatible with machine qemux86-64 (not in COMPATIBLE_MACHINE)"

This is the key error. Why is libmali being set as the libgbm provider if it's not compatible?

Alex

Quoted 95 lines · Mingli

Hi Alex,

Not only xf86-video-amdgpu_22.0.0.bb needs the REQUIRED_DISTRO_FEATURES = "opengl", there still comes below error if we only add REQUIRED_DISTRO_FEATURES = "opengl" for xf86-video-amdgpu_22.0.0.bb.
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/oe-core/meta/recipes-graphics/xorg-xserver/xserver-xorg_21.1.4.bb DEPENDS on or otherwise requires it) libmali-xlnx PROVIDES virtual/libgbm but was skipped: incompatible with machine qemux86-64 (not in COMPATIBLE_MACHINE)
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-input-mouse', 'virtual/xserver', 'virtual/libgbm']

Thanks,

________________________________
From: Alexander Kanavin <[email protected]>
Sent: Friday, December 9, 2022 17:05
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

this means that xf86-video-amdgpu_22.0.0.bb needs the REQUIRED_DISTRO_FEATURES = "opengl"
line, but other x11 recipes do not need to be changed.

Alex

Quoted 65 lines · Mingli

Hi Alex,

The error as below:
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/meta-openembedded/meta-oe/recipes-graphics/xorg-driver/xf86-video-amdgpu_22.0.0.bb DEPENDS on or otherwise requires it). Close matches:
virtual/libc
virtual/libomxil
virtual/libusb0
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-video-amdgpu', 'virtual/libgbm']

Thanks,
________________________________
From: [email protected] <[email protected]> on behalf of Alexander Kanavin <[email protected]>
Sent: Monday, December 5, 2022 18:04
To: Yu, Mingli <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Both of these patches seem very wrong. X11 definitely does not require opengl. I just confirmed it by building xf86-input-synaptics without opengl in DISTRO_FEATURES.

Can you show how the issue can be reproduced on plain poky? It seems like your local config or distro or BSP layer does something which triggers this.

Alex

Quoted 30 lines · Mingli

From: Mingli Yu <[email protected]>

xf86-input-synaptics depends on virtual/xserver which needs opengl DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.

---
 meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-driver/xorg-driver-common.inc +1 -2
index 8b3f19426b..3fc54af3e4 100644
@@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
 inherit ${XORGBUILDCLASS} pkgconfig features_check
 
 # depends on virtual/xserver
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 # FIXME: We don't want to include the libtool archives (*.la) from modules
 # directory, as they serve no useful purpose. Upstream should fix Makefile.am
--

2.25.1