ipmi/watchdog: use strscpy() to instead of strncpy()
PATCH 1/1 ipmi/watchdog: use strscpy() to instead of strncpy()
Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/char/ipmi/ipmi_watchdog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/char/ipmi/ipmi_watchdog.c +1 -2
@@ -213,8 +213,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp)char valcp[16 ];char *s; -strncpy (valcp, val,15 ); - valcp[15 ] ='\0' ; +strscpy (valcp, val,16 ); s =strstrip (valcp);
Signature · 1 line
2.15.2
Quoted 4 lines · On Mon, Dec 05, 2022 at 07:36:40PM +0800, [email protected] wrote:
Xu Panda <[email protected]>
The implementation of
strscpy()is more robust and safer. That's now the recommended way to copy NUL terminated strings.
This looks right. Applied, thanks.
-corey
Quoted 23 lines
Signed-off-by Xu Panda <[email protected]>Signed-off-by Yang Yang <[email protected]>--- drivers/char/ipmi/ipmi_watchdog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/char/ipmi/ipmi_watchdog.c +1
-2@@ -213,8 +213,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp)char valcp[16 ];char *s; -strncpy (valcp, val,15 ); - valcp[15 ] ='\0' ; +strscpy (valcp, val,16 ); s =strstrip (valcp);Signature · 1 line
2.15.2