Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled

PATCH In review Lee Jones 2 participants 5 messages Dec 6, 2022

Subsystems (2)

Stable branch Library code

lore

Share & tools

lore

Lee Jones

author

2022-12-06 12:44 UTC #0 lore raw

PATCH 1/1 Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled

commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.

When enabled, KASAN enlarges function's stack-frames. Pushing quite a few over the current threshold. This can mainly be seen on 32-bit architectures where the present limit (when !GCC) is a lowly 1024-Bytes.

Link https://lkml.kernel.org/r/[email protected] open here

Signed-off-by Lee Jones <[email protected]>

Acked-by Arnd Bergmann <[email protected]>

Cc Alex Deucher <[email protected]>

Cc "Christian König" <[email protected]>

Cc Daniel Vetter <[email protected]>

Cc David Airlie <[email protected]>

Cc Harry Wentland <[email protected]>

Cc Leo Li <[email protected]>

Cc Maarten Lankhorst <[email protected]>

Cc Maxime Ripard <[email protected]>

Cc Nathan Chancellor <[email protected]>

Cc Nick Desaulniers <[email protected]>

Cc "Pan, Xinhui" <[email protected]>

Cc Rodrigo Siqueira <[email protected]>

Cc Thomas Zimmermann <[email protected]>

Cc Tom Rix <[email protected]>

Cc <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

[Lee: Back-ported to linux-5.15.y]

Signed-off-by Lee Jones <[email protected]>

---
 lib/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)

lib/Kconfig.debug +1 -0

index 1699b21245586..cfbadc7c919d8 100644
@@ -353,6 +353,7 @@ config FRAME_WARN
 	range 0 8192
 	default 2048 if GCC_PLUGIN_LATENT_ENTROPY
 	default 1536 if (!64BIT && (PARISC || XTENSA))
+	default 1280 if KASAN && !64BIT
 	default 1024 if (!64BIT && !PARISC)
 	default 2048 if 64BIT
 	help

Signature · 1 line

2.39.0.rc0.267.gcb52ba06e7-goog

Greg KH

maintainer

2022-12-06 12:50 UTC #1 lore raw

Quoted 19 lines · Lee Jones

commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
When enabled, KASAN enlarges function's stack-frames. Pushing quite a few over the current threshold. This can mainly be seen on 32-bit architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
Link https://lkml.kernel.org/r/[email protected] open here
Signed-off-by Lee Jones <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Christian König" <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc David Airlie <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Leo Li <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>

Quoted 8 lines

Cc "Pan, Xinhui" <[email protected]>
Cc Rodrigo Siqueira <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc Tom Rix <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
[Lee: Back-ported to linux-5.15.y]
Signed-off-by Lee Jones <[email protected]>

This is already in the -rc1 releases of 5.15 (and 5.10) that went out yesterday, right?

Or is that version not correct somehow?

thanks,

greg k-h

Lee Jones

author

2022-12-06 14:01 UTC #2 lore raw

Quoted 29 lines · Greg KH

Quoted 19 lines · Lee Jones
commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
When enabled, KASAN enlarges function's stack-frames. Pushing quite a few over the current threshold. This can mainly be seen on 32-bit architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
Link https://lkml.kernel.org/r/[email protected] open here
Signed-off-by Lee Jones <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Christian König" <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc David Airlie <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Leo Li <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Quoted 8 lines
Cc "Pan, Xinhui" <[email protected]>
Cc Rodrigo Siqueira <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc Tom Rix <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
[Lee: Back-ported to linux-5.15.y]
Signed-off-by Lee Jones <[email protected]>

Quoted 4 lines

This is already in the -rc1 releases of 5.15 (and 5.10) that went out yesterday, right?
Or is that version not correct somehow?

Did you fix the back-port already? I was working on the back of:

FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.10-stable tree
FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.15-stable tree

Signature · 1 line

Lee Jones [李琼斯]

Greg KH

maintainer

2022-12-06 15:59 UTC #3 lore raw

Quoted 34 lines · Lee Jones

Quoted 32 lines · Greg KH
Quoted 19 lines · Lee Jones
commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
When enabled, KASAN enlarges function's stack-frames. Pushing quite a few over the current threshold. This can mainly be seen on 32-bit architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
Link https://lkml.kernel.org/r/[email protected] open here
Signed-off-by Lee Jones <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Christian König" <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc David Airlie <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Leo Li <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Quoted 8 lines
Cc "Pan, Xinhui" <[email protected]>
Cc Rodrigo Siqueira <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc Tom Rix <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
[Lee: Back-ported to linux-5.15.y]
Signed-off-by Lee Jones <[email protected]>
This is already in the -rc1 releases of 5.15 (and 5.10) that went out yesterday, right?

Quoted 6 lines

Quoted 1 line
Or is that version not correct somehow?
Did you fix the back-port already? I was working on the back of:
FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.10-stable tree
FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.15-stable tree

Sasha seems to have already fixed it, look at the -rc releases for the backports.

thanks,

greg k-h

Lee Jones

author

2022-12-06 16:18 UTC #4 lore raw

Quoted 37 lines · Greg KH

Quoted 36 lines · Lee Jones
Quoted 33 lines · Greg KH
Quoted 19 lines · Lee Jones
commit 152fe65f300e1819d59b80477d3e0999b4d5d7d2 upstream.
When enabled, KASAN enlarges function's stack-frames. Pushing quite a few over the current threshold. This can mainly be seen on 32-bit architectures where the present limit (when !GCC) is a lowly 1024-Bytes.
Link https://lkml.kernel.org/r/[email protected] open here
Signed-off-by Lee Jones <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
Cc Alex Deucher <[email protected]>
Cc "Christian König" <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc David Airlie <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Leo Li <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Quoted 8 lines
Cc "Pan, Xinhui" <[email protected]>
Cc Rodrigo Siqueira <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc Tom Rix <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
[Lee: Back-ported to linux-5.15.y]
Signed-off-by Lee Jones <[email protected]>
This is already in the -rc1 releases of 5.15 (and 5.10) that went out yesterday, right?
Or is that version not correct somehow?

Quoted 7 lines

Quoted 4 lines
Did you fix the back-port already? I was working on the back of:
FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.10-stable tree
FAILED: patch "[PATCH] Kconfig.debug: provide a little extra FRAME_WARN leeway when" failed to apply to 5.15-stable tree
Sasha seems to have already fixed it, look at the -rc releases for the backports.

Works for me. Thank you Sasha.

Signature · 1 line

Lee Jones [李琼斯]