Skip to contentSkip to conversation

media: max9286: Fix memleak in max9286_v4l2_register()

PATCH In review Shang XiaoJing 3 participants 8 messages Dec 6, 2022 – Dec 8, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: max9286: Fix memleak in max9286_v4l2_register()

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

kmemleak: 5 new suspected memory leaks (see /sys/kernel/debug/kmemleak)

unreferenced object 0xffff88810defc400 (size 256):
comm "python3", pid 278, jiffies 4294737563 (age 31.978s) hex dump (first 32 bytes):

    28 06 a7 0a 81 88 ff ff 00 fe 22 12 81 88 ff ff  (.........".....
    10 c4 ef 0d 81 88 ff ff 10 c4 ef 0d 81 88 ff ff  ................
  backtrace:
    [<00000000191de6a7>] __kmalloc_node+0x44/0x1b0
    [<000000002f4912b7>] kvmalloc_node+0x34/0x180
    [<0000000057dc4cae>] v4l2_ctrl_new+0x325/0x10f0 [videodev]
    [<0000000026030272>] v4l2_ctrl_new_std+0x16f/0x210 [videodev]
    [<00000000f0d9ea2f>] max9286_probe+0x76e/0xbff [max9286]
    [<00000000ea8f6455>] i2c_device_probe+0x28d/0x680
    [<0000000087529af3>] really_probe+0x17c/0x3f0
    [<00000000b08be526>] __driver_probe_device+0xe3/0x170
    [<000000004382edea>] driver_probe_device+0x49/0x120
    [<000000007bde528a>] __device_attach_driver+0xf7/0x150
    [<000000009f9c6ab4>] bus_for_each_drv+0x114/0x180
    [<00000000c8aaf588>] __device_attach+0x1e5/0x2d0
    [<0000000041cc06b9>] bus_probe_device+0x126/0x140
    [<000000002309860d>] device_add+0x810/0x1130
    [<000000002827bf98>] i2c_new_client_device+0x359/0x4f0
    [<00000000593bdc85>] of_i2c_register_device+0xf1/0x110

max9286_v4l2_register() calls v4l2_ctrl_new_std(), but won't free the created v412_ctrl when fwnode_graph_get_endpoint_by_id() failed, which causes the memleak. Call v4l2_ctrl_handler_free() to free the v412_ctrl.

Fixes 66d8c9d2422d ("media: i2c: Add MAX9286 driver")
---
 drivers/media/i2c/max9286.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/max9286.c +1 -0
index 9c083cf14231..d034a67042e3 100644
@@ -932,6 +932,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
 err_put_node:
 	fwnode_handle_put(ep);
 err_async:
+	v4l2_ctrl_handler_free(&priv->ctrls);
 	max9286_v4l2_notifier_unregister(priv);
 
 	return ret;
Signature · 1 line
2.17.1
#1 lore raw

Hi Shang,

Thanks for your work.

Quoted 2 lines · Shang XiaoJing

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

Out of curiosity, what exactly is a bpf mock device?

Quoted 51 lines

kmemleak: 5 new suspected memory leaks (see /sys/kernel/debug/kmemleak)

unreferenced object 0xffff88810defc400 (size 256):
comm "python3", pid 278, jiffies 4294737563 (age 31.978s) hex dump (first 32 bytes):

    28 06 a7 0a 81 88 ff ff 00 fe 22 12 81 88 ff ff  (.........".....
    10 c4 ef 0d 81 88 ff ff 10 c4 ef 0d 81 88 ff ff  ................
  backtrace:
    [<00000000191de6a7>] __kmalloc_node+0x44/0x1b0
    [<000000002f4912b7>] kvmalloc_node+0x34/0x180
    [<0000000057dc4cae>] v4l2_ctrl_new+0x325/0x10f0 [videodev]
    [<0000000026030272>] v4l2_ctrl_new_std+0x16f/0x210 [videodev]
    [<00000000f0d9ea2f>] max9286_probe+0x76e/0xbff [max9286]
    [<00000000ea8f6455>] i2c_device_probe+0x28d/0x680
    [<0000000087529af3>] really_probe+0x17c/0x3f0
    [<00000000b08be526>] __driver_probe_device+0xe3/0x170
    [<000000004382edea>] driver_probe_device+0x49/0x120
    [<000000007bde528a>] __device_attach_driver+0xf7/0x150
    [<000000009f9c6ab4>] bus_for_each_drv+0x114/0x180
    [<00000000c8aaf588>] __device_attach+0x1e5/0x2d0
    [<0000000041cc06b9>] bus_probe_device+0x126/0x140
    [<000000002309860d>] device_add+0x810/0x1130
    [<000000002827bf98>] i2c_new_client_device+0x359/0x4f0
    [<00000000593bdc85>] of_i2c_register_device+0xf1/0x110

max9286_v4l2_register() calls v4l2_ctrl_new_std(), but won't free the created v412_ctrl when fwnode_graph_get_endpoint_by_id() failed, which causes the memleak. Call v4l2_ctrl_handler_free() to free the v412_ctrl.

Fixes 66d8c9d2422d ("media: i2c: Add MAX9286 driver")
---
 drivers/media/i2c/max9286.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/max9286.c +1 -0
index 9c083cf14231..d034a67042e3 100644
@@ -932,6 +932,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
 err_put_node:
 	fwnode_handle_put(ep);
 err_async:
+	v4l2_ctrl_handler_free(&priv->ctrls);
 	max9286_v4l2_notifier_unregister(priv);
 
 	return ret;
Signature · 1 line
2.17.1
Signature · 2 lines
Kind Regards,
Niklas Söderlund
Reviewed-by
#2 lore raw
Quoted 9 lines · Niklas Söderlund

Hi Shang,

Thanks for your work.

Quoted 2 lines · Shang XiaoJing

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

Out of curiosity, what exactly is a bpf mock device?

I'm curious as well, is it something like
https://lwn.net/Articles/906236/ but for I2C devices ? Is the implementation public ?

Quoted 25 lines
Quoted 25 lines

kmemleak: 5 new suspected memory leaks (see /sys/kernel/debug/kmemleak)

unreferenced object 0xffff88810defc400 (size 256):
comm "python3", pid 278, jiffies 4294737563 (age 31.978s) hex dump (first 32 bytes):

    28 06 a7 0a 81 88 ff ff 00 fe 22 12 81 88 ff ff  (.........".....
    10 c4 ef 0d 81 88 ff ff 10 c4 ef 0d 81 88 ff ff  ................
  backtrace:
    [<00000000191de6a7>] __kmalloc_node+0x44/0x1b0
    [<000000002f4912b7>] kvmalloc_node+0x34/0x180
    [<0000000057dc4cae>] v4l2_ctrl_new+0x325/0x10f0 [videodev]
    [<0000000026030272>] v4l2_ctrl_new_std+0x16f/0x210 [videodev]
    [<00000000f0d9ea2f>] max9286_probe+0x76e/0xbff [max9286]
    [<00000000ea8f6455>] i2c_device_probe+0x28d/0x680
    [<0000000087529af3>] really_probe+0x17c/0x3f0
    [<00000000b08be526>] __driver_probe_device+0xe3/0x170
    [<000000004382edea>] driver_probe_device+0x49/0x120
    [<000000007bde528a>] __device_attach_driver+0xf7/0x150
    [<000000009f9c6ab4>] bus_for_each_drv+0x114/0x180
    [<00000000c8aaf588>] __device_attach+0x1e5/0x2d0
    [<0000000041cc06b9>] bus_probe_device+0x126/0x140
    [<000000002309860d>] device_add+0x810/0x1130
    [<000000002827bf98>] i2c_new_client_device+0x359/0x4f0
    [<00000000593bdc85>] of_i2c_register_device+0xf1/0x110
Quoted 6 lines
Quoted 6 lines

max9286_v4l2_register() calls v4l2_ctrl_new_std(), but won't free the created v412_ctrl when fwnode_graph_get_endpoint_by_id() failed, which causes the memleak. Call v4l2_ctrl_handler_free() to free the v412_ctrl.

Fixes 66d8c9d2422d ("media: i2c: Add MAX9286 driver")

Regardless of how this has been tested, the fix looks good.

Quoted 16 lines
Quoted 16 lines
---
 drivers/media/i2c/max9286.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/max9286.c +1 -0
index 9c083cf14231..d034a67042e3 100644
@@ -932,6 +932,7 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
 err_put_node:
 	fwnode_handle_put(ep);
 err_async:
+	v4l2_ctrl_handler_free(&priv->ctrls);
 	max9286_v4l2_notifier_unregister(priv);
 
 	return ret;
Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw
Quoted 5 lines · Laurent Pinchart
Quoted 4 lines · Niklas Söderlund

Hi Shang,

Thanks for your work.

Quoted 8 lines
Quoted 5 lines · Shang XiaoJing
Quoted 2 lines

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

Out of curiosity, what exactly is a bpf mock device?

I'm curious as well, is it something like
https://lwn.net/Articles/906236/ but for I2C devices ?

Yes, I'm using the tool provided by Yongjun, and now it can support for the tests of spi drivers and i2c drivers, which is still in the preliminary validation phase.

Quoted 2 lines

Is the implementation public ?

Will send the test set to the community after the further verification to the tool.

By the way, here's an introduction to the tool, but now only in Chinese:

https://github.com/ChinaLinuxKernel/CLK2022/blob/main/%E5%9F%BA%E4%BA%8EeBPF%E7%9A%84%E8%AE%BE%E5%A4%87%E9%A9%B1%E5%8A%A8%E6%B5%8B%E8%AF%95%E6%A1%86%E6%9E%B6.pdf

Quoted 5 lines

Regardless of how this has been tested, the fix looks good.

Thanks for the review!

Signature · 1 line
Shang XiaoJing
#4 lore raw

Hi Shang,

Quoted 12 lines · shangxiaojing
Quoted 9 lines · Laurent Pinchart
Quoted 8 lines · Niklas Söderlund

Hi Shang,

Thanks for your work.

Quoted 2 lines · Shang XiaoJing

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Out of curiosity, what exactly is a bpf mock device?

I'm curious as well, is it something like
https://lwn.net/Articles/906236/ but for I2C devices ?

Yes, I'm using the tool provided by Yongjun, and now it can support for the tests of spi drivers and i2c drivers, which is still in the preliminary validation phase.

Is there a public repository for the MAX9286 work already available? Or any other V4L2 related device?

Quoted 10 lines
Quoted 3 lines

Is the implementation public ?

Will send the test set to the community after the further verification to the tool.

By the way, here's an introduction to the tool, but now only in Chinese:

https://github.com/ChinaLinuxKernel/CLK2022/blob/main/%E5%9F%BA%E4%BA%8EeBPF%E7%9A%84%E8%AE%BE%E5%A4%87%E9%A9%B1%E5%8A%A8%E6%B5%8B%E8%AF%95%E6%A1%86%E6%9E%B6.pdf

Thanks this was helpful!

Quoted 9 lines
Quoted 6 lines

Regardless of how this has been tested, the fix looks good.

Thanks for the review!

Signature · 1 line
Shang XiaoJing
Signature · 2 lines
Kind Regards,
Niklas Söderlund
#5 lore raw
Quoted 20 lines · Niklas Söderlund

Hi Shang,

Quoted 17 lines · shangxiaojing
Quoted 13 lines · Laurent Pinchart
Quoted 9 lines · Niklas Söderlund

Hi Shang,

Thanks for your work.

Quoted 2 lines · Shang XiaoJing

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

Out of curiosity, what exactly is a bpf mock device?

I'm curious as well, is it something like
https://lwn.net/Articles/906236/ but for I2C devices ?

Quoted 6 lines
Quoted 3 lines

Yes, I'm using the tool provided by Yongjun, and now it can support for the tests of spi drivers and i2c drivers, which is still in the preliminary validation phase.

Is there a public repository for the MAX9286 work already available? Or any other V4L2 related device?

The test of MAX9286 is build temporarily, and maybe here's no public repository yet. V4L2 neither.

I'm sorry but please wait for the completaion of the verification to the mock test tool. And then the tool will push to the community.

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

Is the implementation public ?

Quoted 19 lines
Quoted 6 lines

Will send the test set to the community after the further verification to the tool.

By the way, here's an introduction to the tool, but now only in Chinese:

https://github.com/ChinaLinuxKernel/CLK2022/blob/main/%E5%9F%BA%E4%BA%8EeBPF%E7%9A%84%E8%AE%BE%E5%A4%87%E9%A9%B1%E5%8A%A8%E6%B5%8B%E8%AF%95%E6%A1%86%E6%9E%B6.pdf

Thanks this was helpful!

Quoted 9 lines
Quoted 6 lines

Regardless of how this has been tested, the fix looks good.

Thanks for the review!

Signature · 1 line
Shang XiaoJing

Thanks,

Signature · 1 line
Shang XiaoJing
#6 lore raw

Hello Shang,

Quoted 27 lines · shangxiaojing
Quoted 24 lines · Niklas Söderlund

Hi Shang,

Quoted 20 lines · shangxiaojing
Quoted 5 lines · Laurent Pinchart
Quoted 4 lines · Niklas Söderlund

Hi Shang,

Thanks for your work.

Quoted 8 lines
Quoted 5 lines · Shang XiaoJing
Quoted 2 lines

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

Out of curiosity, what exactly is a bpf mock device?

I'm curious as well, is it something like
https://lwn.net/Articles/906236/ but for I2C devices ?

Yes, I'm using the tool provided by Yongjun, and now it can support for the tests of spi drivers and i2c drivers, which is still in the preliminary validation phase.

Quoted 8 lines
Quoted 2 lines

Is there a public repository for the MAX9286 work already available? Or any other V4L2 related device?

The test of MAX9286 is build temporarily, and maybe here's no public repository yet. V4L2 neither.

I'm sorry but please wait for the completaion of the verification to the mock test tool. And then the tool will push to the community.

No problem, thanks for this sneak preview of what this work can do. Out of curiosity, where will this work be announced? I don't subscribe to many mailing lists.

Quoted 29 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

Is the implementation public ?

Quoted 19 lines
Quoted 6 lines

Will send the test set to the community after the further verification to the tool.

By the way, here's an introduction to the tool, but now only in Chinese:

https://github.com/ChinaLinuxKernel/CLK2022/blob/main/%E5%9F%BA%E4%BA%8EeBPF%E7%9A%84%E8%AE%BE%E5%A4%87%E9%A9%B1%E5%8A%A8%E6%B5%8B%E8%AF%95%E6%A1%86%E6%9E%B6.pdf

Thanks this was helpful!

Quoted 9 lines
Quoted 6 lines

Regardless of how this has been tested, the fix looks good.

Thanks for the review!

Signature · 1 line
Shang XiaoJing

Thanks,

Signature · 1 line
Shang XiaoJing
Signature · 2 lines
Kind Regards,
Niklas Söderlund
#7 lore raw
Quoted 36 lines · Niklas Söderlund

Hello Shang,

Quoted 33 lines · shangxiaojing
Quoted 20 lines · Niklas Söderlund

Hi Shang,

Quoted 17 lines · shangxiaojing
Quoted 13 lines · Laurent Pinchart
Quoted 9 lines · Niklas Söderlund

Hi Shang,

Thanks for your work.

Quoted 2 lines · Shang XiaoJing

There is a kmemleak when testing the media/i2c/max9286.c with bpf mock device:

Out of curiosity, what exactly is a bpf mock device?

I'm curious as well, is it something like
https://lwn.net/Articles/906236/ but for I2C devices ?

Quoted 6 lines
Quoted 3 lines

Yes, I'm using the tool provided by Yongjun, and now it can support for the tests of spi drivers and i2c drivers, which is still in the preliminary validation phase.

Is there a public repository for the MAX9286 work already available? Or any other V4L2 related device?

The test of MAX9286 is build temporarily, and maybe here's no public repository yet. V4L2 neither.

Quoted 6 lines
Quoted 2 lines

I'm sorry but please wait for the completaion of the verification to the mock test tool. And then the tool will push to the community.

No problem, thanks for this sneak preview of what this work can do. Out of curiosity, where will this work be announced? I don't subscribe to many mailing lists.

Sorry, I'm not sure actually, but maybe https://lwn.net/Articles/906236/ can give some suggection to us.

Thanks,

Signature · 1 line
Shang XiaoJing