Skip to contentSkip to conversation

i2c: mux: Convert to use sysfs_emit_at() API

PATCH Superseded [email protected] 2 participants 2 messages Dec 6, 2022

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: mux: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/i2c/muxes/i2c-demux-pinctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/muxes/i2c-demux-pinctrl.c +1 -1
index f7a7405d4350..6dc23aedcaed 100644
@@ -167,7 +167,7 @@ static ssize_t available_masters_show(struct device *dev,
 	int count = 0, i;
 
 	for (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)
-		count += scnprintf(buf + count, PAGE_SIZE - count, "%d:%pOF%c",
+		count += sysfs_emit_at(buf, count, "%d:%pOF%c",
 				   i, priv->chan[i].parent_np,
 				   i == priv->num_chan - 1 ? '\n' : ' ');
 
Signature · 1 line
2.25.1
#1 lore raw

Hi!

Quoted 16 lines · 2022-12-06 at 12:36, [email protected] wrote:

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/i2c/muxes/i2c-demux-pinctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/muxes/i2c-demux-pinctrl.c +0 -0
index f7a7405d4350..6dc23aedcaed 100644

drivers/i2c/muxes/i2c-demux-pinctrl.c static ssize_t available_masters_show(struct device *dev, · line 173

Quoted 8 lines
drivers/i2c/muxes/i2c-demux-pinctrl.c +1 -1
@@ -167,7 +167,7 @@ static ssize_t available_masters_show(struct device *dev,
 	int count = 0, i;
 
 	for (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)
-		count += scnprintf(buf + count, PAGE_SIZE - count, "%d:%pOF%c",
+		count += sysfs_emit_at(buf, count, "%d:%pOF%c",
 				   i, priv->chan[i].parent_np,
 				   i == priv->num_chan - 1 ? '\n' : ' ');
 

You need to adjust the indentation of the two follow-up lines.

Cheers,
Peter