can: ucan: use strscpy() to instead of strncpy()
Subsystems (3)
PATCH 1/1 can: ucan: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/net/can/usb/ucan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/can/usb/ucan.c +2 -3
@@ -1534,9 +1534,8 @@ static int ucan_probe(struct usb_interface *intf, sizeof(union ucan_ctl_payload));if (ret >0 ) {/* copy string while ensuring zero termination */ -strncpy (firmware_str, up->ctl_msg_buffer->raw, -sizeof (union ucan_ctl_payload )); - firmware_str[sizeof (union ucan_ctl_payload )] ='\0' ; +strscpy (firmware_str, up->ctl_msg_buffer->raw, +sizeof (union ucan_ctl_payload ) +1 ); }else {strcpy (firmware_str,"unknown" ); }
Signature · 1 line
2.15.2
Quoted 7 lines · On 07.12.2022 09:09:09, [email protected] wrote:
From: Xu Panda <[email protected]>
The implementation of
strscpy()is more robust and safer. That's now the recommended way to copy NUL terminated strings.Signed-off-by Xu Panda <[email protected]>Signed-off-by Yang Yang <[email protected]>
Applied to linux-can-next.
Thanks,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |