Skip to contentSkip to conversation

iio: adc: vf610_adc: Convert to use sysfs_emit_at() API

PATCH In review [email protected] 2 participants 2 messages Dec 7, 2022 – Dec 9, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: vf610_adc: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/iio/adc/vf610_adc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/vf610_adc.c +1 -2
index ae31aafd2653..dbf80f5f674b 100644
@@ -606,8 +606,7 @@ static ssize_t vf610_show_samp_freq_avail(struct device *dev,
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(info->sample_freq_avail); i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len,
-			"%u ", info->sample_freq_avail[i]);
+		len += sysfs_emit_at(buf, len, "%u ", info->sample_freq_avail[i]);
 
 	/* replace trailing space by newline */
 	buf[len - 1] = '\n';
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: 2022年12月7日 15:35
To: [email protected]
Cc: Bough Chen <[email protected]>; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>; [email protected]
Subject: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit_at() API

Quoted 7 lines

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

Best Regards
Haibo Chen

Quoted 21 lines
---
 drivers/iio/adc/vf610_adc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/vf610_adc.c index renamed from drivers/iio/adc/vf610_adc.c +0 -0

ae31aafd2653..dbf80f5f674b 100644

drivers/iio/adc/vf610_adc.c +1 -2
@@ -606,8 +606,7 @@ static ssize_t vf610_show_samp_freq_avail(struct
 device *dev,
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(info->sample_freq_avail); i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len,
-			"%u ", info->sample_freq_avail[i]);
+		len += sysfs_emit_at(buf, len, "%u ", info->sample_freq_avail[i]);
 
 	/* replace trailing space by newline */

buf[len - 1] = '\n';
--
2.25.1