Skip to contentSkip to conversation

iio: health: afe440x: Convert to use sysfs_emit_at() API

PATCH In review [email protected] 2 participants 2 messages Dec 7, 2022 – Dec 11, 2022 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: health: afe440x: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/iio/health/afe440x.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/health/afe440x.h +1 -3
index 0adea0047eba..7750b1adc423 100644
@@ -122,9 +122,7 @@ static ssize_t _name ## _show(struct device *dev,			\
 	int i;								\
 									\
 	for (i = 0; i < ARRAY_SIZE(_table); i++)			\
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ", \
-				 _table[i].integer,			\
-				 _table[i].fract);			\
+		len += sysfs_emit_at(buf, len, "%d.%06u ", _table[i].integer, _table[i].fract); \
 									\
 	buf[len - 1] = '\n';						\
 									\
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 16 lines · On Wed, 7 Dec 2022 15:37:40 +0800 (CST) <[email protected]> wrote:

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/iio/health/afe440x.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/health/afe440x.h +0 -0
index 0adea0047eba..7750b1adc423 100644

drivers/iio/health/afe440x.h static ssize_t _name ## _show(struct device *dev, \ · line 125

Quoted 7 lines
drivers/iio/health/afe440x.h +1 -3
@@ -122,9 +122,7 @@ static ssize_t _name ## _show(struct device *dev,			\
 	int i;								\
 									\
 	for (i = 0; i < ARRAY_SIZE(_table); i++)			\
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ", \
-				 _table[i].integer,			\
-				 _table[i].fract);			\
+		len += sysfs_emit_at(buf, len, "%d.%06u ", _table[i].integer, _table[i].fract); \

Please keep to the shorter original wrapping on this.
It's fine to go above 80 chars (below 100) if it makes a significant improvement to readability. I don't think that's true here, so better to stick to the shorter length.

Quoted 3 lines
drivers/iio/health/afe440x.h +0 -0
 									\
 	buf[len - 1] = '\n';						\
 									\