Skip to contentSkip to conversation

iio: light: zopt2201: Convert to use sysfs_emit_at() API

PATCH New [email protected] 1 participant 1 message Dec 7, 2022 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: light: zopt2201: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/iio/light/zopt2201.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/iio/light/zopt2201.c +7 -8
index e3bac8b56380..97e5412d3a4e 100644
@@ -438,8 +438,7 @@ static ssize_t zopt2201_show_int_time_available(struct device *dev,
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(zopt2201_resolution); i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len, "0.%06lu ",
-				 zopt2201_resolution[i].us);
+		len += sysfs_emit_at(buf, len, "0.%06lu ", zopt2201_resolution[i].us);
 	buf[len - 1] = '\n';
 
 	return len;
@@ -455,9 +454,9 @@ static ssize_t zopt2201_show_als_scale_avail(struct device *dev,
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(zopt2201_scale_als); i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ",
-				 zopt2201_scale_als[i].scale,
-				 zopt2201_scale_als[i].uscale);
+		len += sysfs_emit_at(buf, len, "%d.%06u ",
+				     zopt2201_scale_als[i].scale,
+				     zopt2201_scale_als[i].uscale);
 	buf[len - 1] = '\n';
 
 	return len;
@@ -471,9 +470,9 @@ static ssize_t zopt2201_show_uvb_scale_avail(struct device *dev,
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(zopt2201_scale_uvb); i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ",
-				 zopt2201_scale_uvb[i].scale,
-				 zopt2201_scale_uvb[i].uscale);
+		len += sysfs_emit_at(buf, len, "%d.%06u ",
+				     zopt2201_scale_uvb[i].scale,
+				     zopt2201_scale_uvb[i].uscale);
 	buf[len - 1] = '\n';
 
 	return len;
Signature · 1 line
2.25.1