iio: st_sensors: Convert to use sysfs_emit_at() API
PATCH 1/1 iio: st_sensors: Convert to use sysfs_emit_at() API
From: ye xingchen <[email protected]>
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
Signed-off-by ye xingchen <[email protected]>
--- drivers/iio/common/st_sensors/st_sensors_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iio/common/st_sensors/st_sensors_core.c +2 -3
@@ -628,8 +628,7 @@ ssize_t st_sensors_sysfs_sampling_frequency_avail(struct device *dev,if (sdata->sensor_settings->odr.odr_avl[i].hz ==0 )break ; - len +=scnprintf (buf + len,PAGE_SIZE - len,"%d " , - sdata->sensor_settings->odr.odr_avl[i].hz); + len +=sysfs_emit_at (buf, len,"%d " , sdata->sensor_settings->odr.odr_avl[i].hz); } buf[len -1 ] ='\n' ;
@@ -651,7 +650,7 @@ ssize_t st_sensors_sysfs_scale_avail(struct device *dev, q = sdata->sensor_settings->fs.fs_avl[i].gain /1000000 ; r = sdata->sensor_settings->fs.fs_avl[i].gain %1000000 ; - len +=scnprintf (buf + len,PAGE_SIZE - len,"%u.%06u " , q, r); + len +=sysfs_emit_at (buf, len,"%u.%06u " , q, r); } buf[len -1 ] ='\n' ;
Signature · 1 line
2.25.1
Jonathan Cameron
maintainerQuoted 16 lines · On Wed, 7 Dec 2022 15:53:55 +0800 (CST) <[email protected]> wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.Signed-off-by ye xingchen <[email protected]>--- drivers/iio/common/st_sensors/st_sensors_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/iio/common/st_sensors/st_sensors_core.c +0
-0
drivers/iio/common/st_sensors/st_sensors_core.c ssize_t st_sensors_sysfs_sampling_frequency_avail(struct device *dev, · line 631
Quoted 6 lines
drivers/iio/common/st_sensors/st_sensors_core.c +1
-2@@ -628,8 +628,7 @@ ssize_t st_sensors_sysfs_sampling_frequency_avail(struct device *dev,if (sdata->sensor_settings->odr.odr_avl[i].hz ==0 )break ; - len +=scnprintf (buf + len,PAGE_SIZE - len,"%d " , - sdata->sensor_settings->odr.odr_avl[i].hz); + len +=sysfs_emit_at (buf, len,"%d " , sdata->sensor_settings->odr.odr_avl[i].hz);
Another case where I would prefer we keep the line break.
Quoted 12 lines
drivers/iio/common/st_sensors/st_sensors_core.c +1
-1} buf[len -1 ] ='\n' ;@@ -651,7 +650,7 @@ ssize_t st_sensors_sysfs_scale_avail(struct device *dev, q = sdata->sensor_settings->fs.fs_avl[i].gain /1000000 ; r = sdata->sensor_settings->fs.fs_avl[i].gain %1000000 ; - len +=scnprintf (buf + len,PAGE_SIZE - len,"%u.%06u " , q, r); + len +=sysfs_emit_at (buf, len,"%u.%06u " , q, r); } buf[len -1 ] ='\n' ;