Skip to contentSkip to conversation

Input: Convert to use sysfs_emit_at() API

PATCH Applied [email protected] 2 participants 2 messages Dec 7, 2022 – Dec 13, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/input/vivaldi-fmap.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/input/vivaldi-fmap.c +2 -3
index 6dae83d96806..ac5edc4d2ab0 100644
@@ -27,10 +27,9 @@ ssize_t vivaldi_function_row_physmap_show(const struct vivaldi_data *data,
 		return 0;
 
 	for (i = 0; i < data->num_function_row_keys; i++)
-		size += scnprintf(buf + size, PAGE_SIZE - size,
-				  "%s%02X", size ? " " : "", physmap[i]);
+		size += sysfs_emit_at(buf, size, "%s%02X", size ? " " : "", physmap[i]);
 	if (size)
-		size += scnprintf(buf + size, PAGE_SIZE - size, "\n");
+		size += sysfs_emit_at(buf, size, "\n");
 
 	return size;
 }
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 7 lines · On Wed, Dec 07, 2022 at 04:44:17PM +0800, [email protected] wrote:

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

Applied, thank you.

Signature · 1 line
Dmitry